You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by kambatla <gi...@git.apache.org> on 2014/12/30 00:19:28 UTC

[GitHub] curator pull request: CURATOR-111: Add authorization(List
GitHub user kambatla opened a pull request:

    https://github.com/apache/curator/pull/59

    CURATOR-111: Add authorization(List<AuthInfo)

    I was able to run the test through IntelliJ, but had trouble building and testing on command line. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kambatla/curator CURATOR-111

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/59.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #59
    
----
commit 71dc640b663057a6acaae1f9af93aea48fee3de9
Author: Karthik Kambatla <ka...@cloudera.com>
Date:   2014-12-29T22:16:55Z

    Patch v1: Add authorization(List<AuthInfo)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] curator pull request: CURATOR-111: Add authorization(List Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/59#discussion_r22815490
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java ---
    @@ -65,7 +69,7 @@
         private final BlockingQueue<OperationAndData<?>>                    backgroundOperations;
         private final NamespaceImpl                                         namespace;
         private final ConnectionStateManager                                connectionStateManager;
    -    private final AtomicReference<AuthInfo>                             authInfo = new AtomicReference<AuthInfo>();
    --- End diff --
    
    Hmm - I don't know why it's an AtomicReference. It doesn't seem necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] curator pull request: CURATOR-111: Add authorization(List Posted by Randgalt <gi...@git.apache.org>.
Github user Randgalt commented on a diff in the pull request:

    https://github.com/apache/curator/pull/59#discussion_r22822318
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java ---
    @@ -65,7 +69,7 @@
         private final BlockingQueue<OperationAndData<?>>                    backgroundOperations;
         private final NamespaceImpl                                         namespace;
         private final ConnectionStateManager                                connectionStateManager;
    -    private final AtomicReference<AuthInfo>                             authInfo = new AtomicReference<AuthInfo>();
    --- End diff --
    
    As I've gotten older my mind has less and less room for information. I forget everything these days. I don't even remember if I wrote this code or someone else did. :(


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] curator pull request: CURATOR-111: Add authorization(List Posted by cammckenzie <gi...@git.apache.org>.
Github user cammckenzie commented on a diff in the pull request:

    https://github.com/apache/curator/pull/59#discussion_r22763552
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java ---
    @@ -65,7 +69,7 @@
         private final BlockingQueue<OperationAndData<?>>                    backgroundOperations;
         private final NamespaceImpl                                         namespace;
         private final ConnectionStateManager                                connectionStateManager;
    -    private final AtomicReference<AuthInfo>                             authInfo = new AtomicReference<AuthInfo>();
    --- End diff --
    
    No, I don't see any issues with it either. Just wondering why it was previously an AtomicReference. Anyway, I think this looks good to merge. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] curator pull request: CURATOR-111: Add authorization(List Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/curator/pull/59


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] curator pull request: CURATOR-111: Add authorization(List Posted by cammckenzie <gi...@git.apache.org>.
Github user cammckenzie commented on a diff in the pull request:

    https://github.com/apache/curator/pull/59#discussion_r22561607
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java ---
    @@ -65,7 +69,7 @@
         private final BlockingQueue<OperationAndData<?>>                    backgroundOperations;
         private final NamespaceImpl                                         namespace;
         private final ConnectionStateManager                                connectionStateManager;
    -    private final AtomicReference<AuthInfo>                             authInfo = new AtomicReference<AuthInfo>();
    --- End diff --
    
    @Randgalt, what was the rationale behind this being an AtomicReference originally? I can't see any thread safety issues as it's only set in the constructor.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] curator pull request: CURATOR-111: Add authorization(List Posted by kambatla <gi...@git.apache.org>.
Github user kambatla commented on a diff in the pull request:

    https://github.com/apache/curator/pull/59#discussion_r22757149
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java ---
    @@ -65,7 +69,7 @@
         private final BlockingQueue<OperationAndData<?>>                    backgroundOperations;
         private final NamespaceImpl                                         namespace;
         private final ConnectionStateManager                                connectionStateManager;
    -    private final AtomicReference<AuthInfo>                             authInfo = new AtomicReference<AuthInfo>();
    --- End diff --
    
    I didn't see any thread-safety issues using List<AuthInfo>


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] curator pull request: CURATOR-111: Add authorization(List Posted by madrob <gi...@git.apache.org>.
Github user madrob commented on a diff in the pull request:

    https://github.com/apache/curator/pull/59#discussion_r22822221
  
    --- Diff: curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java ---
    @@ -65,7 +69,7 @@
         private final BlockingQueue<OperationAndData<?>>                    backgroundOperations;
         private final NamespaceImpl                                         namespace;
         private final ConnectionStateManager                                connectionStateManager;
    -    private final AtomicReference<AuthInfo>                             authInfo = new AtomicReference<AuthInfo>();
    --- End diff --
    
    It was probably an AtomicRef so that it could be marked final and referred to from inside of the anonymous inner class in makeZookeeperFactory.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---