You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Zheng Shao (JIRA)" <ji...@apache.org> on 2009/03/04 02:58:56 UTC
[jira] Created: (HIVE-319) add UDF UNIX_TIMESTAMP
add UDF UNIX_TIMESTAMP
----------------------
Key: HIVE-319
URL: https://issues.apache.org/jira/browse/HIVE-319
Project: Hadoop Hive
Issue Type: New Feature
Components: Query Processor
Affects Versions: 0.3.0
Reporter: Zheng Shao
Assignee: Hao Liu
See http://dev.mysql.com/doc/refman/5.1/en/date-and-time-functions.html#function_unix-timestamp
For now, just use the default time zone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-319) add UDF UNIX_TIMESTAMP
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688859#action_12688859 ]
Namit Jain commented on HIVE-319:
---------------------------------
Looks good - I had some very minor comments:
+ public UDFUnixTimeStamp() {
+ // For now, we just use the default time zone.
+ //formatter.setTimeZone(TimeZone.getTimeZone("UTC"));
+ }
the setting of time zone is commented - it is the default anyway. Can you remove the code and move the comment where formatter is initialized
FunctionRegistry: Although the actual change is pretty small, the change in the patch is pretty big - lots of lines added and deleted - probably spacing issue.
Was it intentional ?
If not, can you remove them - just make your changes ? It becomes difficult to review.
Otherwise, it looks good
> add UDF UNIX_TIMESTAMP
> ----------------------
>
> Key: HIVE-319
> URL: https://issues.apache.org/jira/browse/HIVE-319
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Query Processor
> Affects Versions: 0.3.0
> Reporter: Zheng Shao
> Assignee: Hao Liu
> Attachments: HIVE-319.2.patch, HIVE-319.patch
>
>
> See http://dev.mysql.com/doc/refman/5.1/en/date-and-time-functions.html#function_unix-timestamp
> For now, just use the default time zone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-319) add UDF UNIX_TIMESTAMP
Posted by "Hao Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hao Liu updated HIVE-319:
-------------------------
Status: Patch Available (was: Open)
add Unix_TimeStamp() and Unix_TimeStamp('yyyy-MM-dd HH:mm:ss')
> add UDF UNIX_TIMESTAMP
> ----------------------
>
> Key: HIVE-319
> URL: https://issues.apache.org/jira/browse/HIVE-319
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Query Processor
> Affects Versions: 0.3.0
> Reporter: Zheng Shao
> Assignee: Hao Liu
>
> See http://dev.mysql.com/doc/refman/5.1/en/date-and-time-functions.html#function_unix-timestamp
> For now, just use the default time zone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-319) add UDF UNIX_TIMESTAMP
Posted by "Hao Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hao Liu updated HIVE-319:
-------------------------
Attachment: HIVE-319.2.patch
add another version so user can specify time pattern, for example: unix_timestamp('2009 Mar 20 11:30:01 am', 'yyyy MMM dd h:mm:ss a')
> add UDF UNIX_TIMESTAMP
> ----------------------
>
> Key: HIVE-319
> URL: https://issues.apache.org/jira/browse/HIVE-319
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Query Processor
> Affects Versions: 0.3.0
> Reporter: Zheng Shao
> Assignee: Hao Liu
> Attachments: HIVE-319.2.patch, HIVE-319.patch
>
>
> See http://dev.mysql.com/doc/refman/5.1/en/date-and-time-functions.html#function_unix-timestamp
> For now, just use the default time zone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-319) add UDF UNIX_TIMESTAMP
Posted by "Hao Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hao Liu updated HIVE-319:
-------------------------
Attachment: HIVE-319.3.patch
I've moved the comments up to formatter.
there are some tailing spaces in FunctionRegistry.java, I removed them when I add new udf.
> add UDF UNIX_TIMESTAMP
> ----------------------
>
> Key: HIVE-319
> URL: https://issues.apache.org/jira/browse/HIVE-319
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Query Processor
> Affects Versions: 0.3.0
> Reporter: Zheng Shao
> Assignee: Hao Liu
> Attachments: HIVE-319.2.patch, HIVE-319.3.patch, HIVE-319.patch
>
>
> See http://dev.mysql.com/doc/refman/5.1/en/date-and-time-functions.html#function_unix-timestamp
> For now, just use the default time zone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-319) add UDF UNIX_TIMESTAMP
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688892#action_12688892 ]
Namit Jain commented on HIVE-319:
---------------------------------
+1
looks good
> add UDF UNIX_TIMESTAMP
> ----------------------
>
> Key: HIVE-319
> URL: https://issues.apache.org/jira/browse/HIVE-319
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Query Processor
> Affects Versions: 0.3.0
> Reporter: Zheng Shao
> Assignee: Hao Liu
> Attachments: HIVE-319.2.patch, HIVE-319.3.patch, HIVE-319.patch
>
>
> See http://dev.mysql.com/doc/refman/5.1/en/date-and-time-functions.html#function_unix-timestamp
> For now, just use the default time zone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-319) add UDF UNIX_TIMESTAMP
Posted by "Hao Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hao Liu updated HIVE-319:
-------------------------
Comment: was deleted
(was: add Unix_TimeStamp() and Unix_TimeStamp('yyyy-MM-dd HH:mm:ss'))
> add UDF UNIX_TIMESTAMP
> ----------------------
>
> Key: HIVE-319
> URL: https://issues.apache.org/jira/browse/HIVE-319
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Query Processor
> Affects Versions: 0.3.0
> Reporter: Zheng Shao
> Assignee: Hao Liu
> Attachments: HIVE-319.patch
>
>
> See http://dev.mysql.com/doc/refman/5.1/en/date-and-time-functions.html#function_unix-timestamp
> For now, just use the default time zone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-319) add UDF UNIX_TIMESTAMP
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683761#action_12683761 ]
Zheng Shao commented on HIVE-319:
---------------------------------
Asked by Yi Ma and Chris Putnam.
> add UDF UNIX_TIMESTAMP
> ----------------------
>
> Key: HIVE-319
> URL: https://issues.apache.org/jira/browse/HIVE-319
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Query Processor
> Affects Versions: 0.3.0
> Reporter: Zheng Shao
> Assignee: Hao Liu
>
> See http://dev.mysql.com/doc/refman/5.1/en/date-and-time-functions.html#function_unix-timestamp
> For now, just use the default time zone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-319) add UDF UNIX_TIMESTAMP
Posted by "Hao Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hao Liu updated HIVE-319:
-------------------------
Attachment: HIVE-319.patch
add Unix_TimeStamp() and Unix_TimeStamp('yyyy-MM-dd HH:mm:ss')
> add UDF UNIX_TIMESTAMP
> ----------------------
>
> Key: HIVE-319
> URL: https://issues.apache.org/jira/browse/HIVE-319
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Query Processor
> Affects Versions: 0.3.0
> Reporter: Zheng Shao
> Assignee: Hao Liu
> Attachments: HIVE-319.patch
>
>
> See http://dev.mysql.com/doc/refman/5.1/en/date-and-time-functions.html#function_unix-timestamp
> For now, just use the default time zone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-319) add UDF UNIX_TIMESTAMP
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-319:
----------------------------
Resolution: Fixed
Fix Version/s: 0.3.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
committed. Thanks Hao
> add UDF UNIX_TIMESTAMP
> ----------------------
>
> Key: HIVE-319
> URL: https://issues.apache.org/jira/browse/HIVE-319
> Project: Hadoop Hive
> Issue Type: New Feature
> Components: Query Processor
> Affects Versions: 0.3.0
> Reporter: Zheng Shao
> Assignee: Hao Liu
> Fix For: 0.3.0
>
> Attachments: HIVE-319.2.patch, HIVE-319.3.patch, HIVE-319.patch
>
>
> See http://dev.mysql.com/doc/refman/5.1/en/date-and-time-functions.html#function_unix-timestamp
> For now, just use the default time zone.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.