You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/23 07:31:59 UTC
[GitHub] [pulsar] BewareMyPower opened a new issue #9682: CI cpp-tests is broken now for the latest pulsar-build image
BewareMyPower opened a new issue #9682:
URL: https://github.com/apache/pulsar/issues/9682
**Describe the bug**
Currently, the CI for cpp tests is broken because it uses the `apache/pulsar-build:ubuntu16.04` image as the base image to build cpp client. However, the image was updated yesterday to contain the change of https://github.com/apache/pulsar/pull/9609. This PR add python3 and pip3 and then CMake found python3 by default and tried to find boost python for python3. However, the boost python of `pulsar-build` image was installed by `libboost-all-dev`, which only supports python2.
**To Reproduce**
See recent PR's CI.
```
-- Found the following Boost libraries:
-- system
-- Found PythonLibs: /usr/lib/x86_64-linux-gnu/libpython3.5m.so (found version "3.5.2")
-- PYTHON: 3.5.2
-- DETECTED Python 3
-- Boost version: 1.58.0
```
```
CMake Error at python/CMakeLists.txt:84 (MESSAGE):
Could not find Boost Python library
```
**Expected behavior**
The pulsar-build image should work for cpp-tests.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Desktop (please complete the following information):**
- OS: [e.g. iOS]
**Additional context**
Add any other context about the problem here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on issue #9682: CI cpp-tests is broken now for the latest pulsar-build image
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #9682:
URL: https://github.com/apache/pulsar/issues/9682#issuecomment-783994628
@BewareMyPower are you working on a fix on the build image or should I do it ?
No problem from my side.
Your call
I hope that @aahmed-se @merlimat or anyone how has deploy permissions can fix the problem ASAP
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on issue #9682: CI cpp-tests is broken now for the latest pulsar-build image
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #9682:
URL: https://github.com/apache/pulsar/issues/9682#issuecomment-783988125
@eolivelli I agree with you. Currently it should use the old image and the CI for `pulsar-build` image is necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on issue #9682: CI cpp-tests is broken now for the latest pulsar-build image
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #9682:
URL: https://github.com/apache/pulsar/issues/9682#issuecomment-783982155
@BewareMyPower @aahmed-se probably it would have been better to tag the image with a new name and to not override the old name.
I am sorry I did not ask for it explicitly.
I believe the best way to fix this is to publish again the old image.
We can work on the new image without hurry.
My expectation was to have a new image and test it on CI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap closed issue #9682: CI cpp-tests is broken now for the latest pulsar-build image
Posted by GitBox <gi...@apache.org>.
zymap closed issue #9682:
URL: https://github.com/apache/pulsar/issues/9682
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on issue #9682: CI cpp-tests is broken now for the latest pulsar-build image
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #9682:
URL: https://github.com/apache/pulsar/issues/9682#issuecomment-783997927
Yes.
In the meantime you can test the image locally.
you build it and tag it with your preferred name and then you change the build scripts of the cpp-client to use that image
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on issue #9682: CI cpp-tests is broken now for the latest pulsar-build image
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #9682:
URL: https://github.com/apache/pulsar/issues/9682#issuecomment-783997291
I think @zymap is going to publish the old image soon.
BTW, I'm working on fix the image that contains changes of #9609 . The problem is, since it cannot be verified by CI currently, should we wait until the CI for `pulsar-build` image first?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap edited a comment on issue #9682: CI cpp-tests is broken now for the latest pulsar-build image
Posted by GitBox <gi...@apache.org>.
zymap edited a comment on issue #9682:
URL: https://github.com/apache/pulsar/issues/9682#issuecomment-784043856
I have pushed the old image. And will push the new image after @BewareMyPower is fixed the issue.
The old Dockerfile have some file can not download, I change some of it:
```
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
#
FROM ubuntu:16.04
# prepare the directory for pulsar related files
RUN mkdir /pulsar
ADD protobuf.patch /pulsar
RUN apt-get update && \
apt-get install -y tig g++ cmake libssl-dev libcurl4-openssl-dev \
liblog4cxx-dev libprotobuf-dev libboost-all-dev google-mock libgtest-dev \
libjsoncpp-dev libxml2-utils protobuf-compiler wget \
curl doxygen openjdk-8-jdk-headless clang-format-5.0 \
gnupg2 golang-1.13-go zip unzip libzstd-dev libsnappy-dev
# Compile and install gtest
RUN cd /usr/src/gtest && cmake . && make && cp libgtest.a /usr/lib
# Compile and install google-mock
RUN cd /usr/src/gmock && cmake . && make && cp libgmock.a /usr/lib
# Include gtest parallel to speed up unit tests
RUN git clone https://github.com/google/gtest-parallel.git
ENV JAVA_HOME=/usr/lib/jvm/java-1.8.0-openjdk-amd64
## Website build dependencies
# Install Ruby-2.4.1
RUN apt-get install -y
RUN gpg2 --keyserver hkp://keys.gnupg.net --recv-keys 409B6B1796C275462A1703113804BB82D39DC0E3 7D2BAF1CF37B13E2069D6956105BD0E739499BDB && \
(curl -sSL https://get.rvm.io | bash -s stable)
ENV PATH "$PATH:/usr/local/rvm/bin"
RUN rvm install 2.4.1
# Install nodejs and yarn
RUN curl -sL https://deb.nodesource.com/setup_10.x | bash -
RUN apt-get install -y nodejs
RUN curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add -
RUN echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list
RUN apt-get update && apt-get install yarn
# Install crowdin
RUN wget https://artifacts.crowdin.com/repo/deb/crowdin.deb -O crowdin.deb
RUN dpkg -i crowdin.deb
# Install PIP and PDoc
RUN wget https://bootstrap.pypa.io/2.7/get-pip.py && python get-pip.py
RUN pip install pdoc
# Install Protobuf doc generator (requires Go)
ENV GOPATH "$HOME/go"
ENV PATH "/usr/lib/go-1.13/bin:$GOPATH/bin:$PATH"
RUN go get -u github.com/pseudomuto/protoc-gen-doc/cmd/protoc-gen-doc
# Build the patched protoc
RUN git clone https://github.com/google/protobuf.git /pulsar/protobuf && \
cd /pulsar/protobuf && \
git checkout v2.4.1 && \
patch -p1 < /pulsar/protobuf.patch && \
autoreconf --install && \
./configure && \
make
# Installation
ARG MAVEN_VERSION=3.6.1
ARG MAVEN_FILENAME="apache-maven-${MAVEN_VERSION}-bin.tar.gz"
ARG MAVEN_HOME=/opt/maven
ARG MAVEN_URL="http://archive.apache.org/dist/maven/maven-3/${MAVEN_VERSION}/binaries/${MAVEN_FILENAME}"
ARG MAVEN_TMP="/tmp/${MAVEN_FILENAME}"
RUN wget --no-verbose -O ${MAVEN_TMP} ${MAVEN_URL}
# Cleanup
RUN tar xzf ${MAVEN_TMP} -C /opt/ \
&& ln -s /opt/apache-maven-${MAVEN_VERSION} ${MAVEN_HOME} \
&& ln -s ${MAVEN_HOME}/bin/mvn /usr/local/bin
RUN unset MAVEN_VERSION
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on issue #9682: CI cpp-tests is broken now for the latest pulsar-build image
Posted by GitBox <gi...@apache.org>.
zymap commented on issue #9682:
URL: https://github.com/apache/pulsar/issues/9682#issuecomment-784043856
I have pushed the old image. And will push the new image after @BewareMyPower is fixed the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on issue #9682: CI cpp-tests is broken now for the latest pulsar-build image
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #9682:
URL: https://github.com/apache/pulsar/issues/9682#issuecomment-783978302
I think one available solution is to update the image again to add boost python for python3. It could also remove python2 and use python3 for python tests. And I'm trying to do this work.
However, the image could only be tested in local environment. It seems that there's no way to verify if the new `pulsar-build` image works. It may need another empty PR to verify if CI would pass after the new `pulsar-build` image was uploaded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on issue #9682: CI cpp-tests is broken now for the latest pulsar-build image
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #9682:
URL: https://github.com/apache/pulsar/issues/9682#issuecomment-783998664
@eolivelli OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org