[jira] [Comment Edited] (CASSANDRA-17332) Add support for vnodes in jvm-dtest

["Alex Petrov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511210#comment-17511210 ] 

Alex Petrov edited comment on CASSANDRA-17332 at 3/23/22, 12:07 PM:
--------------------------------------------------------------------

bq. I feel like for testing if the setting isn't cluster-wide, it's a sharp edge waiting to cut someone. 

I don't see anything strange about it at all, considering how this setting works right now. It's just a matter of how the node advertises itself, calling for token metadata updates across the cluster. When token metadata is transactional, this will be not only a normal, but also preferred scenario, since you'll be able to transfer tokens or ranges across the cluster in an arbitrary manner, so I don't see why we should limit ourselves to a specific number of tokens per node that absolutely has to be uniform.


was (Author: ifesdjeen):
bq. I feel like for testing if the setting isn't cluster-wide, it's a sharp edge waiting to cut someone. 

I don't see anything strange about it at all, considering how this setting works right now. It's just a matter of how the node advertises itself, calling for token metadata updates across the cluster. When token metadata is transactional, this will be not only a normal, but also preferred scenario, since you'll be able to transfer tokens or ranges across the cluster in an arbitrary manner, so I don't see why we should limit ourselves to a specific number of tokens per node.

> Add support for vnodes in jvm-dtest
> -----------------------------------
>
>                 Key: CASSANDRA-17332
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17332
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Test/dtest/java
>            Reporter: David Capwell
>            Assignee: David Capwell
>            Priority: Normal
>              Labels: pull-request-available
>             Fix For: 4.x
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Right now python dtests need to keep running after being ported to jvm-dtests as vnode support is not present, to fully deprecate the python dtests, we need vnode support in jvm-dtest.
> Sadly, to add support we need to break binary compatibility, but can maintain source compatibility… so will need to bump every jar across every branch (mostly due to TokenSupplier)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org