You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Brown (Code Review)" <ge...@cloudera.org> on 2019/02/08 17:35:09 UTC
[Impala-ASF-CR] IMPALA-8175: improve tests minicluster obj
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12412
Change subject: IMPALA-8175: improve tests_minicluster_obj
......................................................................
IMPALA-8175: improve tests_minicluster_obj
Adjust minicluster impalad pgrep detection usage to be compatible with
CentOS 6 pgrep. Skip the test if not in a minicluster, because the test
will fail. Don't run the test in exhaustive: it's most important this
test run pre-merge, which is core.
I was able to use sh -c "pgrep ..." and impala-py.test to test this
locally on CentOS 6 and Ubuntu 16.
Change-Id: I558b3157bb16ef3d169c0d3e795e03700a17ffe4
---
M tests/comparison/cluster.py
M tests/infra/test_stress_infra.py
2 files changed, 13 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/12412/1
--
To view, visit http://gerrit.cloudera.org:8080/12412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I558b3157bb16ef3d169c0d3e795e03700a17ffe4
Gerrit-Change-Number: 12412
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@apache.org>
[Impala-ASF-CR] IMPALA-8175: improve tests minicluster obj
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12412 )
Change subject: IMPALA-8175: improve tests_minicluster_obj
......................................................................
IMPALA-8175: improve tests_minicluster_obj
Adjust minicluster impalad pgrep detection usage to be compatible with
CentOS 6 pgrep. Skip the test if not in a minicluster, because the test
will fail. Don't run the test in exhaustive: it's most important this
test run pre-merge, which is core.
I was able to use sh -c "pgrep ..." and impala-py.test to test this
locally on CentOS 6 and Ubuntu 16.
Change-Id: I558b3157bb16ef3d169c0d3e795e03700a17ffe4
Reviewed-on: http://gerrit.cloudera.org:8080/12412
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/comparison/cluster.py
M tests/infra/test_stress_infra.py
2 files changed, 13 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I558b3157bb16ef3d169c0d3e795e03700a17ffe4
Gerrit-Change-Number: 12412
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Brown <mi...@apache.org>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR] IMPALA-8175: improve tests minicluster obj
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12412 )
Change subject: IMPALA-8175: improve tests_minicluster_obj
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3742/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I558b3157bb16ef3d169c0d3e795e03700a17ffe4
Gerrit-Change-Number: 12412
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Brown <mi...@apache.org>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Feb 2019 21:39:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8175: improve tests minicluster obj
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12412 )
Change subject: IMPALA-8175: improve tests_minicluster_obj
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12412/2/tests/comparison/cluster.py
File tests/comparison/cluster.py:
http://gerrit.cloudera.org:8080/#/c/12412/2/tests/comparison/cluster.py@846
PS2, Line 846: def find_pid(self):
: # Need to filter results to avoid pgrep picking up its parent bash script.
: # Test with:
: # sh -c "pgrep -l -f 'impala.*21050' | grep [i]mpalad | grep -o '^[0-9]*' || true"
: pid = self.shell("pgrep -l -f 'impalad.*%s' | grep [i]mpalad | "
: "grep -o '^[0-9]*' || true" % self.hs2_port)
: if pid:
: return int(pid)
I'm fine with this, but this is
$fuser 21050/tcp
21050/tcp: 2820
or possibly
$pgrep impalad | head -n 1
2820
--
To view, visit http://gerrit.cloudera.org:8080/12412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I558b3157bb16ef3d169c0d3e795e03700a17ffe4
Gerrit-Change-Number: 12412
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Brown <mi...@apache.org>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Feb 2019 17:47:54 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8175: improve tests minicluster obj
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12412 )
Change subject: IMPALA-8175: improve tests_minicluster_obj
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I558b3157bb16ef3d169c0d3e795e03700a17ffe4
Gerrit-Change-Number: 12412
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Brown <mi...@apache.org>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Feb 2019 21:39:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8175: improve tests minicluster obj
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12412 )
Change subject: IMPALA-8175: improve tests_minicluster_obj
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2042/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I558b3157bb16ef3d169c0d3e795e03700a17ffe4
Gerrit-Change-Number: 12412
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@apache.org>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Feb 2019 18:19:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8175: improve tests minicluster obj
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12412 )
Change subject: IMPALA-8175: improve tests_minicluster_obj
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I558b3157bb16ef3d169c0d3e795e03700a17ffe4
Gerrit-Change-Number: 12412
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Brown <mi...@apache.org>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Sat, 09 Feb 2019 01:56:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8175: improve tests minicluster obj
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12412 )
Change subject: IMPALA-8175: improve tests_minicluster_obj
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2043/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I558b3157bb16ef3d169c0d3e795e03700a17ffe4
Gerrit-Change-Number: 12412
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Brown <mi...@apache.org>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Feb 2019 18:20:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8175: improve tests minicluster obj
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/12412 )
Change subject: IMPALA-8175: improve tests_minicluster_obj
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12412/1/tests/comparison/cluster.py
File tests/comparison/cluster.py:
http://gerrit.cloudera.org:8080/#/c/12412/1/tests/comparison/cluster.py@850
PS1, Line 850: [i]impalad
I'll fix this. I am not immediately sure how testing succeeded.
--
To view, visit http://gerrit.cloudera.org:8080/12412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I558b3157bb16ef3d169c0d3e795e03700a17ffe4
Gerrit-Change-Number: 12412
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@apache.org>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Feb 2019 17:37:05 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8175: improve tests minicluster obj
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/12412 )
Change subject: IMPALA-8175: improve tests_minicluster_obj
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12412/1/tests/comparison/cluster.py
File tests/comparison/cluster.py:
http://gerrit.cloudera.org:8080/#/c/12412/1/tests/comparison/cluster.py@850
PS1, Line 850: [i]mpalad
> I'll fix this. I am not immediately sure how testing succeeded.
Done
--
To view, visit http://gerrit.cloudera.org:8080/12412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I558b3157bb16ef3d169c0d3e795e03700a17ffe4
Gerrit-Change-Number: 12412
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Brown <mi...@apache.org>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Feb 2019 17:41:01 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8175: improve tests minicluster obj
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Hello Andrew Sherman, Philip Zeyliger, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12412
to look at the new patch set (#2).
Change subject: IMPALA-8175: improve tests_minicluster_obj
......................................................................
IMPALA-8175: improve tests_minicluster_obj
Adjust minicluster impalad pgrep detection usage to be compatible with
CentOS 6 pgrep. Skip the test if not in a minicluster, because the test
will fail. Don't run the test in exhaustive: it's most important this
test run pre-merge, which is core.
I was able to use sh -c "pgrep ..." and impala-py.test to test this
locally on CentOS 6 and Ubuntu 16.
Change-Id: I558b3157bb16ef3d169c0d3e795e03700a17ffe4
---
M tests/comparison/cluster.py
M tests/infra/test_stress_infra.py
2 files changed, 13 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/12412/2
--
To view, visit http://gerrit.cloudera.org:8080/12412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I558b3157bb16ef3d169c0d3e795e03700a17ffe4
Gerrit-Change-Number: 12412
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Brown <mi...@apache.org>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@apache.org>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>