You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/07/04 03:20:25 UTC

[GitHub] [submarine] KUAN-HSUN-LI commented on a change in pull request #638: SUBMARINE-894. Reduce the image size of submarine-operator

KUAN-HSUN-LI commented on a change in pull request #638:
URL: https://github.com/apache/submarine/pull/638#discussion_r663439030



##########
File path: submarine-cloud-v2/Makefile
##########
@@ -30,8 +30,9 @@ api:
 
 .PHONY: image
 image: charts
+	eval $(minikube docker-env)
 	GOOS=linux go build -o submarine-operator
-	docker build -t submarine-operator .
+	docker build -t submarine-operator -f dev.Dockerfile .

Review comment:
       why specify a non-existing file here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org