You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/08/12 00:43:40 UTC
Re: Review Request 18489: Changed string returns to const references.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18489/
-----------------------------------------------------------
(Updated Aug. 11, 2014, 3:43 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
rebased
Bugs: MESOS-1147
https://issues.apache.org/jira/browse/MESOS-1147
Repository: mesos-git
Description
-------
See summary
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp 3a10379f13bdf9ff9e6d424ed1877539c30f2731
3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp d99b75aeae10319b574c67beeb6023358cac7aec
Diff: https://reviews.apache.org/r/18489/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 18489: Changed Try::error and Result::error to return
const references.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18489/
-----------------------------------------------------------
(Updated Aug. 11, 2014, 4:10 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
updated summary/commit message
Summary (updated)
-----------------
Changed Try::error and Result::error to return const references.
Bugs: MESOS-1147
https://issues.apache.org/jira/browse/MESOS-1147
Repository: mesos-git
Description
-------
See summary
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp 3a10379f13bdf9ff9e6d424ed1877539c30f2731
3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp d99b75aeae10319b574c67beeb6023358cac7aec
Diff: https://reviews.apache.org/r/18489/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 18489: Changed Try::error and Result::error to return
const references.
Posted by Dominic Hamon <dh...@twopensource.com>.
> On Aug. 11, 2014, 3:57 p.m., Ben Mahler wrote:
> > Thanks Dominic, a few suggestions:
> >
> > (1) What about a clearer review subject (commit message): 'Changed Result::error() and Try::error() to return const references."
> >
> > (2) Since 'make check' can miss callers that take a const reference that will now go out of scope and become invalid, can you do a visual audit of all the callers before you commit this change?
> >
> > Will you be following through with Future::failure()? Same thing applies there.
1. done
2. done - everything is either copied into a string or appended to another string (thus copied to a string).
i didn't see a ticket for failure. i can add something.
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18489/#review50256
-----------------------------------------------------------
On Aug. 11, 2014, 4:10 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18489/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 4:10 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1147
> https://issues.apache.org/jira/browse/MESOS-1147
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp 3a10379f13bdf9ff9e6d424ed1877539c30f2731
> 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp d99b75aeae10319b574c67beeb6023358cac7aec
>
> Diff: https://reviews.apache.org/r/18489/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 18489: Changed string returns to const references.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18489/#review50256
-----------------------------------------------------------
Ship it!
Thanks Dominic, a few suggestions:
(1) What about a clearer review subject (commit message): 'Changed Result::error() and Try::error() to return const references."
(2) Since 'make check' can miss callers that take a const reference that will now go out of scope and become invalid, can you do a visual audit of all the callers before you commit this change?
Will you be following through with Future::failure()? Same thing applies there.
- Ben Mahler
On Aug. 11, 2014, 10:43 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18489/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 10:43 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1147
> https://issues.apache.org/jira/browse/MESOS-1147
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp 3a10379f13bdf9ff9e6d424ed1877539c30f2731
> 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp d99b75aeae10319b574c67beeb6023358cac7aec
>
> Diff: https://reviews.apache.org/r/18489/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>