You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/10/01 07:40:25 UTC

[GitHub] [hudi] wangxianghu commented on pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

wangxianghu commented on pull request #1827:
URL: https://github.com/apache/hudi/pull/1827#issuecomment-701951988


   > @wangxianghu @yanghua I have rebased this against master. Please take a look at my changes.
   > 
   > High level, we could re-use more code, but it needs an abstraction that can wrap `RDD` or `DataSet` or `D
   
   > @wangxianghu @yanghua I have rebased this against master. Please take a look at my changes.
   > 
   > High level, we could re-use more code, but it needs an abstraction that can wrap `RDD` or `DataSet` or `DataStream` adequately and support basic operations like `.map()`, `reduceByKey()` etc. We can do this in a second pass once we have a working Flink impl. For now this will do.
   > 
   > I am trying to get the tests to pass. if they do, we could go ahead and merge
   
   Thanks, @vinothchandar, this is really great work! 
   Yes, we can do more abstractions about basic `map`, `reduceByKey` methods in `HoodieEngineContext`, or some Util classes next.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org