You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2022/12/07 09:51:27 UTC
[GitHub] [zookeeper] eolivelli opened a new pull request, #1951: [ZOOKEEPER-4641] GH CI fails with 'error: implicit declaration of function ‘FIPS_mode’ [-Werror=implicit-function-declaration]'
eolivelli opened a new pull request, #1951:
URL: https://github.com/apache/zookeeper/pull/1951
Modifications:
- remove the block, as it is used only for debug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] asfgit closed pull request #1951: [ZOOKEEPER-4641] GH CI fails with 'error: implicit declaration of function ‘FIPS_mode’ [-Werror=implicit-function-declaration]'
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1951: [ZOOKEEPER-4641] GH CI fails with 'error: implicit declaration of function ‘FIPS_mode’ [-Werror=implicit-function-declaration]'
URL: https://github.com/apache/zookeeper/pull/1951
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli closed pull request #1951: [ZOOKEEPER-4641] GH CI fails with 'error: implicit declaration of function ‘FIPS_mode’ [-Werror=implicit-function-declaration]'
Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #1951: [ZOOKEEPER-4641] GH CI fails with 'error: implicit declaration of function ‘FIPS_mode’ [-Werror=implicit-function-declaration]'
URL: https://github.com/apache/zookeeper/pull/1951
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] symat commented on pull request #1951: [ZOOKEEPER-4641] GH CI fails with 'error: implicit declaration of function ‘FIPS_mode’ [-Werror=implicit-function-declaration]'
Posted by GitBox <gi...@apache.org>.
symat commented on PR #1951:
URL: https://github.com/apache/zookeeper/pull/1951#issuecomment-1350743946
I re-triggered the failing CI runs (there was also a failure in C-client tests, but I think I saw that particular error before and it is an unrelated flaky)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1951: [ZOOKEEPER-4641] GH CI fails with 'error: implicit declaration of function ‘FIPS_mode’ [-Werror=implicit-function-declaration]'
Posted by GitBox <gi...@apache.org>.
eolivelli commented on PR #1951:
URL: https://github.com/apache/zookeeper/pull/1951#issuecomment-1352946039
@symat I think that we should merge this an then follow up on the flaky test.
@ztzg maybe you could also help here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1951: [ZOOKEEPER-4641] GH CI fails with 'error: implicit declaration of function ‘FIPS_mode’ [-Werror=implicit-function-declaration]'
Posted by GitBox <gi...@apache.org>.
eolivelli commented on PR #1951:
URL: https://github.com/apache/zookeeper/pull/1951#issuecomment-1346294764
@cnauroth
I am sorry I think I have pushed this patch to master branch by mistake.
The patch had been approved, I think there is no need to git revert.
`wonder why it was compiling before and stopped now.`
This is because we use `-Werror` and as long as the C compiler is upgraded we find more warnings, that are considered errors, this is why sometimes builds start to fail without anyone doing anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] symat commented on pull request #1951: [ZOOKEEPER-4641] GH CI fails with 'error: implicit declaration of function ‘FIPS_mode’ [-Werror=implicit-function-declaration]'
Posted by GitBox <gi...@apache.org>.
symat commented on PR #1951:
URL: https://github.com/apache/zookeeper/pull/1951#issuecomment-1352962603
I agree, the patch is already helps - at least the C client can be compiled now :)
Merging it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1951: [ZOOKEEPER-4641] GH CI fails with 'error: implicit declaration of function ‘FIPS_mode’ [-Werror=implicit-function-declaration]'
Posted by GitBox <gi...@apache.org>.
eolivelli commented on PR #1951:
URL: https://github.com/apache/zookeeper/pull/1951#issuecomment-1346296670
@cnauroth actually I hadn't pushed the patch to this repository but to my fork master branch.
So the patch is still here open for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org