You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by ru jia <82...@163.com> on 2020/07/03 08:05:54 UTC
Review Request 72639: RANGER-2891: Add checkCanShowColumnsMetadata for
presto plugin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72639/
-----------------------------------------------------------
Review request for ranger.
Bugs: RANGER-2891
https://issues.apache.org/jira/browse/RANGER-2891
Repository: ranger
Description
-------
plugin-presto does not support 'checkCanShowColumnsMetadata' API now, it should be implemented.
Diffs
-----
plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java f4fc89d
ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java 4063870
Diff: https://reviews.apache.org/r/72639/diff/1/
Testing
-------
Compilation OK and already used in production environment
Thanks,
ru jia
Re: Review Request 72639: RANGER-2891: Add
checkCanShowColumnsMetadata for presto plugin
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72639/#review221116
-----------------------------------------------------------
plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java
Lines 645 (patched)
<https://reviews.apache.org/r/72639/#comment309907>
Make it to debug level, as this may generate log of log.
- Ramesh Mani
On July 3, 2020, 8:07 a.m., ru jia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72639/
> -----------------------------------------------------------
>
> (Updated July 3, 2020, 8:07 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2891
> https://issues.apache.org/jira/browse/RANGER-2891
>
>
> Repository: ranger
>
>
> Description
> -------
>
> plugin-presto does not support 'checkCanShowColumnsMetadata' API now, it should be implemented.
>
>
> Diffs
> -----
>
> plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java f4fc89d
> ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java 4063870
>
>
> Diff: https://reviews.apache.org/r/72639/diff/1/
>
>
> Testing
> -------
>
> Compilation OK and already used in production environment
>
>
> Thanks,
>
> ru jia
>
>
Re: Review Request 72639: RANGER-2891: Add
checkCanShowColumnsMetadata for presto plugin
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72639/#review221129
-----------------------------------------------------------
Ship it!
- Ramesh Mani
On July 6, 2020, 4:05 a.m., ru jia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72639/
> -----------------------------------------------------------
>
> (Updated July 6, 2020, 4:05 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2891
> https://issues.apache.org/jira/browse/RANGER-2891
>
>
> Repository: ranger
>
>
> Description
> -------
>
> plugin-presto does not support 'checkCanShowColumnsMetadata' API now, it should be implemented.
>
>
> Diffs
> -----
>
> plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java f4fc89d
> ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java 4063870
>
>
> Diff: https://reviews.apache.org/r/72639/diff/1/
>
>
> Testing
> -------
>
> Compilation OK and already used in production environment
>
>
> File Attachments
> ----------------
>
> 0002-Add-checkCanShowColumnsMetadata-for-presto-plugin.patch
> https://reviews.apache.org/media/uploaded/files/2020/07/06/ac0b2472-9940-4627-9288-88175bb28d3e__0002-Add-checkCanShowColumnsMetadata-for-presto-plugin.patch
>
>
> Thanks,
>
> ru jia
>
>
Re: Review Request 72639: RANGER-2891: Add
checkCanShowColumnsMetadata for presto plugin
Posted by ru jia <82...@163.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72639/
-----------------------------------------------------------
(Updated 七月 6, 2020, 4:05 a.m.)
Review request for ranger.
Changes
-------
Update log level
Bugs: RANGER-2891
https://issues.apache.org/jira/browse/RANGER-2891
Repository: ranger
Description
-------
plugin-presto does not support 'checkCanShowColumnsMetadata' API now, it should be implemented.
Diffs
-----
plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java f4fc89d
ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java 4063870
Diff: https://reviews.apache.org/r/72639/diff/1/
Testing
-------
Compilation OK and already used in production environment
File Attachments (updated)
----------------
0002-Add-checkCanShowColumnsMetadata-for-presto-plugin.patch
https://reviews.apache.org/media/uploaded/files/2020/07/06/ac0b2472-9940-4627-9288-88175bb28d3e__0002-Add-checkCanShowColumnsMetadata-for-presto-plugin.patch
Thanks,
ru jia
Re: Review Request 72639: RANGER-2891: Add
checkCanShowColumnsMetadata for presto plugin
Posted by ru jia <82...@163.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72639/
-----------------------------------------------------------
(Updated 七月 6, 2020, 3:47 a.m.)
Review request for ranger.
Changes
-------
update
Bugs: RANGER-2891
https://issues.apache.org/jira/browse/RANGER-2891
Repository: ranger
Description
-------
plugin-presto does not support 'checkCanShowColumnsMetadata' API now, it should be implemented.
Diffs
-----
plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java f4fc89d
ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java 4063870
Diff: https://reviews.apache.org/r/72639/diff/1/
Testing
-------
Compilation OK and already used in production environment
File Attachments (updated)
----------------
0001-Add-checkCanShowColumnsMetadata-for-presto-plugin.patch
https://reviews.apache.org/media/uploaded/files/2020/07/06/d363d557-3c9c-47f5-a01d-3e44e9b93eeb__0001-Add-checkCanShowColumnsMetadata-for-presto-plugin.patch
0002-Add-checkCanShowColumnsMetadata-for-presto-plugin.patch
https://reviews.apache.org/media/uploaded/files/2020/07/06/fadeddae-2c58-473a-9753-358bfc39632e__0002-Add-checkCanShowColumnsMetadata-for-presto-plugin.patch
Thanks,
ru jia
Re: Review Request 72639: RANGER-2891: Add
checkCanShowColumnsMetadata for presto plugin
Posted by ru jia <82...@163.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72639/
-----------------------------------------------------------
(Updated 七月 6, 2020, 2:43 a.m.)
Review request for ranger.
Bugs: RANGER-2891
https://issues.apache.org/jira/browse/RANGER-2891
Repository: ranger
Description
-------
plugin-presto does not support 'checkCanShowColumnsMetadata' API now, it should be implemented.
Diffs
-----
plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java f4fc89d
ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java 4063870
Diff: https://reviews.apache.org/r/72639/diff/1/
Testing
-------
Compilation OK and already used in production environment
File Attachments (updated)
----------------
0001-Add-checkCanShowColumnsMetadata-for-presto-plugin.patch
https://reviews.apache.org/media/uploaded/files/2020/07/06/d363d557-3c9c-47f5-a01d-3e44e9b93eeb__0001-Add-checkCanShowColumnsMetadata-for-presto-plugin.patch
Thanks,
ru jia
Re: Review Request 72639: RANGER-2891: Add
checkCanShowColumnsMetadata for presto plugin
Posted by ru jia <82...@163.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72639/
-----------------------------------------------------------
(Updated 七月 3, 2020, 8:07 a.m.)
Review request for ranger.
Bugs: RANGER-2891
https://issues.apache.org/jira/browse/RANGER-2891
Repository: ranger
Description
-------
plugin-presto does not support 'checkCanShowColumnsMetadata' API now, it should be implemented.
Diffs
-----
plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java f4fc89d
ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java 4063870
Diff: https://reviews.apache.org/r/72639/diff/1/
Testing
-------
Compilation OK and already used in production environment
Thanks,
ru jia