You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2019/04/30 16:30:45 UTC

svn commit: r1858447 - in /ofbiz/ofbiz-framework/branches/release17.12: ./ themes/common/webapp/common/js/jquery/plugins/jsTree/themes/apple/ themes/common/webapp/common/js/jquery/plugins/jsTree/themes/classic/ themes/common/webapp/common/js/jquery/plu...

Author: jleroux
Date: Tue Apr 30 16:30:44 2019
New Revision: 1858447

URL: http://svn.apache.org/viewvc?rev=1858447&view=rev
Log:
"Applied fix from trunk for revision: 1858444  " 
------------------------------------------------------------------------
r1858444 | jleroux | 2019-04-30 18:23:56 +0200 (mar. 30 avr. 2019) | 34 lignes

Fixed: Unknown request [images]; this request does not exist or cannot be 
called directly.
(OFBIZ-10895)

This error happens in many occasions:
Inside another request (eg LookupProduct)
Of after a request (eg login)

It shows only in log and have no effect on UI. Notably the new feature normally 
showing an error message in trunk (OFBIZ-10753) does not shows

It happens in all supported releases. IIRW it always happened, only URLs like 
https://demo-trunk.ofbiz.apache.org/images/defaultImage.jpg work. 
But here it's different because we don't need to call 
https://demo-trunk.ofbiz.apache.org/images by hand to get the issue in log.

So it's not very bad since it's has no side effects, just weird and annoying. 
Because it might hide something undetected yet...

This issue does not appear in R15, a good place to test is for instance 
ordermgr/control/request. 
There cal.gif is called by /images/cal.gif and it works (the images appears) 
but in more recent versions the call is also done to 
/ordermgr/control/images/cal.gif where it fails. 
This 1st appears in ControlFilter in the stack trace.

As said Deepak Dixit:
I think we need to fix the image url in css file, it should start with /images, 
else browser append this in request info. There is nothing related to java or 
tomcat code. 

This is a 1st commit for the errors I already reported and I'm sure about
Common-theme does not exist here so some have been handled by hand

Thanks: Deepak 
------------------------------------------------------------------------

Modified:
    ofbiz/ofbiz-framework/branches/release17.12/   (props changed)
    ofbiz/ofbiz-framework/branches/release17.12/themes/common/webapp/common/js/jquery/plugins/jsTree/themes/apple/style.css
    ofbiz/ofbiz-framework/branches/release17.12/themes/common/webapp/common/js/jquery/plugins/jsTree/themes/classic/style.css
    ofbiz/ofbiz-framework/branches/release17.12/themes/common/webapp/common/js/jquery/plugins/jsTree/themes/default-rtl/style.css
    ofbiz/ofbiz-framework/branches/release17.12/themes/common/webapp/common/js/jquery/plugins/jsTree/themes/default/style.css
    ofbiz/ofbiz-framework/branches/release17.12/themes/flatgrey/webapp/flatgrey/javascript.css
    ofbiz/ofbiz-framework/branches/release17.12/themes/flatgrey/webapp/flatgrey/style.css
    ofbiz/ofbiz-framework/branches/release17.12/themes/rainbowstone/webapp/rainbowstone/javascript.css
    ofbiz/ofbiz-framework/branches/release17.12/themes/rainbowstone/webapp/rainbowstone/style.css

Propchange: ofbiz/ofbiz-framework/branches/release17.12/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Apr 30 16:30:44 2019
@@ -10,4 +10,4 @@
 /ofbiz/branches/json-integration-refactoring:1634077-1635900
 /ofbiz/branches/multitenant20100310:921280-927264
 /ofbiz/branches/release13.07:1547657
-/ofbiz/ofbiz-framework/trunk:1819499,1819598,1819800,1819805,1819811,1819947,1820038,1820262,1820374-1820375,1820441,1820457,1820644,1820658,1820790,1820823,1820949,1820966,1821012,1821036,1821112,1821115,1821144,1821186,1821219,1821226,1821230,1821386,1821613,1821628,1821965,1822125,1822310,1822377,1822383,1822393,1823467,1823562,1823876,1824314,1824316,1824732,1824803,1824847,1824855,1825192,1825211,1825216,1825233,1825450,1826374,1826502,1826592,1826671,1826674,1826780,1826805,1826938,1826997,1827439,1828255,1828316,1828346,1828424,1828512,1828514,1829690,1830936,1831074,1831078,1831234,1831608,1831831,1832577,1832662,1832756,1832800,1832944,1833173,1833211,1834181,1834191,1834736,1835235,1835887,1835891,1835953,1835964,1836144,1836871,1837857,1838032,1838256,1838381,1840189,1840199,1840828,1841657,1841662,1842372,1842921,1843225,1843893,1844943,1845418,1845420,1845466,1845544,1845552,1845558,1845933,1845995,1846097,1846107,1846214,1846594,1846632,1847398,1847478,1847670,1847715,
 1847890,1848263,1848336,1848386,1848398,1848441,1848444,1848447,1848449,1848467,1848469,1848745,1848849-1848850,1849021,1849165,1849191,1849193,1849275,1849467,1849528,1849540,1849567,1849693,1850015,1850023,1850530,1850647,1850685,1850694,1850914,1850918,1850948,1850953,1851006,1851068,1851074,1851130,1851158,1851163,1851200,1851247,1851319,1851350,1851805,1851998,1852587,1852818,1853070,1853109,1853691,1853745,1853750,1854306,1854457,1855078,1855287,1855371,1855403,1855488,1855492,1855497,1855501,1855898,1856405,1856455,1856459-1856460,1856484,1856598,1856617,1856667,1857099,1857173,1857180,1857213,1857392,1857617,1857692,1857813,1858035,1858250,1858256,1858275,1858319,1858432
+/ofbiz/ofbiz-framework/trunk:1819499,1819598,1819800,1819805,1819811,1819947,1820038,1820262,1820374-1820375,1820441,1820457,1820644,1820658,1820790,1820823,1820949,1820966,1821012,1821036,1821112,1821115,1821144,1821186,1821219,1821226,1821230,1821386,1821613,1821628,1821965,1822125,1822310,1822377,1822383,1822393,1823467,1823562,1823876,1824314,1824316,1824732,1824803,1824847,1824855,1825192,1825211,1825216,1825233,1825450,1826374,1826502,1826592,1826671,1826674,1826780,1826805,1826938,1826997,1827439,1828255,1828316,1828346,1828424,1828512,1828514,1829690,1830936,1831074,1831078,1831234,1831608,1831831,1832577,1832662,1832756,1832800,1832944,1833173,1833211,1834181,1834191,1834736,1835235,1835887,1835891,1835953,1835964,1836144,1836871,1837857,1838032,1838256,1838381,1840189,1840199,1840828,1841657,1841662,1842372,1842921,1843225,1843893,1844943,1845418,1845420,1845466,1845544,1845552,1845558,1845933,1845995,1846097,1846107,1846214,1846594,1846632,1847398,1847478,1847670,1847715,
 1847890,1848263,1848336,1848386,1848398,1848441,1848444,1848447,1848449,1848467,1848469,1848745,1848849-1848850,1849021,1849165,1849191,1849193,1849275,1849467,1849528,1849540,1849567,1849693,1850015,1850023,1850530,1850647,1850685,1850694,1850914,1850918,1850948,1850953,1851006,1851068,1851074,1851130,1851158,1851163,1851200,1851247,1851319,1851350,1851805,1851998,1852587,1852818,1853070,1853109,1853691,1853745,1853750,1854306,1854457,1855078,1855287,1855371,1855403,1855488,1855492,1855497,1855501,1855898,1856405,1856455,1856459-1856460,1856484,1856598,1856617,1856667,1857099,1857173,1857180,1857213,1857392,1857617,1857692,1857813,1858035,1858250,1858256,1858275,1858319,1858432,1858444

Modified: ofbiz/ofbiz-framework/branches/release17.12/themes/common/webapp/common/js/jquery/plugins/jsTree/themes/apple/style.css
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/branches/release17.12/themes/common/webapp/common/js/jquery/plugins/jsTree/themes/apple/style.css?rev=1858447&r1=1858446&r2=1858447&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/branches/release17.12/themes/common/webapp/common/js/jquery/plugins/jsTree/themes/apple/style.css (original)
+++ ofbiz/ofbiz-framework/branches/release17.12/themes/common/webapp/common/js/jquery/plugins/jsTree/themes/apple/style.css Tue Apr 30 16:30:44 2019
@@ -6,7 +6,7 @@
 
 .jstree-apple > ul { background:url("bg.jpg") left top repeat; }
 .jstree-apple li, 
-.jstree-apple ins { background-image:url("d.png"); background-repeat:no-repeat; background-color:transparent; }
+.jstree-apple ins { background-image:url("images/d.png"); background-repeat:no-repeat; background-color:transparent; }
 .jstree-apple li { background-position:-90px 0; background-repeat:repeat-y;  }
 .jstree-apple li.jstree-last { background:transparent; }
 .jstree-apple .jstree-open > ins { background-position:-72px 0; }

Modified: ofbiz/ofbiz-framework/branches/release17.12/themes/common/webapp/common/js/jquery/plugins/jsTree/themes/classic/style.css
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/branches/release17.12/themes/common/webapp/common/js/jquery/plugins/jsTree/themes/classic/style.css?rev=1858447&r1=1858446&r2=1858447&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/branches/release17.12/themes/common/webapp/common/js/jquery/plugins/jsTree/themes/classic/style.css (original)
+++ ofbiz/ofbiz-framework/branches/release17.12/themes/common/webapp/common/js/jquery/plugins/jsTree/themes/classic/style.css Tue Apr 30 16:30:44 2019
@@ -5,7 +5,7 @@
  */
 
 .jstree-classic li, 
-.jstree-classic ins { background-image:url("d.png"); background-repeat:no-repeat; background-color:transparent; }
+.jstree-classic ins { background-image:url("images/d.png"); background-repeat:no-repeat; background-color:transparent; }
 .jstree-classic li { background-position:-90px 0; background-repeat:repeat-y;  }
 .jstree-classic li.jstree-last { background:transparent; }
 .jstree-classic .jstree-open > ins { background-position:-72px 0; }

Modified: ofbiz/ofbiz-framework/branches/release17.12/themes/common/webapp/common/js/jquery/plugins/jsTree/themes/default-rtl/style.css
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/branches/release17.12/themes/common/webapp/common/js/jquery/plugins/jsTree/themes/default-rtl/style.css?rev=1858447&r1=1858446&r2=1858447&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/branches/release17.12/themes/common/webapp/common/js/jquery/plugins/jsTree/themes/default-rtl/style.css (original)
+++ ofbiz/ofbiz-framework/branches/release17.12/themes/common/webapp/common/js/jquery/plugins/jsTree/themes/default-rtl/style.css Tue Apr 30 16:30:44 2019
@@ -5,7 +5,7 @@
  */
 
 .jstree-default-rtl li, 
-.jstree-default-rtl ins { background-image:url("d.png"); background-repeat:no-repeat; background-color:transparent; }
+.jstree-default-rtl ins { background-image:url("images/d.png"); background-repeat:no-repeat; background-color:transparent; }
 .jstree-default-rtl li { background-position:-90px 0; background-repeat:repeat-y; }
 .jstree-default-rtl li.jstree-last { background:transparent; }
 .jstree-default-rtl .jstree-open > ins { background-position:-72px 0; }

Modified: ofbiz/ofbiz-framework/branches/release17.12/themes/common/webapp/common/js/jquery/plugins/jsTree/themes/default/style.css
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/branches/release17.12/themes/common/webapp/common/js/jquery/plugins/jsTree/themes/default/style.css?rev=1858447&r1=1858446&r2=1858447&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/branches/release17.12/themes/common/webapp/common/js/jquery/plugins/jsTree/themes/default/style.css (original)
+++ ofbiz/ofbiz-framework/branches/release17.12/themes/common/webapp/common/js/jquery/plugins/jsTree/themes/default/style.css Tue Apr 30 16:30:44 2019
@@ -5,7 +5,7 @@
  */
 
 .jstree-default li, 
-.jstree-default ins { background-image:url("d.png"); background-repeat:no-repeat; background-color:transparent; }
+.jstree-default ins { background-image:url("images/d.png"); background-repeat:no-repeat; background-color:transparent; }
 .jstree-default li { background-position:-90px 0; background-repeat:repeat-y; }
 .jstree-default li.jstree-last { background:transparent; }
 .jstree-default .jstree-open > ins { background-position:-72px 0; }

Modified: ofbiz/ofbiz-framework/branches/release17.12/themes/flatgrey/webapp/flatgrey/javascript.css
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/branches/release17.12/themes/flatgrey/webapp/flatgrey/javascript.css?rev=1858447&r1=1858446&r2=1858447&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/branches/release17.12/themes/flatgrey/webapp/flatgrey/javascript.css (original)
+++ ofbiz/ofbiz-framework/branches/release17.12/themes/flatgrey/webapp/flatgrey/javascript.css Tue Apr 30 16:30:44 2019
@@ -1887,7 +1887,7 @@ body .ui-tooltip {
 
 /* Calendar Button and Image */
 .view-calendar button {
-    background: url(images/cal.gif) no-repeat !important;
+    background: url(/images/cal.gif) no-repeat !important;
     display: inline-block;
     border: none;
     vertical-align: middle;

Modified: ofbiz/ofbiz-framework/branches/release17.12/themes/flatgrey/webapp/flatgrey/style.css
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/branches/release17.12/themes/flatgrey/webapp/flatgrey/style.css?rev=1858447&r1=1858446&r2=1858447&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/branches/release17.12/themes/flatgrey/webapp/flatgrey/style.css (original)
+++ ofbiz/ofbiz-framework/branches/release17.12/themes/flatgrey/webapp/flatgrey/style.css Tue Apr 30 16:30:44 2019
@@ -100,7 +100,7 @@ body, textarea, input, select {
 }
 
 html {
-    background-image: url(images/tile.gif);
+    background-image: url(/images/tile.gif);
 }
 
 body {

Modified: ofbiz/ofbiz-framework/branches/release17.12/themes/rainbowstone/webapp/rainbowstone/javascript.css
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/branches/release17.12/themes/rainbowstone/webapp/rainbowstone/javascript.css?rev=1858447&r1=1858446&r2=1858447&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/branches/release17.12/themes/rainbowstone/webapp/rainbowstone/javascript.css (original)
+++ ofbiz/ofbiz-framework/branches/release17.12/themes/rainbowstone/webapp/rainbowstone/javascript.css Tue Apr 30 16:30:44 2019
@@ -1888,7 +1888,7 @@ body .ui-tooltip {
 
 /* Calendar Button and Image */
 .view-calendar button {
-    background: url(images/cal.gif) no-repeat !important;
+    background: url(/images/cal.gif) no-repeat !important;
     display: inline-block;
     border: none;
     vertical-align: middle;

Modified: ofbiz/ofbiz-framework/branches/release17.12/themes/rainbowstone/webapp/rainbowstone/style.css
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/branches/release17.12/themes/rainbowstone/webapp/rainbowstone/style.css?rev=1858447&r1=1858446&r2=1858447&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/branches/release17.12/themes/rainbowstone/webapp/rainbowstone/style.css (original)
+++ ofbiz/ofbiz-framework/branches/release17.12/themes/rainbowstone/webapp/rainbowstone/style.css Tue Apr 30 16:30:44 2019
@@ -101,7 +101,7 @@ body, textarea, input, select {
 
 /*
 html {
-background-image: url(images/tile.gif);
+background-image: url(/images/tile.gif);
 }
 */