You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2008/08/15 02:07:44 UTC

[jira] Created: (HADOOP-3957) Fix javac warnings in DistCp and the corresponding tests

Fix javac warnings in DistCp and the corresponding tests
--------------------------------------------------------

                 Key: HADOOP-3957
                 URL: https://issues.apache.org/jira/browse/HADOOP-3957
             Project: Hadoop Core
          Issue Type: Bug
          Components: tools/distcp
            Reporter: Tsz Wo (Nicholas), SZE
            Priority: Minor


There are a few javac warning in DistCp and TestCopyFiles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (HADOOP-3957) Fix javac warnings in DistCp and the corresponding tests

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622786#action_12622786 ] 

szetszwo edited comment on HADOOP-3957 at 8/15/08 9:48 AM:
-------------------------------------------------------------------------

It passed all tests locally.  The following is the "ant test-patch" results.  The javadoc warning is due to HADOOP-3949.
{noformat}
     [exec] -1 overall.  

     [exec]     +1 @author.  The patch does not contain any @author tags.

     [exec]     +1 tests included.  The patch appears to include 8 new or modified tests.

     [exec]     -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
{noformat}

      was (Author: szetszwo):
    It passed all tests locally.  The following is the "ant test-patch" results.  The javadoc warning is due to HADOOP3949.
{noformat}
     [exec] -1 overall.  

     [exec]     +1 @author.  The patch does not contain any @author tags.

     [exec]     +1 tests included.  The patch appears to include 8 new or modified tests.

     [exec]     -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
{noformat}
  
> Fix javac warnings in DistCp and the corresponding tests
> --------------------------------------------------------
>
>                 Key: HADOOP-3957
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3957
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: tools/distcp
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: 3957_20080814.patch
>
>
> There are a few javac warning in DistCp and TestCopyFiles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3957) Fix javac warnings in DistCp and the corresponding tests

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623458#action_12623458 ] 

Chris Douglas commented on HADOOP-3957:
---------------------------------------

+1 Looks good

> Fix javac warnings in DistCp and the corresponding tests
> --------------------------------------------------------
>
>                 Key: HADOOP-3957
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3957
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: tools/distcp
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: 3957_20080814.patch
>
>
> There are a few javac warning in DistCp and TestCopyFiles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3957) Fix javac warnings in DistCp and the corresponding tests

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-3957:
----------------------------------

    Hadoop Flags: [Reviewed]

> Fix javac warnings in DistCp and the corresponding tests
> --------------------------------------------------------
>
>                 Key: HADOOP-3957
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3957
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: tools/distcp
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: 3957_20080814.patch
>
>
> There are a few javac warning in DistCp and TestCopyFiles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3957) Fix javac warnings in DistCp and the corresponding tests

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-3957:
-------------------------------------------

    Assignee: Tsz Wo (Nicholas), SZE
      Status: Patch Available  (was: Open)

It passed all tests locally.  The following is the "ant test-patch" results.  The javadoc warning is due to HADOOP3949.
{noformat}
     [exec] -1 overall.  

     [exec]     +1 @author.  The patch does not contain any @author tags.

     [exec]     +1 tests included.  The patch appears to include 8 new or modified tests.

     [exec]     -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
{noformat}

> Fix javac warnings in DistCp and the corresponding tests
> --------------------------------------------------------
>
>                 Key: HADOOP-3957
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3957
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: tools/distcp
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: 3957_20080814.patch
>
>
> There are a few javac warning in DistCp and TestCopyFiles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3957) Fix javac warnings in DistCp and the corresponding tests

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-3957:
-------------------------------------------

    Attachment: 3957_20080814.patch

3957_20080814.patch: fixed unchecked warnings.  Removed some not-so-use methods and the use of deprecated API.

> Fix javac warnings in DistCp and the corresponding tests
> --------------------------------------------------------
>
>                 Key: HADOOP-3957
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3957
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: tools/distcp
>            Reporter: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: 3957_20080814.patch
>
>
> There are a few javac warning in DistCp and TestCopyFiles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3957) Fix javac warnings in DistCp and the corresponding tests

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622919#action_12622919 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-3957:
------------------------------------------------

New "ant test-patch" result after "svn update"
{noformat}
     [exec] +1 overall.  

     [exec]     +1 @author.  The patch does not contain any @author tags.

     [exec]     +1 tests included.  The patch appears to include 8 new or modified tests.

     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.

     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
{noformat}

> Fix javac warnings in DistCp and the corresponding tests
> --------------------------------------------------------
>
>                 Key: HADOOP-3957
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3957
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: tools/distcp
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: 3957_20080814.patch
>
>
> There are a few javac warning in DistCp and TestCopyFiles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (HADOOP-3957) Fix javac warnings in DistCp and the corresponding tests

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622759#action_12622759 ] 

szetszwo edited comment on HADOOP-3957 at 8/14/08 5:33 PM:
-------------------------------------------------------------------------

3957_20080814.patch: fixed unchecked warnings.  Removed some not-so-useful methods and the use of deprecated API.

      was (Author: szetszwo):
    3957_20080814.patch: fixed unchecked warnings.  Removed some not-so-use methods and the use of deprecated API.
  
> Fix javac warnings in DistCp and the corresponding tests
> --------------------------------------------------------
>
>                 Key: HADOOP-3957
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3957
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: tools/distcp
>            Reporter: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: 3957_20080814.patch
>
>
> There are a few javac warning in DistCp and TestCopyFiles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3957) Fix javac warnings in DistCp and the corresponding tests

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-3957:
----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.19.0
           Status: Resolved  (was: Patch Available)

I just committed this. Thanks, Nicholas

> Fix javac warnings in DistCp and the corresponding tests
> --------------------------------------------------------
>
>                 Key: HADOOP-3957
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3957
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: tools/distcp
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>             Fix For: 0.19.0
>
>         Attachments: 3957_20080814.patch
>
>
> There are a few javac warning in DistCp and TestCopyFiles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3957) Fix javac warnings in DistCp and the corresponding tests

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624711#action_12624711 ] 

Hudson commented on HADOOP-3957:
--------------------------------

Integrated in Hadoop-trunk #581 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/581/])

> Fix javac warnings in DistCp and the corresponding tests
> --------------------------------------------------------
>
>                 Key: HADOOP-3957
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3957
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: tools/distcp
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>             Fix For: 0.19.0
>
>         Attachments: 3957_20080814.patch
>
>
> There are a few javac warning in DistCp and TestCopyFiles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.