You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/30 13:43:41 UTC

[GitHub] [arrow] pitrou commented on pull request #10968: ARROW-13680: [C++] Create an asynchronous nursery to simplify capture logic

pitrou commented on pull request #10968:
URL: https://github.com/apache/arrow/pull/10968#issuecomment-908354676


   I'm trying to understand the ergonomics of this API.
   If I understand correctly, nothing here actually keeps the tasks alive. What this relies upon is that the user stored the `shared_ptr` or `unique_ptr` returned by `Nursery::MakeXXXCloseable` somewhere so that lifetimes are handled correctly?
   Is there a risk that these pointers may be kept alive _too long_ (and delay the `DoClose` calls accordingly)? What is the recommended strategy for using this facility?
   
   Did you try to use this in the codebase to check that it actually reduces the burden of managing the sequencing of destructor calls?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org