You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/05/06 13:59:11 UTC

Review Request 33888: "Loading latest" log entry should include info about stack and version

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33888/
-----------------------------------------------------------

Review request for Ambari and Andrew Onischuk.


Bugs: AMBARI-10956
    https://issues.apache.org/jira/browse/AMBARI-10956


Repository: ambari


Description
-------

When ambari starts and loads/reads the stack defs, it writes to ambari-server.log if it is loading a latest url.
This log entry should include info about the stack (such as HDP) and version (such as 2.2) so it's easier to know what stack has the latest element that is being read.
29 Apr 2015 17:00:56,004 INFO [Stack Version Loading Thread] LatestRepoCallable:74 - Loading latest URL info from http://s3.amazonaws.com/dev.hortonworks.com/HDP/hdp_urlinfo.json


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java f4578a6 

Diff: https://reviews.apache.org/r/33888/diff/


Testing
-------

in progress


Thanks,

Dmitro Lisnichenko


Re: Review Request 33888: "Loading latest" log entry should include info about stack and version

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33888/
-----------------------------------------------------------

(Updated May 6, 2015, 12:57 p.m.)


Review request for Ambari and Andrew Onischuk.


Bugs: AMBARI-10956
    https://issues.apache.org/jira/browse/AMBARI-10956


Repository: ambari


Description
-------

When ambari starts and loads/reads the stack defs, it writes to ambari-server.log if it is loading a latest url.
This log entry should include info about the stack (such as HDP) and version (such as 2.2) so it's easier to know what stack has the latest element that is being read.
29 Apr 2015 17:00:56,004 INFO [Stack Version Loading Thread] LatestRepoCallable:74 - Loading latest URL info from http://s3.amazonaws.com/dev.hortonworks.com/HDP/hdp_urlinfo.json


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java f4578a6 

Diff: https://reviews.apache.org/r/33888/diff/


Testing (updated)
-------

Tests are failing on trunk as well

Tests in error: 
  test220Cardinality(org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest): Guice provision errors:(..)
  test220AutoDeploy(org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest): Guice provision errors:(..)
  test220Dependencies(org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest): Guice provision errors:(..)

Tests run: 2951, Failures: 0, Errors: 3, Skipped: 17

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Views ...................................... SUCCESS [3.248s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.801s]
[INFO] Ambari Server ..................................... FAILURE [49:56.827s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------


Thanks,

Dmitro Lisnichenko


Re: Review Request 33888: "Loading latest" log entry should include info about stack and version

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33888/#review82667
-----------------------------------------------------------

Ship it!


Ship It!

- Andrew Onischuk


On May 6, 2015, 11:59 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33888/
> -----------------------------------------------------------
> 
> (Updated May 6, 2015, 11:59 a.m.)
> 
> 
> Review request for Ambari and Andrew Onischuk.
> 
> 
> Bugs: AMBARI-10956
>     https://issues.apache.org/jira/browse/AMBARI-10956
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When ambari starts and loads/reads the stack defs, it writes to ambari-server.log if it is loading a latest url.
> This log entry should include info about the stack (such as HDP) and version (such as 2.2) so it's easier to know what stack has the latest element that is being read.
> 29 Apr 2015 17:00:56,004 INFO [Stack Version Loading Thread] LatestRepoCallable:74 - Loading latest URL info from http://s3.amazonaws.com/dev.hortonworks.com/HDP/hdp_urlinfo.json
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java f4578a6 
> 
> Diff: https://reviews.apache.org/r/33888/diff/
> 
> 
> Testing
> -------
> 
> in progress
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>