You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/08/09 14:42:36 UTC

[GitHub] [kafka] dajac commented on a change in pull request #11173: MINOR: Support max timestamp in GetOffsetShell

dajac commented on a change in pull request #11173:
URL: https://github.com/apache/kafka/pull/11173#discussion_r685255978



##########
File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala
##########
@@ -124,6 +125,7 @@ object GetOffsetShell {
     config.setProperty(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG, brokerList)
     config.setProperty(ConsumerConfig.CLIENT_ID_CONFIG, clientId)
     val consumer = new KafkaConsumer(config, new ByteArrayDeserializer, new ByteArrayDeserializer)
+    val client = Admin.create(config)

Review comment:
       I wonder if we could get rid of the `KafkaConsumer` now that the `Admin` client is used. It seems that it is used only to get the topics so that seems doable. What do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org