You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "DaanHoogland (via GitHub)" <gi...@apache.org> on 2026/08/26 12:48:09 UTC
[PR] new tenant instead of add account [cloudstack]
DaanHoogland opened a new pull request, #13981:
URL: https://github.com/apache/cloudstack/pull/13981
### Description
This PR...
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
Fixes: #13975
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] Build/CI
- [ ] Test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] new tenant instead of add account [cloudstack]
Posted by "ingox (via GitHub)" <gi...@apache.org>.
ingox commented on PR #13981:
URL: https://github.com/apache/cloudstack/pull/13981#issuecomment-5435560321
@DaanHoogland a few thoughts and observations:
- the add user button does not have any text in it
- now we have "NEW" Tenant Account and "ADD" LDAP Account - that should be named the same
- I'd prefer to remove the user creation from the account creation page. If that is not possible because the first user has to be created we may split that into two areas where the first one does focus on the account and the second one will cover the creation of the FIRST user in the account
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] new tenant instead of add account [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13981:
URL: https://github.com/apache/cloudstack/pull/13981#issuecomment-5595801081
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] new tenant instead of add account [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #13981:
URL: https://github.com/apache/cloudstack/pull/13981#issuecomment-5814576871
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13981) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=13981&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=13981&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=13981&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=13981&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=13981&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13981)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] new tenant instead of add account [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13981:
URL: https://github.com/apache/cloudstack/pull/13981#issuecomment-5425561750
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] new tenant instead of add account [cloudstack]
Posted by "davift (via GitHub)" <gi...@apache.org>.
davift commented on PR #13981:
URL: https://github.com/apache/cloudstack/pull/13981#issuecomment-5438969456
> @daviftorres I agree with your recommendations in the scope of a corporate organization.
>
> But think of a public cloud where each account could represent a single user. AWS also names it accounts. So maybe renaming is not needed. Just decouple accounts from users and don't have them in the same dialog.
I see your point and makes sense. But I guess there is no size fits all for this case. And the word "account" is misleading. I am fine with what ever @DaanHoogland decide, but I still think we should diverge the attention of the administrator to the user creation page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] new tenant instead of add account [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13981:
URL: https://github.com/apache/cloudstack/pull/13981#issuecomment-5813020163
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] new tenant instead of add account [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13981:
URL: https://github.com/apache/cloudstack/pull/13981#issuecomment-5426333117
<!-- coverage-grade-bot -->
## 🔴 Test Coverage Grade: `D` — Marginal
| Metric | Value |
|--------|-------|
| Line coverage | **24.61%** |
| Branch coverage | **18.82%** |
### Grade Scale
| Grade | Line Coverage | Meaning |
|-------|--------------|---------|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
> Branch coverage is shown as a secondary signal. Grade is determined by **line coverage**.
> [View full Actions run](https://github.com/apache/cloudstack/actions/runs/32970541253)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] new tenant instead of add account [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #13981:
URL: https://github.com/apache/cloudstack/pull/13981#issuecomment-5425636807
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/13981?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 3.41%. Comparing base ([`5e5ae0c`](https://app.codecov.io/gh/apache/cloudstack/commit/5e5ae0c51cd01387ae50e74f430c14b241edf636?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1b04b97`](https://app.codecov.io/gh/apache/cloudstack/commit/1b04b97a95bf1a9a724d177bdb061e0ed0ce37b9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on main.
> :exclamation: There is a different number of reports uploaded between BASE (5e5ae0c) and HEAD (1b04b97). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (5e5ae0c) | HEAD (1b04b97) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #13981 +/- ##
=============================================
- Coverage 19.72% 3.41% -16.32%
=============================================
Files 6371 487 -5884
Lines 575738 41865 -533873
Branches 70471 7912 -62559
=============================================
- Hits 113582 1429 -112153
+ Misses 449810 40236 -409574
+ Partials 12346 200 -12146
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/13981/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/13981/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.41% <ø> (-0.01%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/13981/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/cloudstack/pull/13981?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] new tenant instead of add account [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13981:
URL: https://github.com/apache/cloudstack/pull/13981#issuecomment-5452274934
@luganofer closed his issue and I am not sure how to continue. He raised a serious design issue which is not in line with the UI fix I am creating here. How do you think we should continue, @ingox @davift ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] new tenant instead of add account [cloudstack]
Posted by "luganofer (via GitHub)" <gi...@apache.org>.
luganofer commented on PR #13981:
URL: https://github.com/apache/cloudstack/pull/13981#issuecomment-5455590371
> @luganofer closed his issue and I am not sure how to continue. He raised a serious design issue which is not in line with the UI fix I am creating here. How do you think we should continue, @ingox @davift ?
Sorry for the confusion – I closed the issue accidentally while trying to reply. It's reopened now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] new tenant instead of add account [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13981:
URL: https://github.com/apache/cloudstack/pull/13981#issuecomment-5425545684
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] new tenant instead of add account [cloudstack]
Posted by "daviftorres (via GitHub)" <gi...@apache.org>.
daviftorres commented on PR #13981:
URL: https://github.com/apache/cloudstack/pull/13981#issuecomment-5427349638
Dear @DaanHoogland,
Thank you for taking this nomenclature issue seriously and working on a fix. This is also a constant source of confusion in our organization.
Regarding ACS's use of the word "Account," you recently labeled it "New Tenant Account." While this is an improvement, it may still cause some confusion.
Have you considered using "Department" or "Organizational Unit" instead?
Regards,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] new tenant instead of add account [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13981:
URL: https://github.com/apache/cloudstack/pull/13981#issuecomment-5425810296
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13981 (QA-JID-983)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] new tenant instead of add account [cloudstack]
Posted by "ingox (via GitHub)" <gi...@apache.org>.
ingox commented on PR #13981:
URL: https://github.com/apache/cloudstack/pull/13981#issuecomment-5430964499
@daviftorres I agree with your recommendations in the scope of a corporate organization.
But think of a public cloud where each account could represent a single user. AWS also names it accounts. So maybe renaming is not needed. Just decouple accounts from users and don't have them in the same dialog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] new tenant instead of add account [cloudstack]
Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on PR #13981:
URL: https://github.com/apache/cloudstack/pull/13981#issuecomment-5595267734
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] new tenant instead of add account [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13981:
URL: https://github.com/apache/cloudstack/pull/13981#issuecomment-5813551443
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] new tenant instead of add account [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #13981:
URL: https://github.com/apache/cloudstack/pull/13981#issuecomment-5426327308
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13981) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=13981&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=13981&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=13981&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=13981&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=13981&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13981)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] new tenant instead of add account [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13981:
URL: https://github.com/apache/cloudstack/pull/13981#issuecomment-5874980494
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] new tenant instead of add account [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13981:
URL: https://github.com/apache/cloudstack/pull/13981#issuecomment-5595289120
@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] new tenant instead of add account [cloudstack]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13981:
URL: https://github.com/apache/cloudstack/pull/13981#discussion_r4093298380
##########
ui/public/locales/en.json:
##########
@@ -3262,7 +3263,7 @@
"message.action.vmsnapshot.delete": "Please confirm that you want to delete this Instance Snapshot. <br>Please notice that the Instance will be paused before the Snapshot deletion, and resumed after deletion, if it runs on KVM.",
"message.action.vmsnapshot.disk-only.delete": "Please confirm that you want to delete this Instance Snapshot.",
"message.activate.project": "Are you sure you want to activate this project?",
-"message.api.not.available": "API is not available.",
+"message.add.account.warning": "Creating a new account creates a separate tenant with its own resource limits and isolated resources. Users in different accounts cannot share Instances or Volumes. Networks can be shared between accounts when the appropriate permissions are granted. To add a new user to an existing account instead, use the <b>Add User</b> action from the account's list or details view.",
Review Comment:
This replaces the existing `message.api.not.available` translation instead of adding a new key. `ImportUnmanagedInstance.vue` still translates that key when the API is unavailable, so the English notification now displays the raw key; restore the existing entry and keep this warning as a separate entry.
##########
ui/src/config/section/account.js:
##########
@@ -104,11 +104,23 @@ export default {
{
api: 'createAccount',
icon: 'plus-outlined',
- label: 'label.add.account',
+ label: 'label.add.new.tenant.account',
listView: true,
popup: true,
component: shallowRef(defineAsyncComponent(() => import('@/views/iam/AddAccount.vue')))
},
+ {
+ api: 'createUser',
+ icon: 'usergroup-add-outlined',
+ label: 'label.add.user',
+ listView: true,
+ dataView: true,
Review Comment:
Because this action is marked `listView: true`, it is also rendered in the list-level action bar. In list mode `AutogenView` supplies that bar with `resource = items[0]`, so clicking this button creates the user in the first listed account rather than an account the operator selected. The per-row QuickView already uses `dataView: true`; remove `listView` so the action is only offered for the account row/detail resource.
##########
ui/src/views/iam/AddUser.vue:
##########
@@ -247,8 +253,8 @@ export default {
})
},
fetchData () {
- this.account = this.$route.query && this.$route.query.account ? this.$route.query.account : null
- this.domainid = this.$route.query && this.$route.query.domainid ? this.$route.query.domainid : null
+ this.account = (this.$route.query && this.$route.query.account) || this.resource?.name || null
+ this.domainid = (this.$route.query && this.$route.query.domainid) || this.resource?.domainid || null
Review Comment:
`AutogenView` keeps action components alive and clears only `currentAction` on close, so `created()` is not rerun when this form is opened for another account. Since `fetchData()` copies `resource.name` and `resource.domainid` only once, reopening this action for account B can leave the previous account A in `this.account`/`this.domainid` and create the new user under A. Watch the resource (and reset/reinitialize the form state) or otherwise force a fresh component for each action.
##########
ui/src/config/section/account.js:
##########
@@ -104,11 +104,23 @@ export default {
{
api: 'createAccount',
icon: 'plus-outlined',
- label: 'label.add.account',
+ label: 'label.add.new.tenant.account',
listView: true,
popup: true,
component: shallowRef(defineAsyncComponent(() => import('@/views/iam/AddAccount.vue')))
},
+ {
+ api: 'createUser',
+ icon: 'usergroup-add-outlined',
Review Comment:
`usergroup-add-outlined` is not registered in `core/lazy_lib/icons_use.js` (the registered user action icon is `UserAddOutlined`), so this action can render without an icon. It is also not one of the icon names that `ActionButton` treats as a labeled list action, so the new list button will not display the “Add User” text. Use a registered/recognized icon or register and wire this one in both places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org