You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Manoj Kumar (JIRA)" <ji...@apache.org> on 2015/03/04 19:22:39 UTC
[jira] [Updated] (SPARK-6158) Move private method boost in
GradientBoostedTrees from Object to Class
[ https://issues.apache.org/jira/browse/SPARK-6158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Manoj Kumar updated SPARK-6158:
-------------------------------
Description:
1. a] When an instance of GradientBoostedTrees class is called and run, the boost method in the GradientBoostedTrees object is called ultimately. b] When a GradientBoostedTrees object is created and train is called, an instance of GradientBoostedTrees is created internally and this calls the boost method in a newly instantiated GradientBoostedTrees object which is confusing!
2. I require the finally trained models in the private method boost, for this (https://issues.apache.org/jira/browse/SPARK-6025) (to prevent repeated training). Thus it makes sense to move boost to the class GradientBoostedTrees where runWithValidation is already present.
was:
1. a] When an instance of GradientBoostedTrees class is called and run, the boost method in the GradientBoostedTrees object is called ultimately. b] When a GradientBoostedTrees object is created and train is called, an instance of GradientBoostedTrees is created, and this calls the boost method in the GradientBoostedTrees object which is confusing!
2. I require the finally trained models in the private method boost, for this (https://issues.apache.org/jira/browse/SPARK-6025) (to prevent repeated training). Thus it makes sense to move boost to the class GradientBoostedTrees where runWithValidation is already present.
> Move private method boost in GradientBoostedTrees from Object to Class
> ----------------------------------------------------------------------
>
> Key: SPARK-6158
> URL: https://issues.apache.org/jira/browse/SPARK-6158
> Project: Spark
> Issue Type: Improvement
> Components: MLlib
> Reporter: Manoj Kumar
> Priority: Minor
>
> 1. a] When an instance of GradientBoostedTrees class is called and run, the boost method in the GradientBoostedTrees object is called ultimately. b] When a GradientBoostedTrees object is created and train is called, an instance of GradientBoostedTrees is created internally and this calls the boost method in a newly instantiated GradientBoostedTrees object which is confusing!
> 2. I require the finally trained models in the private method boost, for this (https://issues.apache.org/jira/browse/SPARK-6025) (to prevent repeated training). Thus it makes sense to move boost to the class GradientBoostedTrees where runWithValidation is already present.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org