You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "cb-mukulsharma (via GitHub)" <gi...@apache.org> on 2024/01/05 14:34:44 UTC
[PR] Supporting UUID column type in shardingsphere [shardingsphere]
cb-mukulsharma opened a new pull request, #29662:
URL: https://github.com/apache/shardingsphere/pull/29662
Fixes [#24043](https://github.com/apache/shardingsphere/issues/24043).
Changes proposed in this pull request:
-
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Supporting UUID column type in shardingsphere [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on PR #29662:
URL: https://github.com/apache/shardingsphere/pull/29662#issuecomment-1882148951
> > Hi @cb-mukulsharma, can you add e2e test for uuid type?
>
> Hi @strongduanmu, Sure e2e tests for uuid added.
Good job, I will review this pr again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Supporting UUID column type in shardingsphere [shardingsphere]
Posted by "cb-mukulsharma (via GitHub)" <gi...@apache.org>.
cb-mukulsharma commented on PR #29662:
URL: https://github.com/apache/shardingsphere/pull/29662#issuecomment-1880057939
> Hi @cb-mukulsharma, can you add e2e test for uuid type?
Hi @strongduanmu, Sure e2e tests for uuid added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Supporting UUID column type in shardingsphere [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on PR #29662:
URL: https://github.com/apache/shardingsphere/pull/29662#issuecomment-1882833490
> > Hi @cb-mukulsharma, can you run e2e test on your local machine?
>
> Hi @strongduanmu, E2E tests are running successful. Here is the test report: <img alt="Screenshot 2024-01-09 at 3 16 43 PM" width="999" src="https://private-user-images.githubusercontent.com/113163591/295170675-477d9ef9-93a6-4584-b373-79ca9167e44f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDQ3OTczMzIsIm5iZiI6MTcwNDc5NzAzMiwicGF0aCI6Ii8xMTMxNjM1OTEvMjk1MTcwNjc1LTQ3N2Q5ZWY5LTkzYTYtNDU4NC1iMzczLTc5Y2E5MTY3ZTQ0Zi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwMTA5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDEwOVQxMDQzNTJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00MGNiOWMxMzcxY2FkMmY5OGE2YjZkMzQwMzc0NDk2YjExMWEwZTdmNTA4ZTgwNWFiZDJhZTVkYmIwNmRmMjliJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.ZuUuHjfOYiQ8RQn49W-nPPjcVpODRG0dOdv2YBPhA9E">
@cb-mukulsharma Can you take a look for https://github.com/apache/shardingsphere/actions/runs/7443816543/job/20296126253#step:7:14882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Supporting UUID column type in shardingsphere [shardingsphere]
Posted by "cb-mukulsharma (via GitHub)" <gi...@apache.org>.
cb-mukulsharma commented on PR #29662:
URL: https://github.com/apache/shardingsphere/pull/29662#issuecomment-1880057664
> Hi @cb-mukulsharma, can you add e2e test for uuid type?
> Hi @cb-mukulsharma, can you add e2e test for uuid type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Supporting UUID column type in shardingsphere [shardingsphere]
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on PR #29662:
URL: https://github.com/apache/shardingsphere/pull/29662#issuecomment-1893003086
Great job, thank you! @cb-mukulsharma @strongduanmu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Supporting UUID column type in shardingsphere [shardingsphere]
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang merged PR #29662:
URL: https://github.com/apache/shardingsphere/pull/29662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Supporting UUID column type in shardingsphere [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on PR #29662:
URL: https://github.com/apache/shardingsphere/pull/29662#issuecomment-1882202849
Hi @cb-mukulsharma, can you run e2e test on your local machine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Supporting UUID column type in shardingsphere [shardingsphere]
Posted by "cb-mukulsharma (via GitHub)" <gi...@apache.org>.
cb-mukulsharma commented on PR #29662:
URL: https://github.com/apache/shardingsphere/pull/29662#issuecomment-1879661061
> Hi @cb-mukulsharma, can you add e2e test for uuid type?
Hi @strongduanmu, can you please share some example PR or class that can help to write e2e tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Supporting UUID column type in shardingsphere [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on code in PR #29662:
URL: https://github.com/apache/shardingsphere/pull/29662#discussion_r1443528969
##########
db-protocol/postgresql/src/main/java/org/apache/shardingsphere/db/protocol/postgresql/packet/command/query/extended/bind/protocol/PostgreSQLUUIDBinaryProtocolValue.java:
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.db.protocol.postgresql.packet.command.query.extended.bind.protocol;
+
+import org.apache.shardingsphere.db.protocol.postgresql.payload.PostgreSQLPacketPayload;
+import org.postgresql.util.ByteConverter;
+
+import java.util.UUID;
+
+public class PostgreSQLUUIDBinaryProtocolValue implements PostgreSQLBinaryProtocolValue {
Review Comment:
Please add final and javadoc for PostgreSQLUUIDBinaryProtocolValue.
##########
db-protocol/postgresql/src/main/java/org/apache/shardingsphere/db/protocol/postgresql/packet/command/query/extended/bind/protocol/PostgreSQLUUIDBinaryProtocolValue.java:
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.db.protocol.postgresql.packet.command.query.extended.bind.protocol;
+
+import org.apache.shardingsphere.db.protocol.postgresql.payload.PostgreSQLPacketPayload;
+import org.postgresql.util.ByteConverter;
+
+import java.util.UUID;
+
+public class PostgreSQLUUIDBinaryProtocolValue implements PostgreSQLBinaryProtocolValue {
+
+ @Override
+ public int getColumnLength(final Object value) {
+ return 16;
+ }
+
+ @Override
+ public Object read(final PostgreSQLPacketPayload payload, final int parameterValueLength) {
+ byte[] result = new byte[parameterValueLength];
+ payload.getByteBuf().readBytes(result);
+ return new UUID(ByteConverter.int8(result, 0), ByteConverter.int8(result, 8));
+ }
+
+ @Override
+ public void write(final PostgreSQLPacketPayload payload, final Object value) {
+ UUID uuid = (UUID) value;
+ payload.writeInt8(uuid.getMostSignificantBits());
+ payload.writeInt8(uuid.getLeastSignificantBits());
+ }
+
Review Comment:
Please remove useless blank line.
##########
db-protocol/postgresql/src/test/java/org/apache/shardingsphere/db/protocol/postgresql/packet/command/query/extended/bind/protocol/PostgreSQLUUIDBinaryProtocolValueTest.java:
##########
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.db.protocol.postgresql.packet.command.query.extended.bind.protocol;
+
+import io.netty.buffer.ByteBuf;
+import io.netty.buffer.Unpooled;
+import org.apache.shardingsphere.db.protocol.postgresql.payload.PostgreSQLPacketPayload;
+import org.junit.jupiter.api.Test;
+
+import java.nio.ByteBuffer;
+import java.nio.charset.StandardCharsets;
+import java.util.UUID;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.hamcrest.MatcherAssert.assertThat;
+
+class PostgreSQLUUIDBinaryProtocolValueTest {
+
+ @Test
+ void assertGetColumnLength() {
+ assertThat(new PostgreSQLUUIDBinaryProtocolValue().getColumnLength(UUID.randomUUID()), is(16));
+ }
+
+ @Test
+ void assertRead() {
+ UUID randomUUID = UUID.randomUUID();
+ byte[] expected = new byte[16];
+ ByteBuffer buffer = ByteBuffer.wrap(expected);
+ buffer.putLong(randomUUID.getMostSignificantBits());
+ buffer.putLong(randomUUID.getLeastSignificantBits());
+
Review Comment:
Please remove useless blank line.
##########
db-protocol/postgresql/src/test/java/org/apache/shardingsphere/db/protocol/postgresql/packet/command/query/extended/bind/protocol/PostgreSQLUUIDBinaryProtocolValueTest.java:
##########
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.db.protocol.postgresql.packet.command.query.extended.bind.protocol;
+
+import io.netty.buffer.ByteBuf;
+import io.netty.buffer.Unpooled;
+import org.apache.shardingsphere.db.protocol.postgresql.payload.PostgreSQLPacketPayload;
+import org.junit.jupiter.api.Test;
+
+import java.nio.ByteBuffer;
+import java.nio.charset.StandardCharsets;
+import java.util.UUID;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.hamcrest.MatcherAssert.assertThat;
+
+class PostgreSQLUUIDBinaryProtocolValueTest {
+
+ @Test
+ void assertGetColumnLength() {
+ assertThat(new PostgreSQLUUIDBinaryProtocolValue().getColumnLength(UUID.randomUUID()), is(16));
+ }
+
+ @Test
+ void assertRead() {
+ UUID randomUUID = UUID.randomUUID();
+ byte[] expected = new byte[16];
+ ByteBuffer buffer = ByteBuffer.wrap(expected);
+ buffer.putLong(randomUUID.getMostSignificantBits());
+ buffer.putLong(randomUUID.getLeastSignificantBits());
+
+ ByteBuf byteBuf = Unpooled.wrappedBuffer(expected);
+ PostgreSQLPacketPayload payload = new PostgreSQLPacketPayload(byteBuf, StandardCharsets.UTF_8);
+ assertThat(new PostgreSQLUUIDBinaryProtocolValue().read(payload, 16), is(randomUUID));
+ }
+
+ @Test
+ void assertWrite() {
+ UUID randomUUID = UUID.randomUUID();
+ byte[] expected = new byte[16];
+ ByteBuffer buffer = ByteBuffer.wrap(expected);
+ buffer.putLong(randomUUID.getMostSignificantBits());
+ buffer.putLong(randomUUID.getLeastSignificantBits());
+
Review Comment:
Please remove useless blank line.
##########
db-protocol/postgresql/src/test/java/org/apache/shardingsphere/db/protocol/postgresql/packet/command/query/extended/bind/protocol/PostgreSQLUUIDBinaryProtocolValueTest.java:
##########
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.db.protocol.postgresql.packet.command.query.extended.bind.protocol;
+
+import io.netty.buffer.ByteBuf;
+import io.netty.buffer.Unpooled;
+import org.apache.shardingsphere.db.protocol.postgresql.payload.PostgreSQLPacketPayload;
+import org.junit.jupiter.api.Test;
+
+import java.nio.ByteBuffer;
+import java.nio.charset.StandardCharsets;
+import java.util.UUID;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.hamcrest.MatcherAssert.assertThat;
+
+class PostgreSQLUUIDBinaryProtocolValueTest {
+
+ @Test
+ void assertGetColumnLength() {
+ assertThat(new PostgreSQLUUIDBinaryProtocolValue().getColumnLength(UUID.randomUUID()), is(16));
+ }
+
+ @Test
+ void assertRead() {
+ UUID randomUUID = UUID.randomUUID();
+ byte[] expected = new byte[16];
+ ByteBuffer buffer = ByteBuffer.wrap(expected);
+ buffer.putLong(randomUUID.getMostSignificantBits());
+ buffer.putLong(randomUUID.getLeastSignificantBits());
+
+ ByteBuf byteBuf = Unpooled.wrappedBuffer(expected);
+ PostgreSQLPacketPayload payload = new PostgreSQLPacketPayload(byteBuf, StandardCharsets.UTF_8);
+ assertThat(new PostgreSQLUUIDBinaryProtocolValue().read(payload, 16), is(randomUUID));
+ }
+
+ @Test
+ void assertWrite() {
+ UUID randomUUID = UUID.randomUUID();
+ byte[] expected = new byte[16];
+ ByteBuffer buffer = ByteBuffer.wrap(expected);
+ buffer.putLong(randomUUID.getMostSignificantBits());
+ buffer.putLong(randomUUID.getLeastSignificantBits());
+
+ ByteBuf byteBuf = Unpooled.wrappedBuffer(expected);
+ PostgreSQLPacketPayload payload = new PostgreSQLPacketPayload(byteBuf.writerIndex(0), StandardCharsets.UTF_8);
+
Review Comment:
Please remove useless blank line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Supporting UUID column type in shardingsphere [shardingsphere]
Posted by "cb-mukulsharma (via GitHub)" <gi...@apache.org>.
cb-mukulsharma closed pull request #29662: Supporting UUID column type in shardingsphere
URL: https://github.com/apache/shardingsphere/pull/29662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Supporting UUID column type in shardingsphere [shardingsphere]
Posted by "cb-mukulsharma (via GitHub)" <gi...@apache.org>.
cb-mukulsharma commented on PR #29662:
URL: https://github.com/apache/shardingsphere/pull/29662#issuecomment-1882766400
> Hi @cb-mukulsharma, can you run e2e test on your local machine?
Hi @strongduanmu, E2E tests are running successful. Here is the test report:
<img width="999" alt="Screenshot 2024-01-09 at 3 16 43 PM" src="https://github.com/apache/shardingsphere/assets/113163591/477d9ef9-93a6-4584-b373-79ca9167e44f">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Supporting UUID column type in shardingsphere [shardingsphere]
Posted by "cb-mukulsharma (via GitHub)" <gi...@apache.org>.
cb-mukulsharma commented on PR #29662:
URL: https://github.com/apache/shardingsphere/pull/29662#issuecomment-1892068882
> > > Hi @cb-mukulsharma, can you run e2e test on your local machine?
> >
> >
> > Hi @strongduanmu, E2E tests are running successful. Here is the test report: <img alt="Screenshot 2024-01-09 at 3 16 43 PM" width="999" src="https://private-user-images.githubusercontent.com/113163591/295170675-477d9ef9-93a6-4584-b373-79ca9167e44f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDQ3OTczMzIsIm5iZiI6MTcwNDc5NzAzMiwicGF0aCI6Ii8xMTMxNjM1OTEvMjk1MTcwNjc1LTQ3N2Q5ZWY5LTkzYTYtNDU4NC1iMzczLTc5Y2E5MTY3ZTQ0Zi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwMTA5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDEwOVQxMDQzNTJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00MGNiOWMxMzcxY2FkMmY5OGE2YjZkMzQwMzc0NDk2YjExMWEwZTdmNTA4ZTgwNWFiZDJhZTVkYmIwNmRmMjliJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.ZuUuHjfOYiQ8RQn49W-nPPjcVpODRG0dOdv2YBPhA9E">
>
> @cb-mukulsharma Can you take a look for https://github.com/apache/shardingsphere/actions/runs/7443816543/job/20296126253#step:7:14882
Hey @strongduanmu, I have fixed the issue with test case. It is working fine in local. Can you please re-run the E2E test-suites. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org