[jira] [Commented] (THRIFT-3784) thrift-maven-plugin generates invalid include directories for IDL in dependency JARs

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230506#comment-15230506 ] 

ASF GitHub Bot commented on THRIFT-3784:
----------------------------------------

GitHub user csosborn opened a pull request:

    https://github.com/apache/thrift/pull/984

    THRIFT-3784: fix and tests

    This patch fixes [THRIFT-3784](https://issues.apache.org/jira/browse/THRIFT-3784), a bug in the thrift-maven-plugin.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/csosborn/thrift THRIFT-3784

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/984.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #984
    
----
commit e5cf90e6f1d3d3e52c5c645b9fa04626176354f1
Author: Chris Osborn <co...@conductor.com>
Date:   2016-04-07T16:20:02Z

    Fix and tests for THRIFT-3784.

----


> thrift-maven-plugin generates invalid include directories for IDL in dependency JARs
> ------------------------------------------------------------------------------------
>
>                 Key: THRIFT-3784
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3784
>             Project: Thrift
>          Issue Type: Bug
>            Reporter: Chris Osborn
>
> The thrift-maven-plugin attempts to support building .thrift files that depend on other .thrift files provided in a dependency JAR. It does this by copying the dependency JAR's thrift files into a temporary directory then passing corresponding include directory options to the thrift compiler. However, the process of generating the include directory paths is faulty: there is a path for each and every directory that contains a .thrift file, rather than a single path to the root of the thrift file hierarchy. That means that any thrift files that reference others using paths relative to a root will fail. It may happen to work where the thrift files are all in a single directory, but not in the general case.
> There are no tests of this support, so I've added a few in the pull request I'm preparing. 
> Somebody found the exact same problem and issued a pull request against this plugin's original repository on Github: https://github.com/dtrott/maven-thrift-plugin/pull/28. It went nowhere because the project was already pending ASF acceptance at that point, but it's worth looking at as an additional reference.
> Thanks!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)