You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/11/10 02:05:19 UTC

[GitHub] [hadoop] xicm commented on a change in pull request #3634: HADOOP-17997. RBF: Namespace usage of mount table with multi subclust…

xicm commented on a change in pull request #3634:
URL: https://github.com/apache/hadoop/pull/3634#discussion_r746192153



##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Quota.java
##########
@@ -50,7 +50,7 @@ public static Counts newInstance() {
    * The quota is violated if quota is set and usage &gt; quota.
    */
   public static boolean isViolated(final long quota, final long usage) {
-    return quota >= 0 && usage > quota;
+    return quota >= 0 && usage >= quota;

Review comment:
       Yes, the core changes are in general HDFS, but the caller to this method is in RBF and some method for WARNING logs. 
   
   The general check of quota calls the method below.
   `/**
      * Is quota violated?
      * The quota is violated if quota is set, delta &gt; 0 and
      * usage + delta &gt; quota.
      */
     static boolean isViolated(final long quota, final long usage,
         final long delta) {
       return quota >= 0 && delta > 0 && usage > quota - delta;
     }`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org