You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/08/03 07:08:27 UTC
[GitHub] [netbeans] dbalek commented on a diff in pull request #4461: Support for vulnerability audit in Oracle cloud
dbalek commented on code in PR #4461:
URL: https://github.com/apache/netbeans/pull/4461#discussion_r936310039
##########
java/java.lsp.server/nbcode/integration/nbproject/project.xml:
##########
@@ -76,13 +93,39 @@
<specification-version>1.7.3</specification-version>
</run-dependency>
</dependency>
+ <dependency>
+ <code-name-base>org.netbeans.modules.cloud.oracle</code-name-base>
+ <build-prerequisite/>
+ <compile-dependency/>
+ <run-dependency>
+ <implementation-version/>
+ </run-dependency>
+ </dependency>
<dependency>
<code-name-base>org.netbeans.modules.java.lsp.server</code-name-base>
<build-prerequisite/>
<compile-dependency/>
<run-dependency>
<release-version>2</release-version>
- <specification-version>2.0</specification-version>
+ <implementation-version/>
Review Comment:
Instead of introducing new implementation dependencies, better longer term solution would be to crate `CommandProvider` interface inside the `api.lsp` module and implement the `ProjectAuditCommand` directly as a part of `cloud.oracle` module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists