You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Peter Poeml <po...@suse.de> on 2002/07/15 18:01:10 UTC

[PATCH] autoconf macros: quote macro names

Hi, 

in the autoconf macro definitions of acinclude.m4, the macro names are
not quoted as suggested in the autoconf documentation for AC_DEFUN:


[...]
   Be sure to properly quote both the MACRO-BODY _and_ the MACRO-NAME
to avoid any problems if the macro happens to have been previously
defined.
[...]


The missing quotes actually lead to problems when running autoreconf
with recent autoconf versions.

The attached patch adds brackets around those macro names. It applies
against 2.0.39 as well as the head branch.

Peter

-- 
VFS: Busy inodes after unmount. Self-destruct in 5 seconds.  Have a nice day...

Re: [PATCH] autoconf macros: quote macro names

Posted by Peter Poeml <po...@suse.de>.
On Tue, Jul 16, 2002 at 03:50:45PM -0700, Justin Erenkrantz wrote:
> On Mon, Jul 15, 2002 at 06:01:10PM +0200, Peter Poeml wrote:
> > Hi, 
> > 
> > in the autoconf macro definitions of acinclude.m4, the macro names are
> > not quoted as suggested in the autoconf documentation for AC_DEFUN:
> > 
> > 
> > [...]
> >    Be sure to properly quote both the MACRO-BODY _and_ the MACRO-NAME
> > to avoid any problems if the macro happens to have been previously
> > defined.
> > [...]
> > 
> > 
> > The missing quotes actually lead to problems when running autoreconf
> > with recent autoconf versions.
> 
> What versions of autoconf have this problem?  -- justin

I'm not entirely sure -- at least with 2.52 and 2.53 it occurs here. They end
up in a recursion loop:

chroot ROOT@pepper /usr/src/packages/BUILD/httpd-2.0.39/ # aclocal
chroot ROOT@pepper /usr/src/packages/BUILD/httpd-2.0.39/ # autoconf
/usr/bin/m4: acinclude.m4: 289: ERROR: Recursion limit of 1024 exceeded, use -L<N> to change it

This happens not only in our stable branch but also on SuSE Linux 8.0.

However, obviously the configure script packaged with the 2.0.39 tarball has
been created with autoconf 2.53. So it seems to work for you, somehow. 

Peter

-- 
VFS: Busy inodes after unmount. Self-destruct in 5 seconds.  Have a nice day...

Re: [PATCH] autoconf macros: quote macro names

Posted by Justin Erenkrantz <je...@apache.org>.
On Mon, Jul 15, 2002 at 06:01:10PM +0200, Peter Poeml wrote:
> Hi, 
> 
> in the autoconf macro definitions of acinclude.m4, the macro names are
> not quoted as suggested in the autoconf documentation for AC_DEFUN:
> 
> 
> [...]
>    Be sure to properly quote both the MACRO-BODY _and_ the MACRO-NAME
> to avoid any problems if the macro happens to have been previously
> defined.
> [...]
> 
> 
> The missing quotes actually lead to problems when running autoreconf
> with recent autoconf versions.

What versions of autoconf have this problem?  -- justin