You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/10 09:03:59 UTC
[GitHub] [camel-quarkus] ppalaga opened a new pull request #863: Fix #795
File Watch support
ppalaga opened a new pull request #863: Fix #795 File Watch support
URL: https://github.com/apache/camel-quarkus/pull/863
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #863: Fix #795 File
Watch support
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #863: Fix #795 File Watch support
URL: https://github.com/apache/camel-quarkus/pull/863#issuecomment-597001133
a00ca02 fixes the issue found by @jamesnetherton
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga merged pull request #863: Fix #795 File
Watch support
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #863: Fix #795 File Watch support
URL: https://github.com/apache/camel-quarkus/pull/863
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #863: Fix #795 File
Watch support
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #863: Fix #795 File Watch support
URL: https://github.com/apache/camel-quarkus/pull/863#issuecomment-597020111
> what's the difference between the `mac` and `non-mac` profile?
Good catch, it is a leftover from my earlier experiments where I tried to exclude JNA for non-mac but it did not work well in the native mode.
Removed the profiles in 929889d.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton commented on issue #863: Fix #795
File Watch support
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on issue #863: Fix #795 File Watch support
URL: https://github.com/apache/camel-quarkus/pull/863#issuecomment-597006039
One question before approving - what's the difference between the `mac` and `non-mac` profile? I didn't see anything obvious aside from the comment about exclusions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #863:
Fix #795 File Watch support
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #863: Fix #795 File Watch support
URL: https://github.com/apache/camel-quarkus/pull/863#discussion_r390190753
##########
File path: docs/modules/ROOT/pages/extensions/file-watch.adoc
##########
@@ -0,0 +1,30 @@
+[[netty]]
Review comment:
+1, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull
request #863: Fix #795 File Watch support
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #863: Fix #795 File Watch support
URL: https://github.com/apache/camel-quarkus/pull/863#discussion_r390174566
##########
File path: docs/modules/ROOT/pages/extensions/file-watch.adoc
##########
@@ -0,0 +1,30 @@
+[[netty]]
Review comment:
Not netty :slightly_smiling_face:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #863: Fix #795 File
Watch support
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #863: Fix #795 File Watch support
URL: https://github.com/apache/camel-quarkus/pull/863#issuecomment-597021319
f83e7b8 removed the profiles correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services