You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "zabetak (via GitHub)" <gi...@apache.org> on 2023/06/23 08:31:02 UTC
[GitHub] [calcite] zabetak opened a new pull request, #3278: [CALCITE-5773] Gradle show tasks fails when creating javadocAggregateIncludingTests
zabetak opened a new pull request, #3278:
URL: https://github.com/apache/calcite/pull/3278
1. Exclude "bom" project from the javadoc aggregation since it does not have "main" and "test" objects causing "tasks" to fail.
2. Include "tasks" when building with newest & oldest JDK in CI to ensure it remains functional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] sonarcloud[bot] commented on pull request #3278: [CALCITE-5773] Gradle show tasks fails when creating javadocAggregateIncludingTests
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3278:
URL: https://github.com/apache/calcite/pull/3278#issuecomment-1603951999
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3278)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3278&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3278&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3278&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3278&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3278&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3278&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3278&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3278&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3278&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3278&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3278&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3278&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3278&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3278&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] zabetak closed pull request #3278: [CALCITE-5773] Gradle show tasks fails when creating javadocAggregateIncludingTests
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak closed pull request #3278: [CALCITE-5773] Gradle show tasks fails when creating javadocAggregateIncludingTests
URL: https://github.com/apache/calcite/pull/3278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] zabetak commented on a diff in pull request #3278: [CALCITE-5773] Gradle show tasks fails when creating javadocAggregateIncludingTests
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on code in PR #3278:
URL: https://github.com/apache/calcite/pull/3278#discussion_r1241095052
##########
build.gradle.kts:
##########
@@ -202,6 +202,7 @@ val javadocAggregateIncludingTests by tasks.registering(Javadoc::class) {
description = "Generates aggregate javadoc for all the artifacts"
val sourceSets = subprojects
+ .filter { it.name != "bom" }
Review Comment:
I prefer to keep it as is. Thanks for taking a look!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] libenchao commented on a diff in pull request #3278: [CALCITE-5773] Gradle show tasks fails when creating javadocAggregateIncludingTests
Posted by "libenchao (via GitHub)" <gi...@apache.org>.
libenchao commented on code in PR #3278:
URL: https://github.com/apache/calcite/pull/3278#discussion_r1240586484
##########
build.gradle.kts:
##########
@@ -202,6 +202,7 @@ val javadocAggregateIncludingTests by tasks.registering(Javadoc::class) {
description = "Generates aggregate javadoc for all the artifacts"
val sourceSets = subprojects
+ .filter { it.name != "bom" }
Review Comment:
`javadocAggregate` section uses `.filter { it.names.contains("main") }`, we'd better to keep them consistent? (Both way looks good to me).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org