You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@yetus.apache.org by GitBox <gi...@apache.org> on 2020/07/27 02:58:11 UTC

[GitHub] [yetus] aajisaka opened a new pull request #116: YETUS-976. MAVEN_OPTS in Dockerfile is not honored

aajisaka opened a new pull request #116:
URL: https://github.com/apache/yetus/pull/116


   JIRA: https://issues.apache.org/jira/browse/YETUS-976


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [yetus] aw-was-here commented on pull request #116: YETUS-976. MAVEN_OPTS in Dockerfile is not honored

Posted by GitBox <gi...@apache.org>.
aw-was-here commented on pull request #116:
URL: https://github.com/apache/yetus/pull/116#issuecomment-664123026


   -1
   
   This will break all kinds of things.  Changing MAVEN_OPTS in the middle of the test-patch boot process makes testing wildly unpredictable.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [yetus] aw-was-here edited a comment on pull request #116: YETUS-976. MAVEN_OPTS in Dockerfile is not honored

Posted by GitBox <gi...@apache.org>.
aw-was-here edited a comment on pull request #116:
URL: https://github.com/apache/yetus/pull/116#issuecomment-664123026


   -1
   
   This will break all kinds of things.  Changing MAVEN_OPTS in the middle of the test-patch boot process makes testing wildly unpredictable.  It either needs to get set in the personality or prior to launching docker.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [yetus] aajisaka commented on pull request #116: YETUS-976. MAVEN_OPTS in Dockerfile is not honored

Posted by GitBox <gi...@apache.org>.
aajisaka commented on pull request #116:
URL: https://github.com/apache/yetus/pull/116#issuecomment-664127861


   Thanks @aw-was-here for your review.
   `add_docker_env MAVEN_OPTS` fails to set environment variable in the docker image if `MAVEN_OPTS` have spaces. I'll file a new JIRA and will create a PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [yetus] aajisaka commented on pull request #116: YETUS-976. MAVEN_OPTS in Dockerfile is not honored

Posted by GitBox <gi...@apache.org>.
aajisaka commented on pull request #116:
URL: https://github.com/apache/yetus/pull/116#issuecomment-664121788


   Testing in https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-branch-2.10-java7-linux-x86_64/6/


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [yetus] aajisaka edited a comment on pull request #116: YETUS-976. MAVEN_OPTS in Dockerfile is not honored

Posted by GitBox <gi...@apache.org>.
aajisaka edited a comment on pull request #116:
URL: https://github.com/apache/yetus/pull/116#issuecomment-664127861


   Thanks @aw-was-here for your review.
   ~~`add_docker_env MAVEN_OPTS` fails to set environment variable in the docker image if `MAVEN_OPTS` have spaces. I'll file a new JIRA and will create a PR.~~
   Sorry, it does not fail.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [yetus] aajisaka closed pull request #116: YETUS-976. MAVEN_OPTS in Dockerfile is not honored

Posted by GitBox <gi...@apache.org>.
aajisaka closed pull request #116:
URL: https://github.com/apache/yetus/pull/116


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org