You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/11/30 16:22:54 UTC
[GitHub] [hudi] nsivabalan opened a new pull request #4167: [HUDI-2880] Fixing loading of props from default dir
nsivabalan opened a new pull request #4167:
URL: https://github.com/apache/hudi/pull/4167
## What is the purpose of the pull request
- When default hudi conf is not present, we should do warn log and not error log
- Also fixed loading of props from default file in default dir.
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
- tested it manually since creation of files under /etc/hudi/conf needs root level permission and hence can't write unit tests.
```
scala> df.write.format("hudi").
| options(getQuickstartWriteConfigs).
| option(PRECOMBINE_FIELD.key(), "ts").
| option(RECORDKEY_FIELD.key(), "uuid").
| option(PARTITIONPATH_FIELD.key(), "partitionpath").
| option(TBL_NAME.key(), tableName).
| mode(Overwrite).
| save(basePath)
21/11/30 11:11:01 WARN DFSPropertiesConfiguration: Cannot find HUDI_CONF_DIR, please set it as the dir of hudi-defaults.conf
21/11/30 11:11:01 WARN DFSPropertiesConfiguration: Properties file file:/etc/hudi/conf/hudi-defaults.conf not found. Ignoring to load props file
21/11/30 11:11:01 WARN HoodieSparkSqlWriter$: hoodie table at file:/tmp/hudi_trips_cow already exists. Deleting existing data & overwriting with new data.
```
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#issuecomment-982802535
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3898",
"triggerID" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bf0309fdfef570903c582da51b7a0a46efb9da2d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3898)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#issuecomment-983221885
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3898",
"triggerID" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"triggerType" : "PUSH"
}, {
"hash" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3901",
"triggerID" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1c3bad0199b6744fecc1f3638ea30aac788b35bd Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3901)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on a change in pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#discussion_r826365626
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/config/DFSPropertiesConfiguration.java
##########
@@ -97,11 +99,7 @@ public static TypedProperties loadGlobalProps() {
if (defaultConfPath.isPresent()) {
conf.addPropsFromFile(defaultConfPath.get());
} else {
- try {
- conf.addPropsFromFile(new Path(DEFAULT_CONF_FILE_DIR));
- } catch (Exception ignored) {
Review comment:
this is actually preferrable to leaking the check for a default path inside `addPropsFromFile`
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/config/DFSPropertiesConfiguration.java
##########
@@ -128,14 +126,19 @@ public void addPropsFromFile(Path filePath) {
filePath.toString(),
Option.ofNullable(hadoopConfig).orElseGet(Configuration::new)
);
+ try {
+ if (filePath.equals(DEFAULT_PATH) && !fs.exists(filePath)) {
+ LOG.warn("Properties file " + filePath + " not found. Ignoring to load props file");
+ return;
+ }
- try (BufferedReader reader = new BufferedReader(new InputStreamReader(fs.open(filePath)))) {
+ BufferedReader reader = new BufferedReader(new InputStreamReader(fs.open(filePath)));
Review comment:
why remove the `try` here? it closes the reader correctly right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#issuecomment-983112234
> When default hudi conf is not present, we should do warn log and not error log
@nsivabalan it is currently set to warn log, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#issuecomment-983188356
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3898",
"triggerID" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"triggerType" : "PUSH"
}, {
"hash" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3901",
"triggerID" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bf0309fdfef570903c582da51b7a0a46efb9da2d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3898)
* 1c3bad0199b6744fecc1f3638ea30aac788b35bd Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3901)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a change in pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#discussion_r759733359
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/config/DFSPropertiesConfiguration.java
##########
@@ -119,7 +118,7 @@ public static void clearGlobalProps() {
*
* @param filePath File path for configuration file
*/
- public void addPropsFromFile(Path filePath) {
+ public void addPropsFromFile(Path filePath, boolean isDefaultDirectory) {
Review comment:
don't think we need extra param for this. if `filePath` is the default one, we know it by comparing it with `new Path(DEFAULT_CONF_FILE_DIR + "/" + DEFAULT_PROPERTIES_FILE)` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#issuecomment-983262850
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3898",
"triggerID" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"triggerType" : "PUSH"
}, {
"hash" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3901",
"triggerID" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"triggerType" : "PUSH"
}, {
"hash" : "8c008662ef556f9333d6512ad31d09837e2b57cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3906",
"triggerID" : "8c008662ef556f9333d6512ad31d09837e2b57cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1c3bad0199b6744fecc1f3638ea30aac788b35bd Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3901)
* 8c008662ef556f9333d6512ad31d09837e2b57cb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3906)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#issuecomment-983258428
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3898",
"triggerID" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"triggerType" : "PUSH"
}, {
"hash" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3901",
"triggerID" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"triggerType" : "PUSH"
}, {
"hash" : "8c008662ef556f9333d6512ad31d09837e2b57cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c008662ef556f9333d6512ad31d09837e2b57cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1c3bad0199b6744fecc1f3638ea30aac788b35bd Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3901)
* 8c008662ef556f9333d6512ad31d09837e2b57cb UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#issuecomment-983188356
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3898",
"triggerID" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"triggerType" : "PUSH"
}, {
"hash" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3901",
"triggerID" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bf0309fdfef570903c582da51b7a0a46efb9da2d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3898)
* 1c3bad0199b6744fecc1f3638ea30aac788b35bd Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3901)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#issuecomment-983187111
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3898",
"triggerID" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"triggerType" : "PUSH"
}, {
"hash" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bf0309fdfef570903c582da51b7a0a46efb9da2d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3898)
* 1c3bad0199b6744fecc1f3638ea30aac788b35bd UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
danny0405 merged pull request #4167:
URL: https://github.com/apache/hudi/pull/4167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#issuecomment-983379782
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3898",
"triggerID" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"triggerType" : "PUSH"
}, {
"hash" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3901",
"triggerID" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"triggerType" : "PUSH"
}, {
"hash" : "8c008662ef556f9333d6512ad31d09837e2b57cb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3906",
"triggerID" : "8c008662ef556f9333d6512ad31d09837e2b57cb",
"triggerType" : "PUSH"
}, {
"hash" : "8c008662ef556f9333d6512ad31d09837e2b57cb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3911",
"triggerID" : "983326804",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 8c008662ef556f9333d6512ad31d09837e2b57cb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3906) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3911)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#issuecomment-983292160
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3898",
"triggerID" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"triggerType" : "PUSH"
}, {
"hash" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3901",
"triggerID" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"triggerType" : "PUSH"
}, {
"hash" : "8c008662ef556f9333d6512ad31d09837e2b57cb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3906",
"triggerID" : "8c008662ef556f9333d6512ad31d09837e2b57cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c008662ef556f9333d6512ad31d09837e2b57cb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3906)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#issuecomment-983258428
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3898",
"triggerID" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"triggerType" : "PUSH"
}, {
"hash" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3901",
"triggerID" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"triggerType" : "PUSH"
}, {
"hash" : "8c008662ef556f9333d6512ad31d09837e2b57cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c008662ef556f9333d6512ad31d09837e2b57cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1c3bad0199b6744fecc1f3638ea30aac788b35bd Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3901)
* 8c008662ef556f9333d6512ad31d09837e2b57cb UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#issuecomment-982799914
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bf0309fdfef570903c582da51b7a0a46efb9da2d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a change in pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
yihua commented on a change in pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#discussion_r759775742
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/config/DFSPropertiesConfiguration.java
##########
@@ -128,14 +127,19 @@ public void addPropsFromFile(Path filePath) {
filePath.toString(),
Option.ofNullable(hadoopConfig).orElseGet(Configuration::new)
);
+ try {
+ if (isDefaultDirectory && !fs.exists(filePath)) {
Review comment:
I think we still need to check if the props file exists if the user configures it. It doesn't have to be an error if the file cannot be found.
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/config/DFSPropertiesConfiguration.java
##########
@@ -119,7 +118,7 @@ public static void clearGlobalProps() {
*
* @param filePath File path for configuration file
*/
- public void addPropsFromFile(Path filePath) {
+ public void addPropsFromFile(Path filePath, boolean isDefaultDirectory) {
Review comment:
+1. `visitedFilePaths` also stores the loaded props file so each props file is only read once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#issuecomment-983187111
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3898",
"triggerID" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"triggerType" : "PUSH"
}, {
"hash" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bf0309fdfef570903c582da51b7a0a46efb9da2d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3898)
* 1c3bad0199b6744fecc1f3638ea30aac788b35bd UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#issuecomment-982858325
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3898",
"triggerID" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bf0309fdfef570903c582da51b7a0a46efb9da2d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3898)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#issuecomment-983121478
@xushiyan : this is what we see w/o this fix
```
21/11/26 20:53:41 WARN DFSPropertiesConfiguration: Cannot find HUDI_CONF_DIR, please set it as the dir of hudi-defaults.conf
21/11/26 20:53:41 ERROR DFSPropertiesConfiguration: Error reading in properties from dfs
21/11/26 20:53:41 WARN DFSPropertiesConfiguration: Didn't find config file under default conf file dir: file:/etc/hudi/conf
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#issuecomment-983292160
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3898",
"triggerID" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"triggerType" : "PUSH"
}, {
"hash" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3901",
"triggerID" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"triggerType" : "PUSH"
}, {
"hash" : "8c008662ef556f9333d6512ad31d09837e2b57cb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3906",
"triggerID" : "8c008662ef556f9333d6512ad31d09837e2b57cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c008662ef556f9333d6512ad31d09837e2b57cb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3906)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#issuecomment-983327655
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3898",
"triggerID" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"triggerType" : "PUSH"
}, {
"hash" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3901",
"triggerID" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"triggerType" : "PUSH"
}, {
"hash" : "8c008662ef556f9333d6512ad31d09837e2b57cb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3906",
"triggerID" : "8c008662ef556f9333d6512ad31d09837e2b57cb",
"triggerType" : "PUSH"
}, {
"hash" : "8c008662ef556f9333d6512ad31d09837e2b57cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3911",
"triggerID" : "983326804",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 8c008662ef556f9333d6512ad31d09837e2b57cb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3906) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3911)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#issuecomment-982802535
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3898",
"triggerID" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bf0309fdfef570903c582da51b7a0a46efb9da2d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3898)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#issuecomment-983327655
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3898",
"triggerID" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"triggerType" : "PUSH"
}, {
"hash" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3901",
"triggerID" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"triggerType" : "PUSH"
}, {
"hash" : "8c008662ef556f9333d6512ad31d09837e2b57cb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3906",
"triggerID" : "8c008662ef556f9333d6512ad31d09837e2b57cb",
"triggerType" : "PUSH"
}, {
"hash" : "8c008662ef556f9333d6512ad31d09837e2b57cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3911",
"triggerID" : "983326804",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 8c008662ef556f9333d6512ad31d09837e2b57cb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3906) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3911)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#issuecomment-982799914
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bf0309fdfef570903c582da51b7a0a46efb9da2d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#issuecomment-983221885
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3898",
"triggerID" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"triggerType" : "PUSH"
}, {
"hash" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3901",
"triggerID" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1c3bad0199b6744fecc1f3638ea30aac788b35bd Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3901)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a change in pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
yihua commented on a change in pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#discussion_r759819354
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/config/DFSPropertiesConfiguration.java
##########
@@ -97,11 +99,7 @@ public static TypedProperties loadGlobalProps() {
if (defaultConfPath.isPresent()) {
conf.addPropsFromFile(defaultConfPath.get());
} else {
- try {
- conf.addPropsFromFile(new Path(DEFAULT_CONF_FILE_DIR));
- } catch (Exception ignored) {
- LOG.warn("Didn't find config file under default conf file dir: " + DEFAULT_CONF_FILE_DIR);
- }
+ conf.addPropsFromFile(new Path(DEFAULT_CONF_FILE_DIR + "/" + DEFAULT_PROPERTIES_FILE));
Review comment:
use `DEFAULT_PATH` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#issuecomment-982858325
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3898",
"triggerID" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bf0309fdfef570903c582da51b7a0a46efb9da2d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3898)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
danny0405 commented on pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#issuecomment-983326804
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4167: [HUDI-2880] Fixing loading of props from default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4167:
URL: https://github.com/apache/hudi/pull/4167#issuecomment-983262850
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3898",
"triggerID" : "bf0309fdfef570903c582da51b7a0a46efb9da2d",
"triggerType" : "PUSH"
}, {
"hash" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3901",
"triggerID" : "1c3bad0199b6744fecc1f3638ea30aac788b35bd",
"triggerType" : "PUSH"
}, {
"hash" : "8c008662ef556f9333d6512ad31d09837e2b57cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3906",
"triggerID" : "8c008662ef556f9333d6512ad31d09837e2b57cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1c3bad0199b6744fecc1f3638ea30aac788b35bd Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3901)
* 8c008662ef556f9333d6512ad31d09837e2b57cb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3906)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org