You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/09/08 07:29:09 UTC
[GitHub] [incubator-pegasus] shalk opened a new pull request, #1152: feat: make java client interface closable
shalk opened a new pull request, #1152:
URL: https://github.com/apache/incubator-pegasus/pull/1152
### What problem does this PR solve? <!--add issue link with summary if exists-->
- make PegasusAdminClientInterface / PegasusClientInterface / PegasusClientInterface closable
- fix pom
### What is changed and how does it work?
### Checklist <!--REMOVE the items that are not applicable-->
##### Tests <!-- At least one of them must be included. -->
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
##### Code changes
- Has exported function/method change
- Has exported variable/fields change
- Has interface methods change
- Has persistent data change
##### Side effects
- Possible performance regression
- Increased code complexity
- Breaking backward compatibility
##### Related changes
- Need to cherry-pick to the release branch
- Need to update the documentation
- Need to be included in the release note
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #1152: feat: make java client interface closable
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on PR #1152:
URL: https://github.com/apache/incubator-pegasus/pull/1152#issuecomment-1240360337
Thanks to your contribution! There is a conflicting file need to be resolved firstly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #1152: feat: make java client interface closable
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on PR #1152:
URL: https://github.com/apache/incubator-pegasus/pull/1152#issuecomment-1240632656
@shalk Could you help to create an issue fot it? and paste the link in the PR description, otherwise, the CI will fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] shalk commented on pull request #1152: feat: make java client interface closable
Posted by GitBox <gi...@apache.org>.
shalk commented on PR #1152:
URL: https://github.com/apache/incubator-pegasus/pull/1152#issuecomment-1240660001
> @shalk Could you help to create an issue fot it? and paste the link in the PR description, otherwise, the CI will fail.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #1152: feat: make java client interface closable
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on PR #1152:
URL: https://github.com/apache/incubator-pegasus/pull/1152#issuecomment-1241790420
Some CIs failed, please rebase the master branch, some bugs have been fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan merged pull request #1152: feat: make java client interface closable
Posted by GitBox <gi...@apache.org>.
empiredan merged PR #1152:
URL: https://github.com/apache/incubator-pegasus/pull/1152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org