[GitHub] [incubator-druid] leventov commented on a change in pull request #8129: Spotbugs: NP_NONNULL_PARAM_VIOLATION

[GitBox <gi...@apache.org>]

leventov commented on a change in pull request #8129: Spotbugs: NP_NONNULL_PARAM_VIOLATION
URL: https://github.com/apache/incubator-druid/pull/8129#discussion_r308835591
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/query/groupby/strategy/GroupByStrategyV2.java
 ##########
 @@ -450,18 +450,17 @@ public Row apply(final Row row)
                 );
               }
             }, subtotalQuery, null),
-            subtotalQuery
-                             )
+            subtotalQuery)
 
 Review comment:
   This method call is formatted improperly. It should be
   ```java
   results = mergeResults(
       new QueryRunner<Row>()
       {
           @Override
           public Sequence<Row> run(QueryPlus<Row> queryPlus, ResponseContext responseContext)
           {
             return GroupByRowProcessor.getRowsFromGrouper(query, null, grouperSupplier);
           }
       },
       subtotalQuery,
       null
   );
   subtotalsResults.add(applyPostProcessing(results, subtotalQuery));
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org