You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by keval bhatt <kb...@apache.org> on 2018/03/13 13:44:50 UTC

Review Request 66040: Relationship UI improvements

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66040/
-----------------------------------------------------------

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.


Bugs: ATLAS-2497
    https://issues.apache.org/jira/browse/ATLAS-2497


Repository: atlas


Description
-------

This patch includes following changes to atlas UI.

* Zoom-In/Zoom-Out on relationship graph is available through mouse scroll and buttons.
* Move the circles for related objects. Moving to the anchor entity circle can be used to move the entire graph.
* Relationship details popup that lists the related objects:
    - it will be useful to number each item, instead of a bullet
    - ‘Search Entities’ search box should be hidden when there is only one entity
* From ‘CLASSIFICATION’ tab, clicking on a tag – like ‘PII’. On the result page at the right-side, click on an entity to see its details :
      - the left-side switches to ‘SEARCH’ tab (instead of remaining in ‘CLASSIFICATION’ tab).
      - If the user clicks on "back to result" button it should come back to classification tab.


Diffs
-----

  dashboardv2/public/css/scss/relationship.scss 91ad8f77 
  dashboardv2/public/js/templates/graph/RelationshipLayoutView_tmpl.html a0e5b976 
  dashboardv2/public/js/templates/tag/TagAttributeDetailLayoutView_tmpl.html 32fc7288 
  dashboardv2/public/js/views/graph/RelationshipLayoutView.js a26a64ad 
  dashboardv2/public/js/views/search/SearchResultLayoutView.js 28d11243 
  dashboardv2/public/js/views/site/Header.js 8b75b1a9 
  dashboardv2/public/js/views/site/SideNavLayoutView.js 76489071 
  dashboardv2/public/js/views/tag/TagDetailLayoutView.js e5087c07 


Diff: https://reviews.apache.org/r/66040/diff/1/


Testing
-------

Done one round of sanity testing


Thanks,

keval bhatt

Re: Review Request 66040: Relationship UI improvements

Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66040/#review199086
-----------------------------------------------------------


Ship it!




Ship It!

- Nixon Rodrigues


On March 13, 2018, 1:44 p.m., keval bhatt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66040/
> -----------------------------------------------------------
> 
> (Updated March 13, 2018, 1:44 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2497
>     https://issues.apache.org/jira/browse/ATLAS-2497
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch includes following changes to atlas UI.
> 
> * Zoom-In/Zoom-Out on relationship graph is available through mouse scroll and buttons.
> * Move the circles for related objects. Moving to the anchor entity circle can be used to move the entire graph.
> * Relationship details popup that lists the related objects:
>     - it will be useful to number each item, instead of a bullet
>     - ‘Search Entities’ search box should be hidden when there is only one entity
> * From ‘CLASSIFICATION’ tab, clicking on a tag – like ‘PII’. On the result page at the right-side, click on an entity to see its details :
>       - the left-side switches to ‘SEARCH’ tab (instead of remaining in ‘CLASSIFICATION’ tab).
>       - If the user clicks on "back to result" button it should come back to classification tab.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/css/scss/relationship.scss 91ad8f77 
>   dashboardv2/public/js/templates/graph/RelationshipLayoutView_tmpl.html a0e5b976 
>   dashboardv2/public/js/templates/tag/TagAttributeDetailLayoutView_tmpl.html 32fc7288 
>   dashboardv2/public/js/views/graph/RelationshipLayoutView.js a26a64ad 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js 28d11243 
>   dashboardv2/public/js/views/site/Header.js 8b75b1a9 
>   dashboardv2/public/js/views/site/SideNavLayoutView.js 76489071 
>   dashboardv2/public/js/views/tag/TagDetailLayoutView.js e5087c07 
> 
> 
> Diff: https://reviews.apache.org/r/66040/diff/1/
> 
> 
> Testing
> -------
> 
> Done one round of sanity testing
> 
> 
> Thanks,
> 
> keval bhatt
> 
>

Re: Review Request 66040: Relationship UI improvements

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66040/#review199088
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On March 13, 2018, 1:44 p.m., keval bhatt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66040/
> -----------------------------------------------------------
> 
> (Updated March 13, 2018, 1:44 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2497
>     https://issues.apache.org/jira/browse/ATLAS-2497
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch includes following changes to atlas UI.
> 
> * Zoom-In/Zoom-Out on relationship graph is available through mouse scroll and buttons.
> * Move the circles for related objects. Moving to the anchor entity circle can be used to move the entire graph.
> * Relationship details popup that lists the related objects:
>     - it will be useful to number each item, instead of a bullet
>     - ‘Search Entities’ search box should be hidden when there is only one entity
> * From ‘CLASSIFICATION’ tab, clicking on a tag – like ‘PII’. On the result page at the right-side, click on an entity to see its details :
>       - the left-side switches to ‘SEARCH’ tab (instead of remaining in ‘CLASSIFICATION’ tab).
>       - If the user clicks on "back to result" button it should come back to classification tab.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/css/scss/relationship.scss 91ad8f77 
>   dashboardv2/public/js/templates/graph/RelationshipLayoutView_tmpl.html a0e5b976 
>   dashboardv2/public/js/templates/tag/TagAttributeDetailLayoutView_tmpl.html 32fc7288 
>   dashboardv2/public/js/views/graph/RelationshipLayoutView.js a26a64ad 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js 28d11243 
>   dashboardv2/public/js/views/site/Header.js 8b75b1a9 
>   dashboardv2/public/js/views/site/SideNavLayoutView.js 76489071 
>   dashboardv2/public/js/views/tag/TagDetailLayoutView.js e5087c07 
> 
> 
> Diff: https://reviews.apache.org/r/66040/diff/1/
> 
> 
> Testing
> -------
> 
> Done one round of sanity testing
> 
> 
> Thanks,
> 
> keval bhatt
> 
>