You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/06/01 00:44:02 UTC

[GitHub] [hudi] wangxianghu edited a comment on pull request #2993: [HUDI-1929] Make HoodieDeltaStreamer support configure KeyGenerator by type

wangxianghu edited a comment on pull request #2993:
URL: https://github.com/apache/hudi/pull/2993#issuecomment-851517633


   > guess we need to fix quite a few more places.
   > https://github.com/apache/hudi/blob/e6a71ea544f3dd1ab5227b4c89a1540df5f7891a/hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala#L213
   > 
   > https://github.com/apache/hudi/blob/e6a71ea544f3dd1ab5227b4c89a1540df5f7891a/hudi-spark-datasource/hudi-spark-common/src/main/java/org/apache/hudi/DataSourceUtils.java#L90
   > 
   > Also, I see you have added a keygen factory for spark. what's the plan for Flink ?
   
   Currently, flink and java engine shares key generator, so I plan to add a factory in `hudi-client-common` to support both of them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org