Re: ChangeLog + revert, broken [2] ?

[Emmanuel Lecharny <el...@apache.org>]

So more info :

when you do something like :

tag
  op0
tag
  op1
tag
tag
  op2

only one tga is created. So when reverting twice (as I did, expecting
to have an noop revert, and be back to op1), it move backward to op0,
as if the stack was :

tag
  op0
tag
  op1
tag
  op2

Shouldn't we 'name' the tags instead of using the operation number ?
ie, having something like :

tag-0
  op0
tag-1
  op1
tag-2
tag-3
  op2

so that the first 'revert' reverts tag-3, and the second 'revert'
reverts back to tag-2, leaving op1 available.

wdyt ?

-- 
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com

Re: ChangeLog + revert, broken [2] ?

[Emmanuel Lecharny <el...@apache.org>]

On Fri, Feb 13, 2009 at 2:02 PM, Alex Karasulu <ak...@gmail.com> wrote:
> Oooohhhh OK.  Why would you do two tags with the same revision?

Just because between two tests from two different classes, I have no
idea if the previous test has modified some data or not, and so for
the previous class. I may have to revert theprevious method changes
and also the previously tested class.

-- 
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com

Re: ChangeLog + revert, broken [2] ?

[Alex Karasulu <ak...@gmail.com>]

Oooohhhh OK.  Why would you do two tags with the same revision?

On Wed, Feb 11, 2009 at 1:44 AM, Emmanuel Lecharny <el...@apache.org>wrote:

> On Wed, Feb 11, 2009 at 1:02 AM, Alex Karasulu <ak...@gmail.com>
> wrote:
> > A tag has a revision associated with it. I thought this was already in
> the
> > Tag class.
>
> Yes, but you can't put two tags with the same revision. And this is
> exactly what I'm trying to do.
>
> --
> Regards,
> Cordialement,
> Emmanuel Lécharny
> www.iktek.com
>

Re: ChangeLog + revert, broken [2] ?

[Emmanuel Lecharny <el...@apache.org>]

On Wed, Feb 11, 2009 at 1:02 AM, Alex Karasulu <ak...@gmail.com> wrote:
> A tag has a revision associated with it. I thought this was already in the
> Tag class.

Yes, but you can't put two tags with the same revision. And this is
exactly what I'm trying to do.

-- 
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com

Re: ChangeLog + revert, broken [2] ?

[Alex Karasulu <ak...@gmail.com>]

A tag has a revision associated with it. I thought this was already in the
Tag class.

Alex

On Tue, Feb 10, 2009 at 12:39 PM, Emmanuel Lecharny <el...@apache.org>wrote:

> Here, I think we should modify the tag to store an identifier.
>
> Let's use an example :
>
> We start with a blank server, revision = 0, no tag.
>
> op : r1
> op : r2
> Tag[ t1, r2] : I have created a first tag, which store the current
> revision, r2
> op : r3
> op : r4
> Tag[t2, r4] : I created a new tag, holding r4
> Tag[t3, r4] : another tag, with another name, but holding the same
> revision number
> op : r5 : the current revision is now r5
> revert -> now, the revert play !op, and go back to revision r4,
> removing the tag t3
> revert -> we remove the t3 tag, but as teh current revision has
> already been restored to r4, we don't do anything else.
>
>
> It should work, it's just a matter of adding some extra info in the Tag
> class.
>
> I will try that.
>
> --
> Regards,
> Cordialement,
> Emmanuel Lécharny
> www.iktek.com
>

Re: ChangeLog + revert, broken [2] ?

[Emmanuel Lecharny <el...@apache.org>]

Here, I think we should modify the tag to store an identifier.

Let's use an example :

We start with a blank server, revision = 0, no tag.

op : r1
op : r2
Tag[ t1, r2] : I have created a first tag, which store the current revision, r2
op : r3
op : r4
Tag[t2, r4] : I created a new tag, holding r4
Tag[t3, r4] : another tag, with another name, but holding the same
revision number
op : r5 : the current revision is now r5
revert -> now, the revert play !op, and go back to revision r4,
removing the tag t3
revert -> we remove the t3 tag, but as teh current revision has
already been restored to r4, we don't do anything else.


It should work, it's just a matter of adding some extra info in the Tag class.

I will try that.

-- 
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com

Re: ChangeLog + revert, broken [2] ?

[Emmanuel Lecharny <el...@apache.org>]

On Tue, Feb 10, 2009 at 5:19 PM, Kiran Ayyagari <ay...@gmail.com> wrote:
>
> hi Emmanuel,
>
> what I understood from the below mail is that the tag is also treated as a
> event but
> AFAIK, tagging is not considered as a event in CL.

Tag is using the revision number. As this revision number is
associated with a change, you can't put two different tags when no
modifictaion has been made, which is the problem I have.

-- 
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com

Re: ChangeLog + revert, broken [2] ?

[Kiran Ayyagari <ay...@gmail.com>]

hi Emmanuel,

what I understood from the below mail is that the tag is also treated as a event but
AFAIK, tagging is not considered as a event in CL.

Kiran Ayyagari

Emmanuel Lecharny wrote:
-- 
Kiran Ayyagari> So more info :
> 
> when you do something like :
> 
> tag
>   op0
> tag
>   op1
> tag
> tag
>   op2
> 
> only one tga is created. So when reverting twice (as I did, expecting
> to have an noop revert, and be back to op1), it move backward to op0,
> as if the stack was :
> 
> tag
>   op0
> tag
>   op1
> tag
>   op2
> 
> Shouldn't we 'name' the tags instead of using the operation number ?
> ie, having something like :
> 
> tag-0
>   op0
> tag-1
>   op1
> tag-2
> tag-3
>   op2
> 
> so that the first 'revert' reverts tag-3, and the second 'revert'
> reverts back to tag-2, leaving op1 available.
> 
> wdyt ?
>