You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by Tom White <to...@cloudera.com> on 2015/07/01 15:25:00 UTC
Next Avro release
Hi everyone,
It would be good to do another Avro release soon. I'm happy to create
a release candidate so we can vote on it.
What do folks think about releasing 1.7.8 vs. 1.8.0? There are very
few changes in the 1.7 branch, so it might be best to release 1.8.0
from trunk. There have been enough changes to justify a new minor
release I think. Are there any drawbacks to doing that?
The unresolved 1.8.0 issues are here:
http://s.apache.org/Cdt
And the unresolved 1.7.8 issues are here:
http://s.apache.org/5ShO
Thanks,
Tom
Re: Next Avro release
Posted by Marcin Białoń <ma...@bialon.net>.
Hi,
Could you please review the patch for AVRO-1673?
Thanks,
Marcin
On Tue, Jul 7, 2015, at 15:41, Tom White wrote:
> Committers - please take a look at the outstanding patch available
> JIRAs for 1.7.8/1.8.0 and review and commit any that you'd like to see
> in 1.8.0:
>
> http://s.apache.org/xXz
>
> Thanks!
> Tom
>
> On Tue, Jul 7, 2015 at 2:34 PM, Tom White <to...@cloudera.com> wrote:
> > Thanks Niels. Comments inline.
> >
> > On Wed, Jul 1, 2015 at 3:50 PM, Niels Basjes <Ni...@basjes.nl> wrote:
> >> Hi,
> >>
> >> I would say go for the 1.8.0
> >>
> >> Note that there are a few issues that seem appropriate to include for
> >> this one because they relate to a change in 'backwards compatibility":
> >>
> >> - AVRO-1586 Build against Hadoop 2
> >> ( which should also fix AVRO-1453 Release version of avro-tools
> >> compiled against hadoop2 )
> >> - AVRO-1559 Drop support for Ruby 1.8
> >
> > I've committed both of these now.
> >
> >>
> >> On a personal note I would like a 'Yes, commit' / 'No, won't fix'
> >> choice from you guys regarding this proposal (Patch included):
> >> AVRO-1633 Add additional setXxx(Builder) method to make user code
> >> more readable.
> >
> > I think this is a "won't fix" as it doesn't seem to produce any real
> > increase in readability and could actually be confusing.
> >
> > Thanks,
> > Tom
> >
> >>
> >> Niels Basjes
> >>
> >> On Wed, Jul 1, 2015 at 3:25 PM, Tom White <to...@cloudera.com> wrote:
> >>> Hi everyone,
> >>>
> >>> It would be good to do another Avro release soon. I'm happy to create
> >>> a release candidate so we can vote on it.
> >>>
> >>> What do folks think about releasing 1.7.8 vs. 1.8.0? There are very
> >>> few changes in the 1.7 branch, so it might be best to release 1.8.0
> >>> from trunk. There have been enough changes to justify a new minor
> >>> release I think. Are there any drawbacks to doing that?
> >>>
> >>> The unresolved 1.8.0 issues are here:
> >>>
> >>> http://s.apache.org/Cdt
> >>>
> >>> And the unresolved 1.7.8 issues are here:
> >>>
> >>> http://s.apache.org/5ShO
> >>>
> >>> Thanks,
> >>> Tom
> >>
> >>
> >>
> >> --
> >> Best regards / Met vriendelijke groeten,
> >>
> >> Niels Basjes
Re: Next Avro release
Posted by Niels Basjes <Ni...@basjes.nl>.
I did a similar fight with forrest a few weeks ago trying to get pig to
build in docker.
See https://issues.apache.org/jira/browse/PIG-4526 for the current draft of
that.
In this case it turned out to be a case where Forrest 0.8 would fail with
strange errors when ran under a "new" jvm.
Where "new" is java 6 or newer...
Niels
On Sat, 18 Jul 2015 11:14 Tom White <to...@cloudera.com> wrote:
> Quick update: after spending way too much time fighting Forrest I've
> managed to get the full build working on Docker to the point where all
> tests pass and all artifacts are created and signed. (If you're
> interested you can try it out by typing './build.sh docker', then
> './build.sh clean dist' in the Docker container.)
>
> I had hoped to roll a release this week, and I'm travelling for the
> next two weeks so it will probably have to wait until I'm back.
>
> Cheers,
> Tom
>
> On Thu, Jul 9, 2015 at 4:13 PM, Tom White <to...@cloudera.com> wrote:
> > I committed the Ruby fixes that Sean reviewed, and I've looked at
> > Marcin's patch. Is anyone familiar with the C implementation able to
> > take a look at Thomas' patch?
> >
> > Thanks,
> > Tom
> >
> > On Thu, Jul 9, 2015 at 9:30 AM, Thomas Sanchez <th...@gmail.com>
> wrote:
> >> Hi,
> >> Sorry to bust in, but if one could take a final look at AVRO-1663, I'd
> >> appreciate.
> >> It is a minor fix.
> >>
> >> Thanks,
> >>
> >> 2015-07-07 17:16 GMT+02:00 Sean Busbey <bu...@cloudera.com>:
> >>> I have done non-binding reviews on the following, if a committer could
> take
> >>> look:
> >>>
> >>> * AVRO-1645
> >>> * AVRO-1693
> >>>
> >>> On Tue, Jul 7, 2015 at 8:41 AM, Tom White <to...@cloudera.com> wrote:
> >>>
> >>>> Committers - please take a look at the outstanding patch available
> >>>> JIRAs for 1.7.8/1.8.0 and review and commit any that you'd like to see
> >>>> in 1.8.0:
> >>>>
> >>>> http://s.apache.org/xXz
> >>>>
> >>>> Thanks!
> >>>> Tom
> >>>>
> >>>> On Tue, Jul 7, 2015 at 2:34 PM, Tom White <to...@cloudera.com> wrote:
> >>>> > Thanks Niels. Comments inline.
> >>>> >
> >>>> > On Wed, Jul 1, 2015 at 3:50 PM, Niels Basjes <Ni...@basjes.nl>
> wrote:
> >>>> >> Hi,
> >>>> >>
> >>>> >> I would say go for the 1.8.0
> >>>> >>
> >>>> >> Note that there are a few issues that seem appropriate to include
> for
> >>>> >> this one because they relate to a change in 'backwards
> compatibility":
> >>>> >>
> >>>> >> - AVRO-1586 Build against Hadoop 2
> >>>> >> ( which should also fix AVRO-1453 Release version of avro-tools
> >>>> >> compiled against hadoop2 )
> >>>> >> - AVRO-1559 Drop support for Ruby 1.8
> >>>> >
> >>>> > I've committed both of these now.
> >>>> >
> >>>> >>
> >>>> >> On a personal note I would like a 'Yes, commit' / 'No, won't fix'
> >>>> >> choice from you guys regarding this proposal (Patch included):
> >>>> >> AVRO-1633 Add additional setXxx(Builder) method to make user
> code
> >>>> >> more readable.
> >>>> >
> >>>> > I think this is a "won't fix" as it doesn't seem to produce any real
> >>>> > increase in readability and could actually be confusing.
> >>>> >
> >>>> > Thanks,
> >>>> > Tom
> >>>> >
> >>>> >>
> >>>> >> Niels Basjes
> >>>> >>
> >>>> >> On Wed, Jul 1, 2015 at 3:25 PM, Tom White <to...@cloudera.com>
> wrote:
> >>>> >>> Hi everyone,
> >>>> >>>
> >>>> >>> It would be good to do another Avro release soon. I'm happy to
> create
> >>>> >>> a release candidate so we can vote on it.
> >>>> >>>
> >>>> >>> What do folks think about releasing 1.7.8 vs. 1.8.0? There are
> very
> >>>> >>> few changes in the 1.7 branch, so it might be best to release
> 1.8.0
> >>>> >>> from trunk. There have been enough changes to justify a new minor
> >>>> >>> release I think. Are there any drawbacks to doing that?
> >>>> >>>
> >>>> >>> The unresolved 1.8.0 issues are here:
> >>>> >>>
> >>>> >>> http://s.apache.org/Cdt
> >>>> >>>
> >>>> >>> And the unresolved 1.7.8 issues are here:
> >>>> >>>
> >>>> >>> http://s.apache.org/5ShO
> >>>> >>>
> >>>> >>> Thanks,
> >>>> >>> Tom
> >>>> >>
> >>>> >>
> >>>> >>
> >>>> >> --
> >>>> >> Best regards / Met vriendelijke groeten,
> >>>> >>
> >>>> >> Niels Basjes
> >>>>
> >>>
> >>>
> >>>
> >>> --
> >>> Sean
> >>
> >>
> >>
> >> --
> >> Thomas Sanchez
>
Re: Next Avro release
Posted by Tom White <to...@cloudera.com>.
Quick update: after spending way too much time fighting Forrest I've
managed to get the full build working on Docker to the point where all
tests pass and all artifacts are created and signed. (If you're
interested you can try it out by typing './build.sh docker', then
'./build.sh clean dist' in the Docker container.)
I had hoped to roll a release this week, and I'm travelling for the
next two weeks so it will probably have to wait until I'm back.
Cheers,
Tom
On Thu, Jul 9, 2015 at 4:13 PM, Tom White <to...@cloudera.com> wrote:
> I committed the Ruby fixes that Sean reviewed, and I've looked at
> Marcin's patch. Is anyone familiar with the C implementation able to
> take a look at Thomas' patch?
>
> Thanks,
> Tom
>
> On Thu, Jul 9, 2015 at 9:30 AM, Thomas Sanchez <th...@gmail.com> wrote:
>> Hi,
>> Sorry to bust in, but if one could take a final look at AVRO-1663, I'd
>> appreciate.
>> It is a minor fix.
>>
>> Thanks,
>>
>> 2015-07-07 17:16 GMT+02:00 Sean Busbey <bu...@cloudera.com>:
>>> I have done non-binding reviews on the following, if a committer could take
>>> look:
>>>
>>> * AVRO-1645
>>> * AVRO-1693
>>>
>>> On Tue, Jul 7, 2015 at 8:41 AM, Tom White <to...@cloudera.com> wrote:
>>>
>>>> Committers - please take a look at the outstanding patch available
>>>> JIRAs for 1.7.8/1.8.0 and review and commit any that you'd like to see
>>>> in 1.8.0:
>>>>
>>>> http://s.apache.org/xXz
>>>>
>>>> Thanks!
>>>> Tom
>>>>
>>>> On Tue, Jul 7, 2015 at 2:34 PM, Tom White <to...@cloudera.com> wrote:
>>>> > Thanks Niels. Comments inline.
>>>> >
>>>> > On Wed, Jul 1, 2015 at 3:50 PM, Niels Basjes <Ni...@basjes.nl> wrote:
>>>> >> Hi,
>>>> >>
>>>> >> I would say go for the 1.8.0
>>>> >>
>>>> >> Note that there are a few issues that seem appropriate to include for
>>>> >> this one because they relate to a change in 'backwards compatibility":
>>>> >>
>>>> >> - AVRO-1586 Build against Hadoop 2
>>>> >> ( which should also fix AVRO-1453 Release version of avro-tools
>>>> >> compiled against hadoop2 )
>>>> >> - AVRO-1559 Drop support for Ruby 1.8
>>>> >
>>>> > I've committed both of these now.
>>>> >
>>>> >>
>>>> >> On a personal note I would like a 'Yes, commit' / 'No, won't fix'
>>>> >> choice from you guys regarding this proposal (Patch included):
>>>> >> AVRO-1633 Add additional setXxx(Builder) method to make user code
>>>> >> more readable.
>>>> >
>>>> > I think this is a "won't fix" as it doesn't seem to produce any real
>>>> > increase in readability and could actually be confusing.
>>>> >
>>>> > Thanks,
>>>> > Tom
>>>> >
>>>> >>
>>>> >> Niels Basjes
>>>> >>
>>>> >> On Wed, Jul 1, 2015 at 3:25 PM, Tom White <to...@cloudera.com> wrote:
>>>> >>> Hi everyone,
>>>> >>>
>>>> >>> It would be good to do another Avro release soon. I'm happy to create
>>>> >>> a release candidate so we can vote on it.
>>>> >>>
>>>> >>> What do folks think about releasing 1.7.8 vs. 1.8.0? There are very
>>>> >>> few changes in the 1.7 branch, so it might be best to release 1.8.0
>>>> >>> from trunk. There have been enough changes to justify a new minor
>>>> >>> release I think. Are there any drawbacks to doing that?
>>>> >>>
>>>> >>> The unresolved 1.8.0 issues are here:
>>>> >>>
>>>> >>> http://s.apache.org/Cdt
>>>> >>>
>>>> >>> And the unresolved 1.7.8 issues are here:
>>>> >>>
>>>> >>> http://s.apache.org/5ShO
>>>> >>>
>>>> >>> Thanks,
>>>> >>> Tom
>>>> >>
>>>> >>
>>>> >>
>>>> >> --
>>>> >> Best regards / Met vriendelijke groeten,
>>>> >>
>>>> >> Niels Basjes
>>>>
>>>
>>>
>>>
>>> --
>>> Sean
>>
>>
>>
>> --
>> Thomas Sanchez
Re: Next Avro release
Posted by Tom White <to...@cloudera.com>.
I committed the Ruby fixes that Sean reviewed, and I've looked at
Marcin's patch. Is anyone familiar with the C implementation able to
take a look at Thomas' patch?
Thanks,
Tom
On Thu, Jul 9, 2015 at 9:30 AM, Thomas Sanchez <th...@gmail.com> wrote:
> Hi,
> Sorry to bust in, but if one could take a final look at AVRO-1663, I'd
> appreciate.
> It is a minor fix.
>
> Thanks,
>
> 2015-07-07 17:16 GMT+02:00 Sean Busbey <bu...@cloudera.com>:
>> I have done non-binding reviews on the following, if a committer could take
>> look:
>>
>> * AVRO-1645
>> * AVRO-1693
>>
>> On Tue, Jul 7, 2015 at 8:41 AM, Tom White <to...@cloudera.com> wrote:
>>
>>> Committers - please take a look at the outstanding patch available
>>> JIRAs for 1.7.8/1.8.0 and review and commit any that you'd like to see
>>> in 1.8.0:
>>>
>>> http://s.apache.org/xXz
>>>
>>> Thanks!
>>> Tom
>>>
>>> On Tue, Jul 7, 2015 at 2:34 PM, Tom White <to...@cloudera.com> wrote:
>>> > Thanks Niels. Comments inline.
>>> >
>>> > On Wed, Jul 1, 2015 at 3:50 PM, Niels Basjes <Ni...@basjes.nl> wrote:
>>> >> Hi,
>>> >>
>>> >> I would say go for the 1.8.0
>>> >>
>>> >> Note that there are a few issues that seem appropriate to include for
>>> >> this one because they relate to a change in 'backwards compatibility":
>>> >>
>>> >> - AVRO-1586 Build against Hadoop 2
>>> >> ( which should also fix AVRO-1453 Release version of avro-tools
>>> >> compiled against hadoop2 )
>>> >> - AVRO-1559 Drop support for Ruby 1.8
>>> >
>>> > I've committed both of these now.
>>> >
>>> >>
>>> >> On a personal note I would like a 'Yes, commit' / 'No, won't fix'
>>> >> choice from you guys regarding this proposal (Patch included):
>>> >> AVRO-1633 Add additional setXxx(Builder) method to make user code
>>> >> more readable.
>>> >
>>> > I think this is a "won't fix" as it doesn't seem to produce any real
>>> > increase in readability and could actually be confusing.
>>> >
>>> > Thanks,
>>> > Tom
>>> >
>>> >>
>>> >> Niels Basjes
>>> >>
>>> >> On Wed, Jul 1, 2015 at 3:25 PM, Tom White <to...@cloudera.com> wrote:
>>> >>> Hi everyone,
>>> >>>
>>> >>> It would be good to do another Avro release soon. I'm happy to create
>>> >>> a release candidate so we can vote on it.
>>> >>>
>>> >>> What do folks think about releasing 1.7.8 vs. 1.8.0? There are very
>>> >>> few changes in the 1.7 branch, so it might be best to release 1.8.0
>>> >>> from trunk. There have been enough changes to justify a new minor
>>> >>> release I think. Are there any drawbacks to doing that?
>>> >>>
>>> >>> The unresolved 1.8.0 issues are here:
>>> >>>
>>> >>> http://s.apache.org/Cdt
>>> >>>
>>> >>> And the unresolved 1.7.8 issues are here:
>>> >>>
>>> >>> http://s.apache.org/5ShO
>>> >>>
>>> >>> Thanks,
>>> >>> Tom
>>> >>
>>> >>
>>> >>
>>> >> --
>>> >> Best regards / Met vriendelijke groeten,
>>> >>
>>> >> Niels Basjes
>>>
>>
>>
>>
>> --
>> Sean
>
>
>
> --
> Thomas Sanchez
Re: Next Avro release
Posted by Thomas Sanchez <th...@gmail.com>.
Hi,
Sorry to bust in, but if one could take a final look at AVRO-1663, I'd
appreciate.
It is a minor fix.
Thanks,
2015-07-07 17:16 GMT+02:00 Sean Busbey <bu...@cloudera.com>:
> I have done non-binding reviews on the following, if a committer could take
> look:
>
> * AVRO-1645
> * AVRO-1693
>
> On Tue, Jul 7, 2015 at 8:41 AM, Tom White <to...@cloudera.com> wrote:
>
>> Committers - please take a look at the outstanding patch available
>> JIRAs for 1.7.8/1.8.0 and review and commit any that you'd like to see
>> in 1.8.0:
>>
>> http://s.apache.org/xXz
>>
>> Thanks!
>> Tom
>>
>> On Tue, Jul 7, 2015 at 2:34 PM, Tom White <to...@cloudera.com> wrote:
>> > Thanks Niels. Comments inline.
>> >
>> > On Wed, Jul 1, 2015 at 3:50 PM, Niels Basjes <Ni...@basjes.nl> wrote:
>> >> Hi,
>> >>
>> >> I would say go for the 1.8.0
>> >>
>> >> Note that there are a few issues that seem appropriate to include for
>> >> this one because they relate to a change in 'backwards compatibility":
>> >>
>> >> - AVRO-1586 Build against Hadoop 2
>> >> ( which should also fix AVRO-1453 Release version of avro-tools
>> >> compiled against hadoop2 )
>> >> - AVRO-1559 Drop support for Ruby 1.8
>> >
>> > I've committed both of these now.
>> >
>> >>
>> >> On a personal note I would like a 'Yes, commit' / 'No, won't fix'
>> >> choice from you guys regarding this proposal (Patch included):
>> >> AVRO-1633 Add additional setXxx(Builder) method to make user code
>> >> more readable.
>> >
>> > I think this is a "won't fix" as it doesn't seem to produce any real
>> > increase in readability and could actually be confusing.
>> >
>> > Thanks,
>> > Tom
>> >
>> >>
>> >> Niels Basjes
>> >>
>> >> On Wed, Jul 1, 2015 at 3:25 PM, Tom White <to...@cloudera.com> wrote:
>> >>> Hi everyone,
>> >>>
>> >>> It would be good to do another Avro release soon. I'm happy to create
>> >>> a release candidate so we can vote on it.
>> >>>
>> >>> What do folks think about releasing 1.7.8 vs. 1.8.0? There are very
>> >>> few changes in the 1.7 branch, so it might be best to release 1.8.0
>> >>> from trunk. There have been enough changes to justify a new minor
>> >>> release I think. Are there any drawbacks to doing that?
>> >>>
>> >>> The unresolved 1.8.0 issues are here:
>> >>>
>> >>> http://s.apache.org/Cdt
>> >>>
>> >>> And the unresolved 1.7.8 issues are here:
>> >>>
>> >>> http://s.apache.org/5ShO
>> >>>
>> >>> Thanks,
>> >>> Tom
>> >>
>> >>
>> >>
>> >> --
>> >> Best regards / Met vriendelijke groeten,
>> >>
>> >> Niels Basjes
>>
>
>
>
> --
> Sean
--
Thomas Sanchez
Re: Next Avro release
Posted by Sean Busbey <bu...@cloudera.com>.
I have done non-binding reviews on the following, if a committer could take
look:
* AVRO-1645
* AVRO-1693
On Tue, Jul 7, 2015 at 8:41 AM, Tom White <to...@cloudera.com> wrote:
> Committers - please take a look at the outstanding patch available
> JIRAs for 1.7.8/1.8.0 and review and commit any that you'd like to see
> in 1.8.0:
>
> http://s.apache.org/xXz
>
> Thanks!
> Tom
>
> On Tue, Jul 7, 2015 at 2:34 PM, Tom White <to...@cloudera.com> wrote:
> > Thanks Niels. Comments inline.
> >
> > On Wed, Jul 1, 2015 at 3:50 PM, Niels Basjes <Ni...@basjes.nl> wrote:
> >> Hi,
> >>
> >> I would say go for the 1.8.0
> >>
> >> Note that there are a few issues that seem appropriate to include for
> >> this one because they relate to a change in 'backwards compatibility":
> >>
> >> - AVRO-1586 Build against Hadoop 2
> >> ( which should also fix AVRO-1453 Release version of avro-tools
> >> compiled against hadoop2 )
> >> - AVRO-1559 Drop support for Ruby 1.8
> >
> > I've committed both of these now.
> >
> >>
> >> On a personal note I would like a 'Yes, commit' / 'No, won't fix'
> >> choice from you guys regarding this proposal (Patch included):
> >> AVRO-1633 Add additional setXxx(Builder) method to make user code
> >> more readable.
> >
> > I think this is a "won't fix" as it doesn't seem to produce any real
> > increase in readability and could actually be confusing.
> >
> > Thanks,
> > Tom
> >
> >>
> >> Niels Basjes
> >>
> >> On Wed, Jul 1, 2015 at 3:25 PM, Tom White <to...@cloudera.com> wrote:
> >>> Hi everyone,
> >>>
> >>> It would be good to do another Avro release soon. I'm happy to create
> >>> a release candidate so we can vote on it.
> >>>
> >>> What do folks think about releasing 1.7.8 vs. 1.8.0? There are very
> >>> few changes in the 1.7 branch, so it might be best to release 1.8.0
> >>> from trunk. There have been enough changes to justify a new minor
> >>> release I think. Are there any drawbacks to doing that?
> >>>
> >>> The unresolved 1.8.0 issues are here:
> >>>
> >>> http://s.apache.org/Cdt
> >>>
> >>> And the unresolved 1.7.8 issues are here:
> >>>
> >>> http://s.apache.org/5ShO
> >>>
> >>> Thanks,
> >>> Tom
> >>
> >>
> >>
> >> --
> >> Best regards / Met vriendelijke groeten,
> >>
> >> Niels Basjes
>
--
Sean
Re: Next Avro release
Posted by Tom White <to...@cloudera.com>.
Committers - please take a look at the outstanding patch available
JIRAs for 1.7.8/1.8.0 and review and commit any that you'd like to see
in 1.8.0:
http://s.apache.org/xXz
Thanks!
Tom
On Tue, Jul 7, 2015 at 2:34 PM, Tom White <to...@cloudera.com> wrote:
> Thanks Niels. Comments inline.
>
> On Wed, Jul 1, 2015 at 3:50 PM, Niels Basjes <Ni...@basjes.nl> wrote:
>> Hi,
>>
>> I would say go for the 1.8.0
>>
>> Note that there are a few issues that seem appropriate to include for
>> this one because they relate to a change in 'backwards compatibility":
>>
>> - AVRO-1586 Build against Hadoop 2
>> ( which should also fix AVRO-1453 Release version of avro-tools
>> compiled against hadoop2 )
>> - AVRO-1559 Drop support for Ruby 1.8
>
> I've committed both of these now.
>
>>
>> On a personal note I would like a 'Yes, commit' / 'No, won't fix'
>> choice from you guys regarding this proposal (Patch included):
>> AVRO-1633 Add additional setXxx(Builder) method to make user code
>> more readable.
>
> I think this is a "won't fix" as it doesn't seem to produce any real
> increase in readability and could actually be confusing.
>
> Thanks,
> Tom
>
>>
>> Niels Basjes
>>
>> On Wed, Jul 1, 2015 at 3:25 PM, Tom White <to...@cloudera.com> wrote:
>>> Hi everyone,
>>>
>>> It would be good to do another Avro release soon. I'm happy to create
>>> a release candidate so we can vote on it.
>>>
>>> What do folks think about releasing 1.7.8 vs. 1.8.0? There are very
>>> few changes in the 1.7 branch, so it might be best to release 1.8.0
>>> from trunk. There have been enough changes to justify a new minor
>>> release I think. Are there any drawbacks to doing that?
>>>
>>> The unresolved 1.8.0 issues are here:
>>>
>>> http://s.apache.org/Cdt
>>>
>>> And the unresolved 1.7.8 issues are here:
>>>
>>> http://s.apache.org/5ShO
>>>
>>> Thanks,
>>> Tom
>>
>>
>>
>> --
>> Best regards / Met vriendelijke groeten,
>>
>> Niels Basjes
Re: Next Avro release
Posted by Tom White <to...@cloudera.com>.
Thanks Niels. Comments inline.
On Wed, Jul 1, 2015 at 3:50 PM, Niels Basjes <Ni...@basjes.nl> wrote:
> Hi,
>
> I would say go for the 1.8.0
>
> Note that there are a few issues that seem appropriate to include for
> this one because they relate to a change in 'backwards compatibility":
>
> - AVRO-1586 Build against Hadoop 2
> ( which should also fix AVRO-1453 Release version of avro-tools
> compiled against hadoop2 )
> - AVRO-1559 Drop support for Ruby 1.8
I've committed both of these now.
>
> On a personal note I would like a 'Yes, commit' / 'No, won't fix'
> choice from you guys regarding this proposal (Patch included):
> AVRO-1633 Add additional setXxx(Builder) method to make user code
> more readable.
I think this is a "won't fix" as it doesn't seem to produce any real
increase in readability and could actually be confusing.
Thanks,
Tom
>
> Niels Basjes
>
> On Wed, Jul 1, 2015 at 3:25 PM, Tom White <to...@cloudera.com> wrote:
>> Hi everyone,
>>
>> It would be good to do another Avro release soon. I'm happy to create
>> a release candidate so we can vote on it.
>>
>> What do folks think about releasing 1.7.8 vs. 1.8.0? There are very
>> few changes in the 1.7 branch, so it might be best to release 1.8.0
>> from trunk. There have been enough changes to justify a new minor
>> release I think. Are there any drawbacks to doing that?
>>
>> The unresolved 1.8.0 issues are here:
>>
>> http://s.apache.org/Cdt
>>
>> And the unresolved 1.7.8 issues are here:
>>
>> http://s.apache.org/5ShO
>>
>> Thanks,
>> Tom
>
>
>
> --
> Best regards / Met vriendelijke groeten,
>
> Niels Basjes
Re: Next Avro release
Posted by Svante Karlsson <sv...@csi.se>.
I'd like pull request on github #38 (C++) since currently it's not possible
to serialize chars > 127 to json if char is signed
it a oneline patch
/svante
2015-07-06 20:34 GMT+02:00 Ryan Blue <bl...@cloudera.com>:
> +1 for 1.8.0.
>
> I'd like to get the date/time support and one fix to the logical types
> API. The issues are:
>
> * AVRO-1692: Allow multiple logical type representations for a class
> * AVRO-1672: Adds date/time logical types and conversions
> * AVRO-1684: Adds date/time types to Specific
>
> rb
>
>
> On 07/01/2015 02:10 PM, Tom White wrote:
>
>> On Wed, Jul 1, 2015 at 7:13 PM, Sean Busbey <bu...@cloudera.com> wrote:
>>
>>> +1 for a 1.8.0 release. What kind of timeline for the first RC are you
>>> looking at?
>>>
>>
>> In the next week or so. Hopefully we can decide anything else we'd
>> like to include and get it reviewed and committed in that time.
>>
>>
>>> On Wed, Jul 1, 2015 at 10:00 AM, Zoltan Farkas
>>> <zolyfarkas@yahoo.com.invalid
>>>
>>>> wrote:
>>>>
>>>
>>> I would like to have https://issues.apache.org/jira/browse/AVRO-1667 <
>>>> https://issues.apache.org/jira/browse/AVRO-1667> resolved in 1.8.0 if
>>>> possible.
>>>> This issue prevents serializing/deserializing objects with certain
>>>> schemas…
>>>>
>>>> —Z
>>>>
>>>>
>>>> On Jul 1, 2015, at 10:50 AM, Niels Basjes <Ni...@basjes.nl> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> I would say go for the 1.8.0
>>>>>
>>>>> Note that there are a few issues that seem appropriate to include for
>>>>> this one because they relate to a change in 'backwards compatibility":
>>>>>
>>>>> - AVRO-1586 Build against Hadoop 2
>>>>> ( which should also fix AVRO-1453 Release version of avro-tools
>>>>> compiled against hadoop2 )
>>>>> - AVRO-1559 Drop support for Ruby 1.8
>>>>>
>>>>> On a personal note I would like a 'Yes, commit' / 'No, won't fix'
>>>>> choice from you guys regarding this proposal (Patch included):
>>>>> AVRO-1633 Add additional setXxx(Builder) method to make user code
>>>>> more readable.
>>>>>
>>>>> Niels Basjes
>>>>>
>>>>> On Wed, Jul 1, 2015 at 3:25 PM, Tom White <to...@cloudera.com> wrote:
>>>>>
>>>>>> Hi everyone,
>>>>>>
>>>>>> It would be good to do another Avro release soon. I'm happy to create
>>>>>> a release candidate so we can vote on it.
>>>>>>
>>>>>> What do folks think about releasing 1.7.8 vs. 1.8.0? There are very
>>>>>> few changes in the 1.7 branch, so it might be best to release 1.8.0
>>>>>> from trunk. There have been enough changes to justify a new minor
>>>>>> release I think. Are there any drawbacks to doing that?
>>>>>>
>>>>>> The unresolved 1.8.0 issues are here:
>>>>>>
>>>>>> http://s.apache.org/Cdt
>>>>>>
>>>>>> And the unresolved 1.7.8 issues are here:
>>>>>>
>>>>>> http://s.apache.org/5ShO
>>>>>>
>>>>>> Thanks,
>>>>>> Tom
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Best regards / Met vriendelijke groeten,
>>>>>
>>>>> Niels Basjes
>>>>>
>>>>
>>>>
>>>>
>>>
>>> --
>>> Sean
>>>
>>
>
> --
> Ryan Blue
> Software Engineer
> Cloudera, Inc.
>
Re: Next Avro release
Posted by Ryan Blue <bl...@cloudera.com>.
+1 for 1.8.0.
I'd like to get the date/time support and one fix to the logical types
API. The issues are:
* AVRO-1692: Allow multiple logical type representations for a class
* AVRO-1672: Adds date/time logical types and conversions
* AVRO-1684: Adds date/time types to Specific
rb
On 07/01/2015 02:10 PM, Tom White wrote:
> On Wed, Jul 1, 2015 at 7:13 PM, Sean Busbey <bu...@cloudera.com> wrote:
>> +1 for a 1.8.0 release. What kind of timeline for the first RC are you
>> looking at?
>
> In the next week or so. Hopefully we can decide anything else we'd
> like to include and get it reviewed and committed in that time.
>
>>
>> On Wed, Jul 1, 2015 at 10:00 AM, Zoltan Farkas <zolyfarkas@yahoo.com.invalid
>>> wrote:
>>
>>> I would like to have https://issues.apache.org/jira/browse/AVRO-1667 <
>>> https://issues.apache.org/jira/browse/AVRO-1667> resolved in 1.8.0 if
>>> possible.
>>> This issue prevents serializing/deserializing objects with certain schemas…
>>>
>>> —Z
>>>
>>>
>>>> On Jul 1, 2015, at 10:50 AM, Niels Basjes <Ni...@basjes.nl> wrote:
>>>>
>>>> Hi,
>>>>
>>>> I would say go for the 1.8.0
>>>>
>>>> Note that there are a few issues that seem appropriate to include for
>>>> this one because they relate to a change in 'backwards compatibility":
>>>>
>>>> - AVRO-1586 Build against Hadoop 2
>>>> ( which should also fix AVRO-1453 Release version of avro-tools
>>>> compiled against hadoop2 )
>>>> - AVRO-1559 Drop support for Ruby 1.8
>>>>
>>>> On a personal note I would like a 'Yes, commit' / 'No, won't fix'
>>>> choice from you guys regarding this proposal (Patch included):
>>>> AVRO-1633 Add additional setXxx(Builder) method to make user code
>>>> more readable.
>>>>
>>>> Niels Basjes
>>>>
>>>> On Wed, Jul 1, 2015 at 3:25 PM, Tom White <to...@cloudera.com> wrote:
>>>>> Hi everyone,
>>>>>
>>>>> It would be good to do another Avro release soon. I'm happy to create
>>>>> a release candidate so we can vote on it.
>>>>>
>>>>> What do folks think about releasing 1.7.8 vs. 1.8.0? There are very
>>>>> few changes in the 1.7 branch, so it might be best to release 1.8.0
>>>>> from trunk. There have been enough changes to justify a new minor
>>>>> release I think. Are there any drawbacks to doing that?
>>>>>
>>>>> The unresolved 1.8.0 issues are here:
>>>>>
>>>>> http://s.apache.org/Cdt
>>>>>
>>>>> And the unresolved 1.7.8 issues are here:
>>>>>
>>>>> http://s.apache.org/5ShO
>>>>>
>>>>> Thanks,
>>>>> Tom
>>>>
>>>>
>>>>
>>>> --
>>>> Best regards / Met vriendelijke groeten,
>>>>
>>>> Niels Basjes
>>>
>>>
>>
>>
>> --
>> Sean
--
Ryan Blue
Software Engineer
Cloudera, Inc.
Re: Next Avro release
Posted by Tom White <to...@cloudera.com>.
On Wed, Jul 1, 2015 at 7:13 PM, Sean Busbey <bu...@cloudera.com> wrote:
> +1 for a 1.8.0 release. What kind of timeline for the first RC are you
> looking at?
In the next week or so. Hopefully we can decide anything else we'd
like to include and get it reviewed and committed in that time.
>
> On Wed, Jul 1, 2015 at 10:00 AM, Zoltan Farkas <zolyfarkas@yahoo.com.invalid
>> wrote:
>
>> I would like to have https://issues.apache.org/jira/browse/AVRO-1667 <
>> https://issues.apache.org/jira/browse/AVRO-1667> resolved in 1.8.0 if
>> possible.
>> This issue prevents serializing/deserializing objects with certain schemas…
>>
>> —Z
>>
>>
>> > On Jul 1, 2015, at 10:50 AM, Niels Basjes <Ni...@basjes.nl> wrote:
>> >
>> > Hi,
>> >
>> > I would say go for the 1.8.0
>> >
>> > Note that there are a few issues that seem appropriate to include for
>> > this one because they relate to a change in 'backwards compatibility":
>> >
>> > - AVRO-1586 Build against Hadoop 2
>> > ( which should also fix AVRO-1453 Release version of avro-tools
>> > compiled against hadoop2 )
>> > - AVRO-1559 Drop support for Ruby 1.8
>> >
>> > On a personal note I would like a 'Yes, commit' / 'No, won't fix'
>> > choice from you guys regarding this proposal (Patch included):
>> > AVRO-1633 Add additional setXxx(Builder) method to make user code
>> > more readable.
>> >
>> > Niels Basjes
>> >
>> > On Wed, Jul 1, 2015 at 3:25 PM, Tom White <to...@cloudera.com> wrote:
>> >> Hi everyone,
>> >>
>> >> It would be good to do another Avro release soon. I'm happy to create
>> >> a release candidate so we can vote on it.
>> >>
>> >> What do folks think about releasing 1.7.8 vs. 1.8.0? There are very
>> >> few changes in the 1.7 branch, so it might be best to release 1.8.0
>> >> from trunk. There have been enough changes to justify a new minor
>> >> release I think. Are there any drawbacks to doing that?
>> >>
>> >> The unresolved 1.8.0 issues are here:
>> >>
>> >> http://s.apache.org/Cdt
>> >>
>> >> And the unresolved 1.7.8 issues are here:
>> >>
>> >> http://s.apache.org/5ShO
>> >>
>> >> Thanks,
>> >> Tom
>> >
>> >
>> >
>> > --
>> > Best regards / Met vriendelijke groeten,
>> >
>> > Niels Basjes
>>
>>
>
>
> --
> Sean
Re: Next Avro release
Posted by Sean Busbey <bu...@cloudera.com>.
+1 for a 1.8.0 release. What kind of timeline for the first RC are you
looking at?
On Wed, Jul 1, 2015 at 10:00 AM, Zoltan Farkas <zolyfarkas@yahoo.com.invalid
> wrote:
> I would like to have https://issues.apache.org/jira/browse/AVRO-1667 <
> https://issues.apache.org/jira/browse/AVRO-1667> resolved in 1.8.0 if
> possible.
> This issue prevents serializing/deserializing objects with certain schemas…
>
> —Z
>
>
> > On Jul 1, 2015, at 10:50 AM, Niels Basjes <Ni...@basjes.nl> wrote:
> >
> > Hi,
> >
> > I would say go for the 1.8.0
> >
> > Note that there are a few issues that seem appropriate to include for
> > this one because they relate to a change in 'backwards compatibility":
> >
> > - AVRO-1586 Build against Hadoop 2
> > ( which should also fix AVRO-1453 Release version of avro-tools
> > compiled against hadoop2 )
> > - AVRO-1559 Drop support for Ruby 1.8
> >
> > On a personal note I would like a 'Yes, commit' / 'No, won't fix'
> > choice from you guys regarding this proposal (Patch included):
> > AVRO-1633 Add additional setXxx(Builder) method to make user code
> > more readable.
> >
> > Niels Basjes
> >
> > On Wed, Jul 1, 2015 at 3:25 PM, Tom White <to...@cloudera.com> wrote:
> >> Hi everyone,
> >>
> >> It would be good to do another Avro release soon. I'm happy to create
> >> a release candidate so we can vote on it.
> >>
> >> What do folks think about releasing 1.7.8 vs. 1.8.0? There are very
> >> few changes in the 1.7 branch, so it might be best to release 1.8.0
> >> from trunk. There have been enough changes to justify a new minor
> >> release I think. Are there any drawbacks to doing that?
> >>
> >> The unresolved 1.8.0 issues are here:
> >>
> >> http://s.apache.org/Cdt
> >>
> >> And the unresolved 1.7.8 issues are here:
> >>
> >> http://s.apache.org/5ShO
> >>
> >> Thanks,
> >> Tom
> >
> >
> >
> > --
> > Best regards / Met vriendelijke groeten,
> >
> > Niels Basjes
>
>
--
Sean
Re: Next Avro release
Posted by Zoltan Farkas <zo...@yahoo.com.INVALID>.
I would like to have https://issues.apache.org/jira/browse/AVRO-1667 <https://issues.apache.org/jira/browse/AVRO-1667> resolved in 1.8.0 if possible.
This issue prevents serializing/deserializing objects with certain schemas…
—Z
> On Jul 1, 2015, at 10:50 AM, Niels Basjes <Ni...@basjes.nl> wrote:
>
> Hi,
>
> I would say go for the 1.8.0
>
> Note that there are a few issues that seem appropriate to include for
> this one because they relate to a change in 'backwards compatibility":
>
> - AVRO-1586 Build against Hadoop 2
> ( which should also fix AVRO-1453 Release version of avro-tools
> compiled against hadoop2 )
> - AVRO-1559 Drop support for Ruby 1.8
>
> On a personal note I would like a 'Yes, commit' / 'No, won't fix'
> choice from you guys regarding this proposal (Patch included):
> AVRO-1633 Add additional setXxx(Builder) method to make user code
> more readable.
>
> Niels Basjes
>
> On Wed, Jul 1, 2015 at 3:25 PM, Tom White <to...@cloudera.com> wrote:
>> Hi everyone,
>>
>> It would be good to do another Avro release soon. I'm happy to create
>> a release candidate so we can vote on it.
>>
>> What do folks think about releasing 1.7.8 vs. 1.8.0? There are very
>> few changes in the 1.7 branch, so it might be best to release 1.8.0
>> from trunk. There have been enough changes to justify a new minor
>> release I think. Are there any drawbacks to doing that?
>>
>> The unresolved 1.8.0 issues are here:
>>
>> http://s.apache.org/Cdt
>>
>> And the unresolved 1.7.8 issues are here:
>>
>> http://s.apache.org/5ShO
>>
>> Thanks,
>> Tom
>
>
>
> --
> Best regards / Met vriendelijke groeten,
>
> Niels Basjes
Re: Next Avro release
Posted by Niels Basjes <Ni...@basjes.nl>.
Hi,
I would say go for the 1.8.0
Note that there are a few issues that seem appropriate to include for
this one because they relate to a change in 'backwards compatibility":
- AVRO-1586 Build against Hadoop 2
( which should also fix AVRO-1453 Release version of avro-tools
compiled against hadoop2 )
- AVRO-1559 Drop support for Ruby 1.8
On a personal note I would like a 'Yes, commit' / 'No, won't fix'
choice from you guys regarding this proposal (Patch included):
AVRO-1633 Add additional setXxx(Builder) method to make user code
more readable.
Niels Basjes
On Wed, Jul 1, 2015 at 3:25 PM, Tom White <to...@cloudera.com> wrote:
> Hi everyone,
>
> It would be good to do another Avro release soon. I'm happy to create
> a release candidate so we can vote on it.
>
> What do folks think about releasing 1.7.8 vs. 1.8.0? There are very
> few changes in the 1.7 branch, so it might be best to release 1.8.0
> from trunk. There have been enough changes to justify a new minor
> release I think. Are there any drawbacks to doing that?
>
> The unresolved 1.8.0 issues are here:
>
> http://s.apache.org/Cdt
>
> And the unresolved 1.7.8 issues are here:
>
> http://s.apache.org/5ShO
>
> Thanks,
> Tom
--
Best regards / Met vriendelijke groeten,
Niels Basjes