[GitHub] maoling commented on issue #624: ZOOKEEPER-3108:use a new property:myid in the zoo.cfg to substitute for myid file under the dataDir

[GitBox <gi...@apache.org>]

maoling commented on issue #624: ZOOKEEPER-3108:use a new property:myid in the zoo.cfg to substitute for myid file under the dataDir
URL: https://github.com/apache/zookeeper/pull/624#issuecomment-458091370
 
 
   ping @lvfangmin 
   >  If I read the patch correctly, seems it will be treated as dynamic config, and the server.id in dynamic config won't be read in the next startup.
   
   Yep,you're right. `server.` is a keyword for `reconfiguration.`To avoid do ugly logic like this: 
   `if (key.startsWith("server.") && !key.startsWith("server.id"))`.
       I change the property name from` server.id` to `myid,`so no UTs are needed to be added in the `ReconfigTest`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services