You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/04/07 22:12:05 UTC
[kudu-CR] [cmake modules] add '-o /dev/null' to the linker command
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18394
Change subject: [cmake_modules] add '-o /dev/null' to the linker command
......................................................................
[cmake_modules] add '-o /dev/null' to the linker command
I noticed that every time I run cmake in the build directory
on macOS, a.out file appears. It turned out it's generated
by the GET_LINKER_VERSION procedure from KuduLinker.cmake.
This patch add '-o /dev/null' to the command that determines
the version of the linker to avoid generating a.out file
in the current working directory.
Change-Id: Id095902679a2f0e2648c45bcd4024fc734b9a1e7
---
M cmake_modules/KuduLinker.cmake
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/18394/1
--
To view, visit http://gerrit.cloudera.org:8080/18394
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id095902679a2f0e2648c45bcd4024fc734b9a1e7
Gerrit-Change-Number: 18394
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [cmake modules] add '-o /dev/null' to the linker command
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18394 )
Change subject: [cmake_modules] add '-o /dev/null' to the linker command
......................................................................
[cmake_modules] add '-o /dev/null' to the linker command
I noticed that every time I run cmake in the build directory
on macOS, a.out file appears. It turned out it's generated
by the GET_LINKER_VERSION procedure from KuduLinker.cmake.
This patch add '-o /dev/null' to the command that determines
the version of the linker to avoid generating a.out file
in the current working directory.
Change-Id: Id095902679a2f0e2648c45bcd4024fc734b9a1e7
Reviewed-on: http://gerrit.cloudera.org:8080/18394
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M cmake_modules/KuduLinker.cmake
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexey Serbin: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18394
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id095902679a2f0e2648c45bcd4024fc734b9a1e7
Gerrit-Change-Number: 18394
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [cmake modules] add '-o /dev/null' to the linker command
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18394 )
Change subject: [cmake_modules] add '-o /dev/null' to the linker command
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18394
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id095902679a2f0e2648c45bcd4024fc734b9a1e7
Gerrit-Change-Number: 18394
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 08 Apr 2022 04:24:42 +0000
Gerrit-HasComments: No
[kudu-CR] [cmake modules] add '-o /dev/null' to the linker command
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18394 )
Change subject: [cmake_modules] add '-o /dev/null' to the linker command
......................................................................
Patch Set 1: Verified+1
unrelated test failures
--
To view, visit http://gerrit.cloudera.org:8080/18394
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id095902679a2f0e2648c45bcd4024fc734b9a1e7
Gerrit-Change-Number: 18394
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 08 Apr 2022 01:26:05 +0000
Gerrit-HasComments: No
[kudu-CR] [cmake modules] add '-o /dev/null' to the linker command
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [cmake_modules] add '-o /dev/null' to the linker command
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18394
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Id095902679a2f0e2648c45bcd4024fc734b9a1e7
Gerrit-Change-Number: 18394
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)