[GitHub] ashb commented on a change in pull request #4368: [AIRFLOW-3561] Improve queries

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #4368: [AIRFLOW-3561] Improve queries
URL: https://github.com/apache/airflow/pull/4368#discussion_r247224829
 
 

 ##########
 File path: airflow/models/__init__.py
 ##########
 @@ -2999,15 +2999,29 @@ class DagModel(Base):
     fileloc = Column(String(2000))
     # String representing the owners
     owners = Column(String(2000))
+    # Description of the dag
+    description = Column(Text)
+    # Default view of the inside the webserver
+    default_view = Column(String(25))
 
     def __repr__(self):
         return "<DAG: {self.dag_id}>".format(self=self)
 
+    @property
+    def timezone(self):
+        return settings.TIMEZONE
 
 Review comment:
   Wait up - this looks incorrect. Why was this removed?
   
   The timezone of a DAG was previously defined as the timezone of the start_date. Is that still the case and if we do `self.timezone = tz` then this property accessor won't be used anymore?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services