RE: Jdk1.1.x (commit please)

[Art Welch <ar...@EASTPOINT.COM>]

OK, I have done it... or well I have tried... I pulled down the latest CVS
as of noon today (10/25). I attempted to build under JDK 1.1.8 and found
that one of my earlier patches had not been committed and some new minor
problems had cropped up. So here is a new DIFF that should fix all this.
There also appears to be a problem with docs/examples/build.xml. It looks
like there is some confusion about the last test if it should be for
table.fo or textdeco.fo. I have left this alone since I am not sure what it
should be (I suspect there should be both). Anyhow other than this
runtests.sh successfully produced the PDFs under JVM 1.1.8. Note that one of
the files I had to change was lib/CompileXMLFiles.java and lib/Compare.java
needed to be recompiled. I am concerned that these may not be getting
recompiled with a new build (since Compare.java needed a recompile - no code
change: There was an exception about Vector.add() but the code already had
Vecor.addElement() maybe this was changed after the last build).

If someone would be kind enough to commit this I will then pull CVS again,
do another build (with no changes), and send Arved a copy of the JAR to
post. If someone would like to test my current JAR, let me know and I will
send you a copy (offer good until the official JAR is posted or 11/1/2000
whichever comes first) (but I will be out of the office tomorrow (10/26)).

So without any further ado... here is the DIFF:

cvs server: Diffing .
Index: build.xml
===================================================================
RCS file: /home/cvspublic/xml-fop/build.xml,v
retrieving revision 1.7
diff -r1.7 build.xml
160d159
<                      ,org/apache/fop/image/analyzer/*
162c161,162
<                      ,org/apache/fop/image/*
---
>                      ,**/GifJpegImage.java
>                      ,**/JimiImage.java

Index: lib/CompileXMLFiles.java
===================================================================
RCS file: /home/cvspublic/xml-fop/lib/CompileXMLFiles.java,v
retrieving revision 1.1
diff -r1.1 CompileXMLFiles.java
90c90
<   private ArrayList files = new ArrayList(); 
---
>   private Vector files = new Vector(); 
166c166
<     Iterator iterator = files.iterator();  
---
>     Enumeration iterator = files.elements();  
174,175c174,175
<       while (iterator.hasNext()) {
<         filename = (String) iterator.next();
---
>       while (iterator.hasMoreElements()) {
>         filename = (String) iterator.nextElement();
199c199
<       files.add(source);
---
>       files.addElement(source);

Index: src/org/apache/fop/dom/css/CSSStyleRuleImpl.java
===================================================================
RCS file:
/home/cvspublic/xml-fop/src/org/apache/fop/dom/css/CSSStyleRuleImpl.java,v
retrieving revision 1.1
diff -r1.1 CSSStyleRuleImpl.java
191c191
<                 selectors.add(current);
---
>                 selectors.addElement(current);

Index: src/org/apache/fop/dom/css/CSSStyleSheetImpl.java
===================================================================
RCS file:
/home/cvspublic/xml-fop/src/org/apache/fop/dom/css/CSSStyleSheetImpl.java,v
retrieving revision 1.1
diff -r1.1 CSSStyleSheetImpl.java
118c118
<         rules.remove(index);
---
>         rules.removeElementAt(index);

Index: src/org/apache/fop/image/analyser/ImageReaderFactory.java
===================================================================
RCS file:
/home/cvspublic/xml-fop/src/org/apache/fop/image/analyser/ImageReaderFactory
.java,v
retrieving revision 1.2
diff -r1.2 ImageReaderFactory.java
47,48c47,48
< import java.util.Iterator;
< import java.util.ArrayList;
---
> import java.util.Enumeration;
> import java.util.Vector;
59c59
<   static protected ArrayList formats = null;
---
>   static protected Vector formats = null;
72,77c72,77
<     formats = new ArrayList();
<     formats.add(new JPEGReader());
<     formats.add(new BMPReader());
<     formats.add(new GIFReader());
<     formats.add(new PNGReader());
<     formats.add(new SVGReader());
---
>     formats = new Vector();
>     formats.addElement(new JPEGReader());
>     formats.addElement(new BMPReader());
>     formats.addElement(new GIFReader());
>     formats.addElement(new PNGReader());
>     formats.addElement(new SVGReader());
82c82
<     Iterator itr = formats.iterator();
---
>     Enumeration itr = formats.elements();
84,85c84,85
<       while (itr.hasNext()) {
<         reader = (ImageReader) itr.next();
---
>       while (itr.hasMoreElements()) {
>         reader = (ImageReader) itr.nextElement();

Index: src/org/apache/fop/messaging/MessageHandler.java
===================================================================
RCS file:
/home/cvspublic/xml-fop/src/org/apache/fop/messaging/MessageHandler.java,v
retrieving revision 1.2
diff -r1.2 MessageHandler.java
55c55
< import javax.swing.*;
---
> //import javax.swing.*;

Index: src/org/apache/fop/svg/Symbol.java
===================================================================
RCS file: /home/cvspublic/xml-fop/src/org/apache/fop/svg/Symbol.java,v
retrieving revision 1.3
diff -r1.3 Symbol.java
121c121
< 				x = Float.parseFloat(st.nextToken());
---
> 				x =
Double.valueOf(st.nextToken()).floatValue();
124c124
< 				y = Float.parseFloat(st.nextToken());
---
> 				y =
Double.valueOf(st.nextToken()).floatValue();
127c127
< 				width = Float.parseFloat(st.nextToken());
---
> 				width =
Double.valueOf(st.nextToken()).floatValue();
130c130
< 				height = Float.parseFloat(st.nextToken());
---
> 				height =
Double.valueOf(st.nextToken()).floatValue();

*****CVS exited normally with code 1*****


-----Original Message-----
From: Art Welch 
Sent: Tuesday, October 24, 2000 2:24 PM
To: 'fop-dev@xml.apache.org'
Subject: RE: Jdk1.1.x


OK, I will do that. I will start with a new pull from CVS so that I can
confirm that all the required changes have been committed. I will also make
note of the date I do this so that users can relate the JAR to CVS. It may
be a couple of days before I can do this. Is there anything that I should
wait for to be committed before I do this? Will columns be done in the next
couple of days? (No rush... but it would be way cool if they were).

Personally I do not like the idea of multiple versions (jars or source). But
it is very handy to confirm that the desired functionality is clean for JVM
1.1 by compiling under JDK 1.1. But once this is done we could recompile
with JDK 1.2 and ship that version only.

As a JDK 1.1 user I consider it acceptable to get an exception if I attempt
to use functionality that requires JDK 1.2 as long as I know about it (and
the core functionality works). So if the core works, but image transparency,
AWT preview, etc do not - fine with me. I would not suggest that FOP
developers waste a lot of time trying to implement "fringe" functionality
for JDK 1.1.

Art

-----Original Message-----
From: Arved Sandstrom [mailto:Arved_37@chebucto.ns.ca]
Sent: Tuesday, October 24, 2000 5:39 AM
To: fop-dev@xml.apache.org
Subject: RE: Jdk1.1.x


At 01:49 PM 10/23/00 -0400, Art Welch wrote:
>I think that Christian's changes will have corrected the Collections
>problems. I also believe that someone has committed these already
>(Eric/Stephen?).
>
>I have not pulled down a new CVS in a while (since I applied Christian's
>changes to my local copy and did a few other changes). These allowed me to
>get a version working with JDK 1.1.8. If no-one else offers to produce a
1.1
>version I can pull down a new CVS and build/test a JAR for you. I would
>offer the jar that I am currently using, but it is a bit old and I think
>that I have a few debugging messages in it.
>
>P.S. I also think that it is possible to build/compile the jar on a JDK
1.2+
>machine and as long as no JDK 1.2+ specific functionality is encountered it
>runs just fine under JVM 1.1. At least this is what I had observed
>previously (but it has been a while since I have tested this - my last FOP
>builds have been on the JDK 1.1.8 machine - this will automatically point
>out JDK 1.2+ stuff)
>
>Art

Hi, Art

If you could do up a 1.1 JAR that would be great. I am a bit leery about the

latter proposition (building on 1.2 for 1.1), not because of byte code 
compatibility but just because someone using 1.1 to build is going to _know_

that what they deliver is compatible; me, using 1.2, can't guarantee that.

Arved

Senior Developer
e-plicity.com (www.e-plicity.com)
Halifax, Nova Scotia
"B2B Wireless in Canada's Ocean Playground"