[jira] [Commented] (JSPWIKI-1170) Support of Jakarta EE 9

["Julien Gouesse (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JSPWIKI-1170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17584243#comment-17584243 ] 

Julien Gouesse commented on JSPWIKI-1170:
-----------------------------------------

I've just tried to migrate, fileupload-2.0 (snapshot) is intended to support the jakarta namespace but it doesn't work:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project jspwiki-main: Compilation failure: Compilation failure:
[ERROR] jspwiki/jspwiki-main/src/main/java/org/apache/wiki/attachment/AttachmentServlet.java:[381,31] cannot access javax.servlet.http.HttpServletRequest
[ERROR]   class file for javax.servlet.http.HttpServletRequest not found
[ERROR] jspwiki/jspwiki-main/src/main/java/org/apache/wiki/attachment/AttachmentServlet.java:[400,48] no suitable method found for parseRequest(jakarta.servlet.http.HttpServletRequest)
[ERROR]     method org.apache.commons.fileupload2.FileUploadBase.parseRequest(org.apache.commons.fileupload2.RequestContext) is not applicable
[ERROR]       (argument mismatch; jakarta.servlet.http.HttpServletRequest cannot be converted to org.apache.commons.fileupload2.RequestContext)
[ERROR]     method org.apache.commons.fileupload2.servlet.ServletFileUpload.parseRequest(javax.servlet.http.HttpServletRequest) is not applicable
[ERROR]       (argument mismatch; jakarta.servlet.http.HttpServletRequest cannot be converted to javax.servlet.http.HttpServletRequest)

 

[~weberjn] I totally understand that there is no urgency *for you* but I don't use Tomcat, I use two application servers with Jakarta EE 9.1. I need to make it work. Please find enclosed the path with my changes [^jakarta.patch], there is still some work to do. I would appreciate a working solution in a snapshot version as a first step until the release of fileupload-2.0.

 

 

 

 

> Support of Jakarta EE 9
> -----------------------
>
>                 Key: JSPWIKI-1170
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-1170
>             Project: JSPWiki
>          Issue Type: Improvement
>            Reporter: Julien Gouesse
>            Priority: Major
>         Attachments: jakarta.patch, jspwiki.zip
>
>
> Jakarta EE 9 drops the javax namespace for the jakarta namespace. Currently, JspWiki uses the former namespace, Engine.getServletContext() returns an instance of javax.servlet.ServletContext instead of jakarta.servlet.ServletContext. Why not providing a separate Maven artefact with the WAR and the JARs compatible with Jakarta EE 9 and keeping the current WAR and JARs in the default artefact to please everyone (which is what Hibernate and Wildfly do as far as I know) ?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)