You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "ModEtchFill (via GitHub)" <gi...@apache.org> on 2025/05/22 04:11:20 UTC
[PR] nit: implement logred for run_spark_sql.sh (#1640) [polaris]
ModEtchFill opened a new pull request, #1648:
URL: https://github.com/apache/polaris/pull/1648
If logred is not present, implements a shell function. It may have some utility for test automation.
<!--
Possible security vulnerabilities: STOP here and contact security@apache.org instead!
Please update the title of the PR with a meaningful message - do not leave it "empty" or "generated"
Please update this summary field:
The summary should cover these topics, if applicable:
* the motivation for the change
* a description of the status quo, for example the current behavior
* the desired behavior
* etc
PR checklist:
- Do a self-review of your code before opening a pull request
- Make sure that there's good test coverage for the changes included in this PR
- Run tests locally before pushing a PR (./gradlew check)
- Code should have comments where applicable. Particularly hard-to-understand
areas deserve good in-line documentation.
- Include changes and enhancements to the documentation (in site/content/in-dev/unreleased)
- For Work In Progress Pull Requests, please use the Draft PR feature.
Make sure to add the information BELOW this comment.
Everything in this comment will NOT be added to the PR description.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nit: implement logred for run_spark_sql.sh (#1640) [polaris]
Posted by "ModEtchFill (via GitHub)" <gi...@apache.org>.
ModEtchFill commented on code in PR #1648:
URL: https://github.com/apache/polaris/pull/1648#discussion_r2102567165
##########
regtests/run_spark_sql.sh:
##########
@@ -52,6 +52,10 @@ export SPARK_LOCAL_HOSTNAME=localhost # avoid VPN messing up driver local IP add
./setup.sh
+if [ -z `which logred` ]; then
+ function logred() { echo $'\u001b'[0\;31m$*$'\u001b'[m; }
+fi
Review Comment:
Agreed. Switched and force-pushed to streamline git history
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nit: implement logred for run_spark_sql.sh (#1640) [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on PR #1648:
URL: https://github.com/apache/polaris/pull/1648#issuecomment-2901885990
Thanks @ModEtchFill for the fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nit: implement logred for run_spark_sql.sh (#1640) [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #1648:
URL: https://github.com/apache/polaris/pull/1648#discussion_r2101638983
##########
regtests/run_spark_sql.sh:
##########
@@ -52,6 +52,10 @@ export SPARK_LOCAL_HOSTNAME=localhost # avoid VPN messing up driver local IP add
./setup.sh
+if [ -z `which logred` ]; then
+ function logred() { echo $'\u001b'[0\;31m$*$'\u001b'[m; }
+fi
Review Comment:
I'd lean to replace `logred` with `echo`, which is simpler and more portable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nit: implement logred for run_spark_sql.sh (#1640) [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain merged PR #1648:
URL: https://github.com/apache/polaris/pull/1648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org