You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by edoardocomar <gi...@git.apache.org> on 2016/09/29 16:21:46 UTC

[GitHub] kafka pull request #1934: KAFKA-4206 Improve handling of invalid credentials...

GitHub user edoardocomar opened a pull request:

    https://github.com/apache/kafka/pull/1934

    KAFKA-4206 Improve handling of invalid credentials to mitigate DOS issue

    Delay closing channels for connections where a SALException has been
    thrown.
    
    This PR is a proof of concept and would like to stimulate feedback.
    This same approach has been used successfully in IBM MessageHub and **proved** capable of reducing dramatically the impact of SSL connections with wrong SASL credentials.
    Without this patch, a lot of cpu time is dedicated to SSL handshakes, many network threads are busy and the overall latencies suffer for already authenticated clients.
    
    this PR has been codeveloped with @mimaison 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/edoardocomar/kafka KAFKA-4206

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1934.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1934
    
----
commit ee21cc5e09a4f8cd4fbd42689d85907f16ee204a
Author: Edoardo Comar <ec...@uk.ibm.com>
Date:   2016-09-29T16:16:40Z

    KAFKA-4206 Improve handling of invalid credentials to mitigate DOS issue
    
    Delay closing channels for connections where a SALException has been
    thrown

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #1934: KAFKA-4206 Improve handling of invalid credentials...

Posted by edoardocomar <gi...@git.apache.org>.

Github user edoardocomar closed the pull request at:

    https://github.com/apache/kafka/pull/1934


---