[jira] Updated: (MYFACES-1429) Remove rest of the portlet API references from the portlet util.

["Raymond Lee (JIRA)" <de...@myfaces.apache.org>]

     [ https://issues.apache.org/jira/browse/MYFACES-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raymond Lee updated MYFACES-1429:
---------------------------------

    Status: Patch Available  (was: Open)

> Remove rest of the portlet API references from the portlet util.
> ----------------------------------------------------------------
>
>                 Key: MYFACES-1429
>                 URL: https://issues.apache.org/jira/browse/MYFACES-1429
>             Project: MyFaces Core
>          Issue Type: Sub-task
>          Components: Portlet_Support
>    Affects Versions: 1.1.4
>            Reporter: Polina Alber
>             Fix For: 1.1.4
>
>
> The source code of the portlet still presents import statements from the portlet API and references portlet API inside in the method:
>  /**
>          * Determine if we are processing a portlet RenderResponse.
>          *
>          * @param facesContext The current FacesContext.
>          * @return <code>true</code> if we are processing a RenderResponse,
>          *         <code>false</code> otherwise.
>          */
>         public static boolean isRenderResponse(FacesContext facesContext) {
>             if (!isPortletRequest(facesContext)) return false;
>             
>             return facesContext.getExternalContext().getResponse() instanceof RenderResponse;
>         }
> the method gets infoked from the org.apache.myfaces.application.jsp.JspViewHandlerImpl line 150 in the call: getActionURL. This call is referenced in the multiple places in jsf core distribution. 
> The clean way to resolve portlet api issue whould be to eliminate (compile and runtime) dependency on any of the portlet api classes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.