[GitHub] [incubator-devlake] klesh commented on a diff in pull request #5257: Zentao changelog

["klesh (via GitHub)" <gi...@apache.org>]

klesh commented on code in PR #5257:
URL: https://github.com/apache/incubator-devlake/pull/5257#discussion_r1204913668


##########
backend/plugins/zentao/api/blueprint_V200_test.go:
##########
@@ -82,9 +82,14 @@ func TestMakeDataSourcePipelinePlanV200(t *testing.T) {
 				Plugin:   "zentao",
 				Subtasks: []string{},
 				Options: map[string]interface{}{
-					"ConnectionId": uint64(1),
-					"productId":    int64(0),
-					"projectId":    int64(1),
+					"ConnectionId":   uint64(1),
+					"productId":      int64(0),
+					"projectId":      int64(1),
+					"RemoteDb":       nil,

Review Comment:
   No necessary



##########
backend/plugins/zentao/api/blueprint_V200_test.go:
##########
@@ -93,9 +98,14 @@ func TestMakeDataSourcePipelinePlanV200(t *testing.T) {
 				Plugin:   "zentao",
 				Subtasks: []string{},
 				Options: map[string]interface{}{
-					"ConnectionId": uint64(1),
-					"productId":    int64(1),
-					"projectId":    int64(0),
+					"ConnectionId":   uint64(1),
+					"productId":      int64(1),
+					"projectId":      int64(0),
+					"RemoteDb":       nil,

Review Comment:
   Same as above



##########
backend/plugins/zentao/api/blueprint_v200.go:
##########
@@ -81,6 +82,7 @@ func makePipelinePlanV200(
 				return nil, nil, errors.Default.Wrap(err, fmt.Sprintf("fail to find zentao project %s", bpScope.Id))
 			}
 			op.ProjectId = scope.Id
+			op.DbUrl = connection.DbUrl

Review Comment:
   Either we put all db connection settings into the `Connection` object or `TaskData`.
   Placing them both places create unnecessary complex.
   
   I think putting them into `Connection` makes more sense.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org