[GitHub] [spark] wangyum commented on a change in pull request #25417: [SPARK-28686][SQL][TEST] Move udf_radians from HiveCompatibilitySuite to HiveQuerySuite

[GitBox <gi...@apache.org>]

wangyum commented on a change in pull request #25417: [SPARK-28686][SQL][TEST] Move udf_radians from HiveCompatibilitySuite to HiveQuerySuite
URL: https://github.com/apache/spark/pull/25417#discussion_r312803739
 
 

 ##########
 File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
 ##########
 @@ -1207,6 +1208,22 @@ class HiveQuerySuite extends HiveComparisonTest with SQLTestUtils with BeforeAnd
       }
     }
   }
+
+  // This test case is moved from HiveCompatibilitySuite to make it easy to test with JDK 11.
+  test("udf_radians") {
+    withSQLConf("hive.fetch.task.conversion" -> "more") {
+      val result = sql("select radians(57.2958) FROM src tablesample (1 rows)").collect()
+      if (SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9)) {
 
 Review comment:
   It's from JDK 9:
   ```shell
   [root@spark-3267648 jdk-9.0.4+11]# bin/jshell
   |  Welcome to JShell -- Version 9.0.4
   |  For an introduction type: /help intro
   
   jshell> System.out.println(java.lang.Math.toRadians(57.2958));
   1.0000003575641672
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org