You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/08/26 19:52:57 UTC

[GitHub] [incubator-pinot] renato2099 edited a comment on pull request #5910: 5804: Prints file name of invalid json file when parsing

renato2099 edited a comment on pull request #5910:
URL: https://github.com/apache/incubator-pinot/pull/5910#issuecomment-681089584


   I was not sure which were the code paths that could use the json parsing, that is why I added it where it actually takes place.
   I moved it now to the createSegmentCommand as per your suggestion @Jackie-Jiang  I decided to keep the test as I think it is good that we add tests for these commands, let me know what you think.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org