[jira] [Commented] (HIVE-21225) ACID: getAcidState() should cache a recursive dir listing locally

["Gopal V (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-21225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856170#comment-16856170 ] 

Gopal V commented on HIVE-21225:
--------------------------------

This patch looks good, but it still does 2 things - it generates one FS OP per delta dir (i.e the more delta dirs, the more listing calls).

The DirSnapshot can be based off the partition recursive listing one-shot.

And please verify if the IOW base_n dirs are actually found when doing the listFiles via the {{_orc_acid_version}} marker.

> ACID: getAcidState() should cache a recursive dir listing locally
> -----------------------------------------------------------------
>
>                 Key: HIVE-21225
>                 URL: https://issues.apache.org/jira/browse/HIVE-21225
>             Project: Hive
>          Issue Type: Improvement
>          Components: Transactions
>            Reporter: Gopal V
>            Assignee: Vaibhav Gumashta
>            Priority: Major
>         Attachments: HIVE-21225.1.patch, HIVE-21225.2.patch, async-pid-44-2.svg
>
>
> Currently getAcidState() makes 3 calls into the FS api which could be answered by making a single recursive listDir call and reusing the same data to check for isRawFormat() and isValidBase().
> All delta operations for a single partition can go against a single listed directory snapshot instead of interacting with the NameNode or ObjectStore within the inner loop.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)