[GitHub] [pulsar] rdhabalia commented on a change in pull request #4455: [pulsar-ml] handle race condition between timeout-task and add-call complete

[GitBox <gi...@apache.org>]

rdhabalia commented on a change in pull request #4455: [pulsar-ml] handle race condition between timeout-task and add-call complete
URL: https://github.com/apache/pulsar/pull/4455#discussion_r290533206
 
 

 ##########
 File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpAddEntry.java
 ##########
 @@ -97,14 +97,12 @@ public void initiate() {
         ByteBuf duplicateBuffer = data.retainedDuplicate();
 
         // internally asyncAddEntry() will take the ownership of the buffer and release it at the end
-        lastInitTime = System.nanoTime();
+        this.ctxForCallbackComplete = ctx;
 
 Review comment:
   umm.. actually ctx text is part of multiple variable and keeping `this` here makes more readable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services