You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/21 03:53:40 UTC
[GitHub] [beam] boyuanzz opened a new pull request #11475: Fix SplittableParDoNaiveBounded DoFnInvoker.
boyuanzz opened a new pull request #11475:
URL: https://github.com/apache/beam/pull/11475
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on issue #11475: [BEAM-8872] Fix SplittableParDoNaiveBounded DoFnInvoker.
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on issue #11475:
URL: https://github.com/apache/beam/pull/11475#issuecomment-617330125
> 1 out of 5 passing runs isn't great. Was it 1 out of 5 before as well?
I think so. I ran the same test with reverting OffsetRangeTracker changes and also got similar failures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on issue #11475: [BEAM-8872] Fix SplittableParDoNaiveBounded DoFnInvoker.
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on issue #11475:
URL: https://github.com/apache/beam/pull/11475#issuecomment-617338448
Run Flink ValidatesRunner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on issue #11475: [BEAM-8872] Fix SplittableParDoNaiveBounded DoFnInvoker.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11475:
URL: https://github.com/apache/beam/pull/11475#issuecomment-617317875
1 out of 5 isn't great.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on issue #11475: [BEAM-8872] Fix SplittableParDoNaiveBounded DoFnInvoker.
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on issue #11475:
URL: https://github.com/apache/beam/pull/11475#issuecomment-617354631
Run Flink ValidatesRunner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik edited a comment on issue #11475: [BEAM-8872] Fix SplittableParDoNaiveBounded DoFnInvoker.
Posted by GitBox <gi...@apache.org>.
lukecwik edited a comment on issue #11475:
URL: https://github.com/apache/beam/pull/11475#issuecomment-617317875
1 out of 5 passing runs isn't great. Was it 1 out of 5 before as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on issue #11475: [BEAM-8872] Fix SplittableParDoNaiveBounded DoFnInvoker.
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on issue #11475:
URL: https://github.com/apache/beam/pull/11475#issuecomment-617314308
The test doesn't fail deterministically, about 1 of 5 runs is successful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on issue #11475: [BEAM-8872] Fix SplittableParDoNaiveBounded DoFnInvoker.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11475:
URL: https://github.com/apache/beam/pull/11475#issuecomment-617263481
This fixed batch but failed on streaming. You should be able to test locally with `./gradlew :runners:flink:1.10:validatesRunnerStreaming` and `./gradlew :runners:flink:1.10:validatesRunnerBatch`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on issue #11475: [BEAM-8872] Fix SplittableParDoNaiveBounded DoFnInvoker.
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on issue #11475:
URL: https://github.com/apache/beam/pull/11475#issuecomment-617316552
Run Flink ValidatesRunner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on issue #11475: Fix SplittableParDoNaiveBounded DoFnInvoker.
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on issue #11475:
URL: https://github.com/apache/beam/pull/11475#issuecomment-616935921
Run Dataflow ValidatesRunner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on issue #11475: [BEAM-8872] Fix SplittableParDoNaiveBounded DoFnInvoker.
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on issue #11475:
URL: https://github.com/apache/beam/pull/11475#issuecomment-617302058
Run Flink ValidatesRunner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on issue #11475: [BEAM-8872] Fix SplittableParDoNaiveBounded DoFnInvoker.
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on issue #11475:
URL: https://github.com/apache/beam/pull/11475#issuecomment-617264598
> This fixed batch but failed on streaming. You should be able to test locally with `./gradlew :runners:flink:1.10:validatesRunnerStreaming` and `./gradlew :runners:flink:1.10:validatesRunnerBatch`
Thanks! It's weird that unbounded one is successful on dataflow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on issue #11475: [BEAM-8872] Fix SplittableParDoNaiveBounded DoFnInvoker.
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on issue #11475:
URL: https://github.com/apache/beam/pull/11475#issuecomment-617282101
> This fixed batch but failed on streaming. You should be able to test locally with `./gradlew :runners:flink:1.10:validatesRunnerStreaming` and `./gradlew :runners:flink:1.10:validatesRunnerBatch`
Thanks! It's weird that unbounded one is successful on dataflow. Maybe dataflow doesn't run unbounded tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on issue #11475: [BEAM-8872] Fix SplittableParDoNaiveBounded DoFnInvoker.
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on issue #11475:
URL: https://github.com/apache/beam/pull/11475#issuecomment-617315986
I checked one flaky test with more logs: https://screenshot.googleplex.com/D68EiAUov5N. I don't the failure/flakiness is related to changes of `OffsetRangeTracker`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on issue #11475: [BEAM-8872] Fix SplittableParDoNaiveBounded DoFnInvoker.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11475:
URL: https://github.com/apache/beam/pull/11475#issuecomment-617256374
Run Spark ValidatesRunner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on issue #11475: [BEAM-8872] Fix SplittableParDoNaiveBounded DoFnInvoker.
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on issue #11475:
URL: https://github.com/apache/beam/pull/11475#issuecomment-617264655
> This fixed batch but failed on streaming. You should be able to test locally with `./gradlew :runners:flink:1.10:validatesRunnerStreaming` and `./gradlew :runners:flink:1.10:validatesRunnerBatch`
Thanks! It's weird that unbounded one is successful on dataflow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on issue #11475: [BEAM-8872] Fix SplittableParDoNaiveBounded DoFnInvoker.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11475:
URL: https://github.com/apache/beam/pull/11475#issuecomment-617255520
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org