[jira] Commented: (DERBY-3088) convert to junit, or otherwise eliminate version in tests which require an update of the master in the release management process

["Daniel John Debrunner (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550197 ] 

Daniel John Debrunner commented on DERBY-3088:
----------------------------------------------

I think this code in the decorateTest() is problematic:

+        NetworkServerTestSetup networkServerTestSetup =
+            new NetworkServerTestSetup(spt,
+                startupProps, startupArgs, true, true, 
+                spt._inputStreamHolder);
+        spt.nsTestSetup = networkServerTestSetup;
+        Test testSetup =
+            SecurityManagerSetup.noSecurityManager(networkServerTestSetup);
+        Test test = TestConfiguration.defaultServerDecorator(testSetup);
+        test = TestConfiguration.clientServerDecorator(test);

Two NetworkServerTestSetup decorators are being used, one explicitly and one by clientServerDecorator. Both of these will try to start the server, I believe on the same port, which wil probably lead to hangs.



> convert to junit, or otherwise eliminate version in tests which require an update of the master in the release management process
> ---------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3088
>                 URL: https://issues.apache.org/jira/browse/DERBY-3088
>             Project: Derby
>          Issue Type: Improvement
>          Components: Build tools, Test
>            Reporter: Myrna van Lunteren
>            Assignee: Myrna van Lunteren
>         Attachments: DERBY-3088_ServerPropertiesTest.diff
>
>
> There are a number of tests that require a master update every time the version number is bumped.
> This is a tedious and error prone detail in the release management process.
> Currently affected masters are listed in tools/release/build.xml:
> java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/metadata.out
> java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/odbc_metadata.out
> java/testing/org/apache/derbyTesting/functionTests/master/metadata.out
> java/testing/org/apache/derbyTesting/functionTests/master/odbc_metadata.out
> java/testing/org/apache/derbyTesting/functionTests/master/NSinSameJVM.out
> java/testing/org/apache/derbyTesting/functionTests/master/checkToursDB.out
> java/testing/org/apache/derbyTesting/functionTests/master/testclientij.out
> java/testing/org/apache/derbyTesting/functionTests/master/testProperties.out
> It would streamline the release process if these tests in particular were either converted to junit, or if the version numbers would be eliminated.
> Note: there already is a bug for metadata.java conversion: DERBY-2242

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.