You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "mbutrovich (via GitHub)" <gi...@apache.org> on 2026/09/23 18:12:46 UTC
[PR] ci: Stop requiring PR branches to be up to date with `main` before merging [datafusion-iceberg]
mbutrovich opened a new pull request, #17:
URL: https://github.com/apache/datafusion-iceberg/pull/17
## Which issue does this PR close?
Closes #16.
## Rationale for this change
`strict: true` under `required_status_checks` forces every approved PR to click "Update branch" and rerun CI whenever another PR merges, even without conflicts. Removing it matches `apache/datafusion`, which lists required checks without `strict`: https://github.com/apache/datafusion/blob/7570366fd929daf9ced744bb8397686b50565b18/.asf.yaml#L54-L55
## What changes are included in this PR?
This removes `strict: true` and its comment from `.asf.yaml`. ASF infra defaults `strict` to `false` when it isn't set: https://github.com/apache/infrastructure-asfyaml/blob/63cc23dc61b2290b9b09c243ef04b4ca11ba24d3/README.md#L612-L627
The required checks (`Format`, `Clippy`, `Test`, `asf-allowlist-check`) don't change.
The tradeoff is that CI no longer tests the merged commit before it lands on `main`. If we want that, a merge queue is the alternative, as #16 describes.
## Are these changes tested?
No. This only changes branch protection settings. ASF infra applies them after the PR merges.
## Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ci: Stop requiring PR branches to be up to date with `main` before merging [datafusion-iceberg]
Posted by "NoahKusaba (via GitHub)" <gi...@apache.org>.
NoahKusaba commented on PR #17:
URL: https://github.com/apache/datafusion-iceberg/pull/17#issuecomment-5820635863
Thanks everyone for taking the time to review :bow:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ci: Stop requiring PR branches to be up to date with `main` before merging [datafusion-iceberg]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #17:
URL: https://github.com/apache/datafusion-iceberg/pull/17#issuecomment-5802631453
Thanks @mbutrovich -- I think we should get this repo moving fast, so I suggest we merge PRs aggressively for a while until it settles down
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ci: Stop requiring PR branches to be up to date with `main` before merging [datafusion-iceberg]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #17:
URL: https://github.com/apache/datafusion-iceberg/pull/17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org