[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #2063: [improve] job submit parameter improvement

[GitBox <gi...@apache.org>]

wolfboys commented on code in PR #2063:
URL: https://github.com/apache/incubator-streampark/pull/2063#discussion_r1027286814


##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/AppBuildPipeServiceImpl.java:
##########
@@ -445,16 +445,13 @@ public Map<Long, PipelineStatus> listPipelineStatus(List<Long> appIds) {
             return Maps.newHashMap();
         }
         LambdaQueryWrapper<AppBuildPipeline> queryWrapper = new LambdaQueryWrapper<AppBuildPipeline>()
-            .select(AppBuildPipeline::getAppId, AppBuildPipeline::getPipeStatusCode)
             .in(AppBuildPipeline::getAppId, appIds);
-        List<Map<String, Object>> rMaps = baseMapper.selectMaps(queryWrapper);
+
+        List<AppBuildPipeline> rMaps = baseMapper.selectList(queryWrapper);

Review Comment:
   > @wolfboys Except that the naming of the variable `rMaps` needs to be standardized, I have not found any other problems. I will test it as a whole after the merger
   
   thanks for your review. I will improve what you mentioned



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org