You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/10/12 11:15:46 UTC
[GitHub] [rocketmq] RapperCL opened a new issue, #5294: ClassLoad path optimization
RapperCL opened a new issue, #5294:
URL: https://github.com/apache/rocketmq/issues/5294
LoadClass optimization:
The class path is obtained through the getName() method, and when the class path changes due to the non-written path, it needs to be modified synchronously, otherwise the loading will fail.
<img width="1098" alt="image" src="https://user-images.githubusercontent.com/44110731/195328287-6132e204-71eb-4f1c-b41e-45c98a43a635.png">
for example:
org.apache.rocketmq.broker.BrokerController.initialTransaction()
<img width="1329" alt="image" src="https://user-images.githubusercontent.com/44110731/195328586-f20595ad-173b-4bdc-aa97-ab0177e43abb.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codersfarm commented on issue #5294: ClassLoad path optimization
Posted by GitBox <gi...@apache.org>.
codersfarm commented on issue #5294:
URL: https://github.com/apache/rocketmq/issues/5294#issuecomment-1277310569
Class Path is should be pre-arranged,Why to fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] ClassLoad path optimization [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #5294:
URL: https://github.com/apache/rocketmq/issues/5294#issuecomment-1763215307
This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhimins commented on issue #5294: ClassLoad path optimization
Posted by GitBox <gi...@apache.org>.
lizhimins commented on issue #5294:
URL: https://github.com/apache/rocketmq/issues/5294#issuecomment-1276923168
I'm not sure whether this optimization will have side effects on shade
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RapperCL commented on issue #5294: ClassLoad path optimization
Posted by GitBox <gi...@apache.org>.
RapperCL commented on issue #5294:
URL: https://github.com/apache/rocketmq/issues/5294#issuecomment-1278712009
@lizhimins hi，I have restored the original loading method so that it doesn't affect other places where the method is called. Do you think this change will solve your concern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RapperCL commented on issue #5294: ClassLoad path optimization
Posted by GitBox <gi...@apache.org>.
RapperCL commented on issue #5294:
URL: https://github.com/apache/rocketmq/issues/5294#issuecomment-1277424226
> Class Path is should be pre-arranged,Why to fix it?
1 The classpath is determined at the beginning, but may be modified later;
2 When loading other classes, you need to specify the classpath, which is unreasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] ClassLoad path optimization [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #5294: ClassLoad path optimization
URL: https://github.com/apache/rocketmq/issues/5294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RapperCL commented on issue #5294: ClassLoad path optimization
Posted by GitBox <gi...@apache.org>.
RapperCL commented on issue #5294:
URL: https://github.com/apache/rocketmq/issues/5294#issuecomment-1277051798
> I'm not sure whether this optimization will have side effects on shade
ok，then I keep the original method so it doesn't have side effects on shade
for example：
what do you think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] ClassLoad path optimization [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #5294:
URL: https://github.com/apache/rocketmq/issues/5294#issuecomment-1769662600
This issue was closed because it has been inactive for 3 days since being marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org